All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ARM: i.MX6: add new silicon revision number 1.6
@ 2018-01-09 12:51 Christoph Fritz
  2018-01-10 12:15 ` Fabio Estevam
  2018-02-02  5:36 ` Shawn Guo
  0 siblings, 2 replies; 6+ messages in thread
From: Christoph Fritz @ 2018-01-09 12:51 UTC (permalink / raw)
  To: linux-arm-kernel

This patch adds new silicon revision number 1.6 as specified in document
IMX6DQCEC.pdf.

Signed-off-by: Christoph Fritz <chf.fritz@googlemail.com>
---
 arch/arm/mach-imx/anatop.c | 4 ++++
 include/soc/imx/revision.h | 1 +
 2 files changed, 5 insertions(+)

diff --git a/arch/arm/mach-imx/anatop.c b/arch/arm/mach-imx/anatop.c
index 649a84c..deb98b8 100644
--- a/arch/arm/mach-imx/anatop.c
+++ b/arch/arm/mach-imx/anatop.c
@@ -157,6 +157,10 @@ void __init imx_init_revision_from_anatop(void)
 		 */
 		revision = IMX_CHIP_REVISION_1_5;
 		break;
+	case 6:
+		/* marked as 'E' in part number last character */
+		revision = IMX_CHIP_REVISION_1_6;
+		break;
 	default:
 		/*
 		 * Fail back to return raw register value instead of 0xff.
diff --git a/include/soc/imx/revision.h b/include/soc/imx/revision.h
index 9ea3469..cd4c847 100644
--- a/include/soc/imx/revision.h
+++ b/include/soc/imx/revision.h
@@ -15,6 +15,7 @@
 #define IMX_CHIP_REVISION_1_3		0x13
 #define IMX_CHIP_REVISION_1_4		0x14
 #define IMX_CHIP_REVISION_1_5		0x15
+#define IMX_CHIP_REVISION_1_6		0x16
 #define IMX_CHIP_REVISION_2_0		0x20
 #define IMX_CHIP_REVISION_2_1		0x21
 #define IMX_CHIP_REVISION_2_2		0x22
-- 
2.1.4

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH] ARM: i.MX6: add new silicon revision number 1.6
@ 2018-01-09 13:00 Christoph Fritz
  2018-01-11  7:50 ` Sascha Hauer
  0 siblings, 1 reply; 6+ messages in thread
From: Christoph Fritz @ 2018-01-09 13:00 UTC (permalink / raw)
  To: barebox

This patch adds new silicon revision number 1.6 as specified in document
IMX6DQCEC.pdf.

Signed-off-by: Christoph Fritz <chf.fritz@googlemail.com>
---
 arch/arm/mach-imx/include/mach/imx6.h     | 2 ++
 arch/arm/mach-imx/include/mach/revision.h | 1 +
 2 files changed, 3 insertions(+)

diff --git a/arch/arm/mach-imx/include/mach/imx6.h b/arch/arm/mach-imx/include/mach/imx6.h
index e0ced7e..288c753 100644
--- a/arch/arm/mach-imx/include/mach/imx6.h
+++ b/arch/arm/mach-imx/include/mach/imx6.h
@@ -109,6 +109,8 @@ static inline int __imx6_cpu_revision(void)
 		return IMX_CHIP_REV_1_4;
 	case 0x05:
 		return IMX_CHIP_REV_1_5;
+	case 0x06:
+		return IMX_CHIP_REV_1_6;
 	case 0x100:
 		return IMX_CHIP_REV_2_0;
 	}
diff --git a/arch/arm/mach-imx/include/mach/revision.h b/arch/arm/mach-imx/include/mach/revision.h
index 908a0a1..d9495d9 100644
--- a/arch/arm/mach-imx/include/mach/revision.h
+++ b/arch/arm/mach-imx/include/mach/revision.h
@@ -8,6 +8,7 @@
 #define IMX_CHIP_REV_1_3	0x13
 #define IMX_CHIP_REV_1_4	0x14
 #define IMX_CHIP_REV_1_5	0x15
+#define IMX_CHIP_REV_1_6	0x16
 #define IMX_CHIP_REV_2_0	0x20
 #define IMX_CHIP_REV_2_1	0x21
 #define IMX_CHIP_REV_2_2	0x22
-- 
2.1.4


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH] ARM: i.MX6: add new silicon revision number 1.6
  2018-01-09 12:51 [PATCH] ARM: i.MX6: add new silicon revision number 1.6 Christoph Fritz
@ 2018-01-10 12:15 ` Fabio Estevam
  2018-02-02  5:36 ` Shawn Guo
  1 sibling, 0 replies; 6+ messages in thread
From: Fabio Estevam @ 2018-01-10 12:15 UTC (permalink / raw)
  To: linux-arm-kernel

On Tue, Jan 9, 2018 at 10:51 AM, Christoph Fritz
<chf.fritz@googlemail.com> wrote:

> This patch adds new silicon revision number 1.6 as specified in document
> IMX6DQCEC.pdf.
>
> Signed-off-by: Christoph Fritz <chf.fritz@googlemail.com>

Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: i.MX6: add new silicon revision number 1.6
  2018-01-09 13:00 Christoph Fritz
@ 2018-01-11  7:50 ` Sascha Hauer
  0 siblings, 0 replies; 6+ messages in thread
From: Sascha Hauer @ 2018-01-11  7:50 UTC (permalink / raw)
  To: Christoph Fritz; +Cc: barebox

On Tue, Jan 09, 2018 at 02:00:05PM +0100, Christoph Fritz wrote:
> This patch adds new silicon revision number 1.6 as specified in document
> IMX6DQCEC.pdf.
> 
> Signed-off-by: Christoph Fritz <chf.fritz@googlemail.com>
> ---
>  arch/arm/mach-imx/include/mach/imx6.h     | 2 ++
>  arch/arm/mach-imx/include/mach/revision.h | 1 +
>  2 files changed, 3 insertions(+)

Applied, thanks

Sascha

> 
> diff --git a/arch/arm/mach-imx/include/mach/imx6.h b/arch/arm/mach-imx/include/mach/imx6.h
> index e0ced7e..288c753 100644
> --- a/arch/arm/mach-imx/include/mach/imx6.h
> +++ b/arch/arm/mach-imx/include/mach/imx6.h
> @@ -109,6 +109,8 @@ static inline int __imx6_cpu_revision(void)
>  		return IMX_CHIP_REV_1_4;
>  	case 0x05:
>  		return IMX_CHIP_REV_1_5;
> +	case 0x06:
> +		return IMX_CHIP_REV_1_6;
>  	case 0x100:
>  		return IMX_CHIP_REV_2_0;
>  	}
> diff --git a/arch/arm/mach-imx/include/mach/revision.h b/arch/arm/mach-imx/include/mach/revision.h
> index 908a0a1..d9495d9 100644
> --- a/arch/arm/mach-imx/include/mach/revision.h
> +++ b/arch/arm/mach-imx/include/mach/revision.h
> @@ -8,6 +8,7 @@
>  #define IMX_CHIP_REV_1_3	0x13
>  #define IMX_CHIP_REV_1_4	0x14
>  #define IMX_CHIP_REV_1_5	0x15
> +#define IMX_CHIP_REV_1_6	0x16
>  #define IMX_CHIP_REV_2_0	0x20
>  #define IMX_CHIP_REV_2_1	0x21
>  #define IMX_CHIP_REV_2_2	0x22
> -- 
> 2.1.4
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [PATCH] ARM: i.MX6: add new silicon revision number 1.6
  2018-01-09 12:51 [PATCH] ARM: i.MX6: add new silicon revision number 1.6 Christoph Fritz
  2018-01-10 12:15 ` Fabio Estevam
@ 2018-02-02  5:36 ` Shawn Guo
  2018-02-02 11:25   ` Christoph Fritz
  1 sibling, 1 reply; 6+ messages in thread
From: Shawn Guo @ 2018-02-02  5:36 UTC (permalink / raw)
  To: linux-arm-kernel

On Tue, Jan 09, 2018 at 01:51:13PM +0100, Christoph Fritz wrote:
> This patch adds new silicon revision number 1.6 as specified in document
> IMX6DQCEC.pdf.
> 
> Signed-off-by: Christoph Fritz <chf.fritz@googlemail.com>

We have a patch [1] from Bai Ping that reworks the code.  It makes your
patch unnecessary?

Shawn

[1] https://patchwork.ozlabs.org/patch/857284/

> ---
>  arch/arm/mach-imx/anatop.c | 4 ++++
>  include/soc/imx/revision.h | 1 +
>  2 files changed, 5 insertions(+)
> 
> diff --git a/arch/arm/mach-imx/anatop.c b/arch/arm/mach-imx/anatop.c
> index 649a84c..deb98b8 100644
> --- a/arch/arm/mach-imx/anatop.c
> +++ b/arch/arm/mach-imx/anatop.c
> @@ -157,6 +157,10 @@ void __init imx_init_revision_from_anatop(void)
>  		 */
>  		revision = IMX_CHIP_REVISION_1_5;
>  		break;
> +	case 6:
> +		/* marked as 'E' in part number last character */
> +		revision = IMX_CHIP_REVISION_1_6;
> +		break;
>  	default:
>  		/*
>  		 * Fail back to return raw register value instead of 0xff.
> diff --git a/include/soc/imx/revision.h b/include/soc/imx/revision.h
> index 9ea3469..cd4c847 100644
> --- a/include/soc/imx/revision.h
> +++ b/include/soc/imx/revision.h
> @@ -15,6 +15,7 @@
>  #define IMX_CHIP_REVISION_1_3		0x13
>  #define IMX_CHIP_REVISION_1_4		0x14
>  #define IMX_CHIP_REVISION_1_5		0x15
> +#define IMX_CHIP_REVISION_1_6		0x16
>  #define IMX_CHIP_REVISION_2_0		0x20
>  #define IMX_CHIP_REVISION_2_1		0x21
>  #define IMX_CHIP_REVISION_2_2		0x22
> -- 
> 2.1.4
> 

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [PATCH] ARM: i.MX6: add new silicon revision number 1.6
  2018-02-02  5:36 ` Shawn Guo
@ 2018-02-02 11:25   ` Christoph Fritz
  0 siblings, 0 replies; 6+ messages in thread
From: Christoph Fritz @ 2018-02-02 11:25 UTC (permalink / raw)
  To: linux-arm-kernel

On Fri, 2018-02-02 at 13:36 +0800, Shawn Guo wrote:
> On Tue, Jan 09, 2018 at 01:51:13PM +0100, Christoph Fritz wrote:
> > This patch adds new silicon revision number 1.6 as specified in document
> > IMX6DQCEC.pdf.
> > 
> > Signed-off-by: Christoph Fritz <chf.fritz@googlemail.com>
> 
> We have a patch [1] from Bai Ping that reworks the code.  It makes your
> patch unnecessary?
> 
> Shawn
> 
> [1] https://patchwork.ozlabs.org/patch/857284/

v2 of this patch is OK

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-02-02 11:25 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-09 12:51 [PATCH] ARM: i.MX6: add new silicon revision number 1.6 Christoph Fritz
2018-01-10 12:15 ` Fabio Estevam
2018-02-02  5:36 ` Shawn Guo
2018-02-02 11:25   ` Christoph Fritz
  -- strict thread matches above, loose matches on Subject: below --
2018-01-09 13:00 Christoph Fritz
2018-01-11  7:50 ` Sascha Hauer

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.