From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3 3/9] package/dash: add /etc/dash to /etc/shells
Date: Sat, 3 Feb 2018 15:55:02 +0100 [thread overview]
Message-ID: <20180203145501.GD2369@scaer> (raw)
In-Reply-To: <1516356909-18620-4-git-send-email-romain.naour@smile.fr>
Romain, All,
On 2018-01-19 11:15 +0100, Romain Naour spake thusly:
> When dash is selected, /bin/dash is not added to /etc/shells
> (see man shells). So, login tools like dropbear reject the ssh
> connections for users using dash as shell in /etc/passwd.
>
> buildroot authpriv.warn dropbear[853]: User 'kubu' has invalid shell, rejected
>
> Signed-off-by: Romain Naour <romain.naour@smile.fr>
Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Regards,
Yann E. MORIN.
> ---
> v3: Fix typo (Thomas)
> Use TARGET_FINALIZE_HOOKS to avoid issues with the upcoming
> top-level parallel build (Arnout)
> v2: add double-dollar after /bin/dash (Yann)
> ---
> package/dash/dash.mk | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/package/dash/dash.mk b/package/dash/dash.mk
> index c8b4164..2a3fd0d 100644
> --- a/package/dash/dash.mk
> +++ b/package/dash/dash.mk
> @@ -13,4 +13,12 @@ define DASH_INSTALL_TARGET_CMDS
> $(INSTALL) -m 0755 $(@D)/src/dash $(TARGET_DIR)/bin/dash
> endef
>
> +# Add /bin/dash to /etc/shells otherwise some login tools like dropbear
> +# can reject the user connection. See man shells.
> +define DASH_ADD_DASH_TO_SHELLS
> + grep -qsE '^/bin/dash$$' $(TARGET_DIR)/etc/shells \
> + || echo "/bin/dash" >> $(TARGET_DIR)/etc/shells
> +endef
> +DASH_TARGET_FINALIZE_HOOKS += DASH_ADD_DASH_TO_SHELLS
> +
> $(eval $(autotools-package))
> --
> 2.7.4
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2018-02-03 14:55 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-19 10:15 [Buildroot] [PATCH v3 0/9] Add /etc/shells handling Romain Naour
2018-01-19 10:15 ` [Buildroot] [PATCH v3 1/9] package/skeleton-init-common: add /bin/sh to /etc/shells Romain Naour
2018-02-03 14:50 ` Yann E. MORIN
2018-01-19 10:15 ` [Buildroot] [PATCH v3 2/9] package/busybox: add /bin/{a, hu}sh " Romain Naour
2018-02-03 14:53 ` Yann E. MORIN
2018-01-19 10:15 ` [Buildroot] [PATCH v3 3/9] package/dash: add /etc/dash " Romain Naour
2018-02-03 14:55 ` Yann E. MORIN [this message]
2018-01-19 10:15 ` [Buildroot] [PATCH v3 4/9] package/screen: add /usr/bin/screen " Romain Naour
2018-02-03 14:58 ` Yann E. MORIN
2018-05-03 21:27 ` Thomas Petazzoni
2018-01-19 10:15 ` [Buildroot] [PATCH v3 5/9] package/tmux: add /usr/bin/tmux " Romain Naour
2018-02-03 14:59 ` Yann E. MORIN
2018-01-19 10:15 ` [Buildroot] [PATCH v3 6/9] package/zsh: add /bin/zsh " Romain Naour
2018-02-03 15:00 ` Yann E. MORIN
2018-01-19 10:15 ` [Buildroot] [PATCH v3 7/9] package/mksh: add /bin/mksh " Romain Naour
2018-02-03 15:01 ` Yann E. MORIN
2018-01-19 10:15 ` [Buildroot] [PATCH v3 8/9] package/bash: add missing double-dollar for /etc/shells Romain Naour
2018-02-03 15:01 ` Yann E. MORIN
2018-01-19 10:15 ` [Buildroot] [PATCH v3 9/9] package/bash: use target finalize hook Romain Naour
2018-02-03 15:13 ` Yann E. MORIN
2018-05-03 21:26 ` [Buildroot] [PATCH v3 0/9] Add /etc/shells handling Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180203145501.GD2369@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.