All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3 9/9] package/bash: use target finalize hook
Date: Sat, 3 Feb 2018 16:13:38 +0100	[thread overview]
Message-ID: <20180203151338.GJ2369@scaer> (raw)
In-Reply-To: <1516356909-18620-10-git-send-email-romain.naour@smile.fr>

Romain, All,

On 2018-01-19 11:15 +0100, Romain Naour spake thusly:
> Arnout reported an issue with the upcoming top-level parallel build.
> The file /etc/shells can be modified by several packages (shell providers)
> 
> Signed-off-by: Romain Naour <romain.naour@smile.fr>
> Cc: Arnout Vandecappelle <arnout@mind.be>

Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

> ---
>  package/bash/bash.mk | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/package/bash/bash.mk b/package/bash/bash.mk
> index ab6b43b..12f33f1 100644
> --- a/package/bash/bash.mk
> +++ b/package/bash/bash.mk
> @@ -40,14 +40,18 @@ endif
>  endif
>  
>  # Make /bin/sh -> bash (no other shell, better than busybox shells)

While reviewing this patch, I was really puzzled at what this comment
meant. It turns out I was not careful years ago when I made /bin/sh
configurable.

Patch sent: https://patchwork.ozlabs.org/patch/868907/

Regards,
Yann E. MORIN.

> -# Add /bin/bash to /etc/shells otherwise some login tools like dropbear
> -# can reject the user connexion. See man shells.
>  define BASH_INSTALL_TARGET_CMDS
>  	$(TARGET_MAKE_ENV) $(MAKE) -C $(@D) \
>  		DESTDIR=$(TARGET_DIR) exec_prefix=/ install
>  	rm -f $(TARGET_DIR)/bin/bashbug
> +endef
> +
> +# Add /bin/bash to /etc/shells otherwise some login tools like dropbear
> +# can reject the user connection. See man shells.
> +define BASH_ADD_MKSH_TO_SHELLS
>  	grep -qsE '^/bin/bash$$' $(TARGET_DIR)/etc/shells \
>  		|| echo "/bin/bash" >> $(TARGET_DIR)/etc/shells
>  endef
> +BASH_TARGET_FINALIZE_HOOKS += BASH_ADD_MKSH_TO_SHELLS
>  
>  $(eval $(autotools-package))
> -- 
> 2.7.4
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2018-02-03 15:13 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-19 10:15 [Buildroot] [PATCH v3 0/9] Add /etc/shells handling Romain Naour
2018-01-19 10:15 ` [Buildroot] [PATCH v3 1/9] package/skeleton-init-common: add /bin/sh to /etc/shells Romain Naour
2018-02-03 14:50   ` Yann E. MORIN
2018-01-19 10:15 ` [Buildroot] [PATCH v3 2/9] package/busybox: add /bin/{a, hu}sh " Romain Naour
2018-02-03 14:53   ` Yann E. MORIN
2018-01-19 10:15 ` [Buildroot] [PATCH v3 3/9] package/dash: add /etc/dash " Romain Naour
2018-02-03 14:55   ` Yann E. MORIN
2018-01-19 10:15 ` [Buildroot] [PATCH v3 4/9] package/screen: add /usr/bin/screen " Romain Naour
2018-02-03 14:58   ` Yann E. MORIN
2018-05-03 21:27     ` Thomas Petazzoni
2018-01-19 10:15 ` [Buildroot] [PATCH v3 5/9] package/tmux: add /usr/bin/tmux " Romain Naour
2018-02-03 14:59   ` Yann E. MORIN
2018-01-19 10:15 ` [Buildroot] [PATCH v3 6/9] package/zsh: add /bin/zsh " Romain Naour
2018-02-03 15:00   ` Yann E. MORIN
2018-01-19 10:15 ` [Buildroot] [PATCH v3 7/9] package/mksh: add /bin/mksh " Romain Naour
2018-02-03 15:01   ` Yann E. MORIN
2018-01-19 10:15 ` [Buildroot] [PATCH v3 8/9] package/bash: add missing double-dollar for /etc/shells Romain Naour
2018-02-03 15:01   ` Yann E. MORIN
2018-01-19 10:15 ` [Buildroot] [PATCH v3 9/9] package/bash: use target finalize hook Romain Naour
2018-02-03 15:13   ` Yann E. MORIN [this message]
2018-05-03 21:26 ` [Buildroot] [PATCH v3 0/9] Add /etc/shells handling Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180203151338.GJ2369@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.