From: Alexander Sergeyev <sergeev917@gmail.com>
To: "Mario Limonciello" <mario.limonciello@dell.com>,
"Matthew Garrett" <mjg59@srcf.ucam.org>,
"Pali Rohár" <pali.rohar@gmail.com>,
"Darren Hart" <dvhart@infradead.org>,
"Andy Shevchenko" <andy@infradead.org>
Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: PROBLEM: NULL pointer dereference in dell_set_arguments() in 4.15
Date: Sat, 3 Feb 2018 23:22:43 +0300 [thread overview]
Message-ID: <20180203202243.GA5109@localhost.localdomain> (raw)
In-Reply-To: <20180203162021.GA4571@localhost.localdomain>
On Sat, Feb 03, 2018 at 07:20:21PM +0300, Alexander Sergeyev wrote:
> # first bad commit: [549b4930f057658dc50d8010e66219233119a4d8] platform/x86:
>dell-smbios: Introduce dispatcher for SMM calls
From source code (at 549b4930f057) it looks like dell_set_arguments() which
>writes to `buffer` is called before the buffer gets allocated
Turns out that the problem has already surfaced before, but from a different
origin -- namely, rfkill interface [1]. This was subsequently fixed in
5246741a3f2e and c6f9288ee460.
This time there is an ordering problem between initialization of the
dell-laptop module and audio modules which are trying to flash a microphone
mute led on keyboard (via dell-laptop interface).
And about suspend-to-ram wakeup problem -- is it possible that there was some
buggy interaction with smbios that led to the observed behaviour?
[1] https://lkml.org/lkml/2017/11/15/705
WARNING: multiple messages have this Message-ID (diff)
From: Alexander Sergeyev <sergeev917@gmail.com>
To: "Mario Limonciello" <mario.limonciello@dell.com>,
"Matthew Garrett" <mjg59@srcf.ucam.org>,
"Pali Rohár" <pali.rohar@gmail.com>,
"Darren Hart" <dvhart@infradead.org>,
"Andy Shevchenko" <andy@infradead.org>
Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: PROBLEM: NULL pointer dereference in dell_set_arguments() in 4.15
Date: Sat, 3 Feb 2018 23:22:43 +0300 [thread overview]
Message-ID: <20180203202243.GA5109@localhost.localdomain> (raw)
In-Reply-To: <20180203162021.GA4571@localhost.localdomain>
On Sat, Feb 03, 2018 at 07:20:21PM +0300, Alexander Sergeyev wrote:
> # first bad commit: [549b4930f057658dc50d8010e66219233119a4d8] platform/x86:
>dell-smbios: Introduce dispatcher for SMM calls
>From source code (at 549b4930f057) it looks like dell_set_arguments() which
>writes to `buffer` is called before the buffer gets allocated
Turns out that the problem has already surfaced before, but from a different
origin -- namely, rfkill interface [1]. This was subsequently fixed in
5246741a3f2e and c6f9288ee460.
This time there is an ordering problem between initialization of the
dell-laptop module and audio modules which are trying to flash a microphone
mute led on keyboard (via dell-laptop interface).
And about suspend-to-ram wakeup problem -- is it possible that there was some
buggy interaction with smbios that led to the observed behaviour?
[1] https://lkml.org/lkml/2017/11/15/705
next prev parent reply other threads:[~2018-02-03 20:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-03 16:20 PROBLEM: NULL pointer dereference in dell_set_arguments() in 4.15 Alexander Sergeyev
2018-02-03 16:20 ` Alexander Sergeyev
2018-02-03 20:22 ` Alexander Sergeyev [this message]
2018-02-03 20:22 ` Alexander Sergeyev
[not found] ` <e489f5ee-34e5-4777-afe7-38d31d2ad3fd@Dell.com>
2018-02-04 9:23 ` Alexander Sergeyev
2018-02-04 12:15 ` Pali Rohár
2018-02-04 14:25 ` Andy Shevchenko
2018-02-04 16:29 ` Alexander Sergeyev
2018-02-04 16:29 ` Alexander Sergeyev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180203202243.GA5109@localhost.localdomain \
--to=sergeev917@gmail.com \
--cc=andy@infradead.org \
--cc=dvhart@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.limonciello@dell.com \
--cc=mjg59@srcf.ucam.org \
--cc=pali.rohar@gmail.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.