* Re: [PATCH] ARM: dts: imx6sx: add pu power domain support
@ 2018-01-25 15:30 ` Dong Aisheng
0 siblings, 0 replies; 12+ messages in thread
From: Dong Aisheng @ 2018-01-25 15:30 UTC (permalink / raw)
To: Anson Huang
Cc: shawnguo, kernel, fabio.estevam, robh+dt, aisheng.dong,
mark.rutland, linux, Linux-imx, linux-arm-kernel, devicetree,
linux-kernel
On Tue, Jan 23, 2018 at 11:12:23PM +0800, Anson Huang wrote:
> Add PU power domain support, GPU is the only
> module inside PU power domain, and PU power
> is supplied by LDO_SOC.
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> ---
> arch/arm/boot/dts/imx6sx.dtsi | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx6sx.dtsi b/arch/arm/boot/dts/imx6sx.dtsi
> index fd78793..42ef4c6 100644
> --- a/arch/arm/boot/dts/imx6sx.dtsi
> +++ b/arch/arm/boot/dts/imx6sx.dtsi
> @@ -188,6 +188,7 @@
> <&clks IMX6SX_CLK_GPU>,
> <&clks IMX6SX_CLK_GPU>;
> clock-names = "bus", "core", "shader";
> + power-domains = <&pd_pu>;
> };
>
> dma_apbh: dma-apbh@1804000 {
> @@ -767,6 +768,13 @@
> #address-cells = <1>;
> #size-cells = <0>;
>
> + pd_pu: power-domain@1 {
> + reg = <1>;
> + #power-domain-cells = <0>;
> + power-supply = <®_soc>;
I wonder we may not need this as it's a non-stop domain
just like we did for arm domain, right?
Otherwise, the patch looks fine to me.
Acked-by: Dong Aisheng <aisheng.dong@nxp.com>
Regards
Dong Aisheng
> + clocks = <&clks IMX6SX_CLK_GPU>;
> + };
> +
> pd_pci: power-domain@3 {
> reg = <3>;
> #power-domain-cells = <0>;
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH] ARM: dts: imx6sx: add pu power domain support
@ 2018-01-25 15:30 ` Dong Aisheng
0 siblings, 0 replies; 12+ messages in thread
From: Dong Aisheng @ 2018-01-25 15:30 UTC (permalink / raw)
To: Anson Huang
Cc: shawnguo-DgEjT+Ai2ygdnm+yROfE0A, kernel-bIcnvbaLZ9MEGnE8C9+IrQ,
fabio.estevam-3arQi8VN3Tc, robh+dt-DgEjT+Ai2ygdnm+yROfE0A,
aisheng.dong-3arQi8VN3Tc, mark.rutland-5wv7dgnIgG8,
linux-I+IVW8TIWO2tmTQ+vhA3Yw, Linux-imx-3arQi8VN3Tc,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
On Tue, Jan 23, 2018 at 11:12:23PM +0800, Anson Huang wrote:
> Add PU power domain support, GPU is the only
> module inside PU power domain, and PU power
> is supplied by LDO_SOC.
>
> Signed-off-by: Anson Huang <Anson.Huang-3arQi8VN3Tc@public.gmane.org>
> ---
> arch/arm/boot/dts/imx6sx.dtsi | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx6sx.dtsi b/arch/arm/boot/dts/imx6sx.dtsi
> index fd78793..42ef4c6 100644
> --- a/arch/arm/boot/dts/imx6sx.dtsi
> +++ b/arch/arm/boot/dts/imx6sx.dtsi
> @@ -188,6 +188,7 @@
> <&clks IMX6SX_CLK_GPU>,
> <&clks IMX6SX_CLK_GPU>;
> clock-names = "bus", "core", "shader";
> + power-domains = <&pd_pu>;
> };
>
> dma_apbh: dma-apbh@1804000 {
> @@ -767,6 +768,13 @@
> #address-cells = <1>;
> #size-cells = <0>;
>
> + pd_pu: power-domain@1 {
> + reg = <1>;
> + #power-domain-cells = <0>;
> + power-supply = <®_soc>;
I wonder we may not need this as it's a non-stop domain
just like we did for arm domain, right?
Otherwise, the patch looks fine to me.
Acked-by: Dong Aisheng <aisheng.dong-3arQi8VN3Tc@public.gmane.org>
Regards
Dong Aisheng
> + clocks = <&clks IMX6SX_CLK_GPU>;
> + };
> +
> pd_pci: power-domain@3 {
> reg = <3>;
> #power-domain-cells = <0>;
> --
> 2.7.4
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 12+ messages in thread* [PATCH] ARM: dts: imx6sx: add pu power domain support
2018-01-25 15:30 ` Dong Aisheng
(?)
@ 2018-01-26 6:32 ` Anson Huang
-1 siblings, 0 replies; 12+ messages in thread
From: Anson Huang @ 2018-01-26 6:32 UTC (permalink / raw)
To: linux-arm-kernel
-----Original Message-----
From: Dong Aisheng [mailto:dongas86 at gmail.com]
Sent: 2018?1?25? 23:30
To: Anson Huang <anson.huang@nxp.com>
Cc: shawnguo at kernel.org; kernel at pengutronix.de; Fabio Estevam <fabio.estevam@nxp.com>; robh+dt at kernel.org; A.s. Dong <aisheng.dong@nxp.com>; mark.rutland at arm.com; linux at armlinux.org.uk; dl-linux-imx <linux-imx@nxp.com>; linux-arm-kernel at lists.infradead.org; devicetree at vger.kernel.org; linux-kernel at vger.kernel.org
Subject: Re: [PATCH] ARM: dts: imx6sx: add pu power domain support
On Tue, Jan 23, 2018 at 11:12:23PM +0800, Anson Huang wrote:
> Add PU power domain support, GPU is the only module inside PU power
> domain, and PU power is supplied by LDO_SOC.
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> ---
> arch/arm/boot/dts/imx6sx.dtsi | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx6sx.dtsi
> b/arch/arm/boot/dts/imx6sx.dtsi index fd78793..42ef4c6 100644
> --- a/arch/arm/boot/dts/imx6sx.dtsi
> +++ b/arch/arm/boot/dts/imx6sx.dtsi
> @@ -188,6 +188,7 @@
> <&clks IMX6SX_CLK_GPU>,
> <&clks IMX6SX_CLK_GPU>;
> clock-names = "bus", "core", "shader";
> + power-domains = <&pd_pu>;
> };
>
> dma_apbh: dma-apbh at 1804000 {
> @@ -767,6 +768,13 @@
> #address-cells = <1>;
> #size-cells = <0>;
>
> + pd_pu: power-domain at 1 {
> + reg = <1>;
> + #power-domain-cells = <0>;
> + power-supply = <®_soc>;
I wonder we may not need this as it's a non-stop domain just like we did for arm domain, right?
Otherwise, the patch looks fine to me.
Acked-by: Dong Aisheng <aisheng.dong@nxp.com>
No, this domain can be power gated, there is an internal power gate in GPC, just the input
power can NOT be disabled. So there might be some leakage in this domain, but power still
can be saved a lot if internal power gate is off.
Anson.
Regards
Dong Aisheng
> + clocks = <&clks IMX6SX_CLK_GPU>;
> + };
> +
> pd_pci: power-domain at 3 {
> reg = <3>;
> #power-domain-cells = <0>;
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 12+ messages in thread* RE: [PATCH] ARM: dts: imx6sx: add pu power domain support
@ 2018-01-26 6:32 ` Anson Huang
0 siblings, 0 replies; 12+ messages in thread
From: Anson Huang @ 2018-01-26 6:32 UTC (permalink / raw)
To: Dong Aisheng
Cc: shawnguo@kernel.org, kernel@pengutronix.de, Fabio Estevam,
robh+dt@kernel.org, A.s. Dong, mark.rutland@arm.com,
linux@armlinux.org.uk, dl-linux-imx,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
-----Original Message-----
From: Dong Aisheng [mailto:dongas86@gmail.com]
Sent: 2018年1月25日 23:30
To: Anson Huang <anson.huang@nxp.com>
Cc: shawnguo@kernel.org; kernel@pengutronix.de; Fabio Estevam <fabio.estevam@nxp.com>; robh+dt@kernel.org; A.s. Dong <aisheng.dong@nxp.com>; mark.rutland@arm.com; linux@armlinux.org.uk; dl-linux-imx <linux-imx@nxp.com>; linux-arm-kernel@lists.infradead.org; devicetree@vger.kernel.org; linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: imx6sx: add pu power domain support
On Tue, Jan 23, 2018 at 11:12:23PM +0800, Anson Huang wrote:
> Add PU power domain support, GPU is the only module inside PU power
> domain, and PU power is supplied by LDO_SOC.
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> ---
> arch/arm/boot/dts/imx6sx.dtsi | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx6sx.dtsi
> b/arch/arm/boot/dts/imx6sx.dtsi index fd78793..42ef4c6 100644
> --- a/arch/arm/boot/dts/imx6sx.dtsi
> +++ b/arch/arm/boot/dts/imx6sx.dtsi
> @@ -188,6 +188,7 @@
> <&clks IMX6SX_CLK_GPU>,
> <&clks IMX6SX_CLK_GPU>;
> clock-names = "bus", "core", "shader";
> + power-domains = <&pd_pu>;
> };
>
> dma_apbh: dma-apbh@1804000 {
> @@ -767,6 +768,13 @@
> #address-cells = <1>;
> #size-cells = <0>;
>
> + pd_pu: power-domain@1 {
> + reg = <1>;
> + #power-domain-cells = <0>;
> + power-supply = <®_soc>;
I wonder we may not need this as it's a non-stop domain just like we did for arm domain, right?
Otherwise, the patch looks fine to me.
Acked-by: Dong Aisheng <aisheng.dong@nxp.com>
No, this domain can be power gated, there is an internal power gate in GPC, just the input
power can NOT be disabled. So there might be some leakage in this domain, but power still
can be saved a lot if internal power gate is off.
Anson.
Regards
Dong Aisheng
> + clocks = <&clks IMX6SX_CLK_GPU>;
> + };
> +
> pd_pci: power-domain@3 {
> reg = <3>;
> #power-domain-cells = <0>;
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 12+ messages in thread* RE: [PATCH] ARM: dts: imx6sx: add pu power domain support
@ 2018-01-26 6:32 ` Anson Huang
0 siblings, 0 replies; 12+ messages in thread
From: Anson Huang @ 2018-01-26 6:32 UTC (permalink / raw)
To: Dong Aisheng
Cc: shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org, Fabio Estevam,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, A.s. Dong,
mark.rutland-5wv7dgnIgG8@public.gmane.org,
linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org, dl-linux-imx,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
-----Original Message-----
From: Dong Aisheng [mailto:dongas86@gmail.com]
Sent: 2018年1月25日 23:30
To: Anson Huang <anson.huang@nxp.com>
Cc: shawnguo@kernel.org; kernel@pengutronix.de; Fabio Estevam <fabio.estevam@nxp.com>; robh+dt@kernel.org; A.s. Dong <aisheng.dong@nxp.com>; mark.rutland@arm.com; linux@armlinux.org.uk; dl-linux-imx <linux-imx@nxp.com>; linux-arm-kernel@lists.infradead.org; devicetree@vger.kernel.org; linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: imx6sx: add pu power domain support
On Tue, Jan 23, 2018 at 11:12:23PM +0800, Anson Huang wrote:
> Add PU power domain support, GPU is the only module inside PU power
> domain, and PU power is supplied by LDO_SOC.
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> ---
> arch/arm/boot/dts/imx6sx.dtsi | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx6sx.dtsi
> b/arch/arm/boot/dts/imx6sx.dtsi index fd78793..42ef4c6 100644
> --- a/arch/arm/boot/dts/imx6sx.dtsi
> +++ b/arch/arm/boot/dts/imx6sx.dtsi
> @@ -188,6 +188,7 @@
> <&clks IMX6SX_CLK_GPU>,
> <&clks IMX6SX_CLK_GPU>;
> clock-names = "bus", "core", "shader";
> + power-domains = <&pd_pu>;
> };
>
> dma_apbh: dma-apbh@1804000 {
> @@ -767,6 +768,13 @@
> #address-cells = <1>;
> #size-cells = <0>;
>
> + pd_pu: power-domain@1 {
> + reg = <1>;
> + #power-domain-cells = <0>;
> + power-supply = <®_soc>;
I wonder we may not need this as it's a non-stop domain just like we did for arm domain, right?
Otherwise, the patch looks fine to me.
Acked-by: Dong Aisheng <aisheng.dong@nxp.com>
No, this domain can be power gated, there is an internal power gate in GPC, just the input
power can NOT be disabled. So there might be some leakage in this domain, but power still
can be saved a lot if internal power gate is off.
Anson.
Regards
Dong Aisheng
> + clocks = <&clks IMX6SX_CLK_GPU>;
> + };
> +
> pd_pci: power-domain@3 {
> reg = <3>;
> #power-domain-cells = <0>;
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 12+ messages in thread