From: shawnguo@kernel.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 1/2] ARM: dts: imx25-pinfunc: Use consistent naming for eSDHC
Date: Mon, 5 Feb 2018 16:28:11 +0800 [thread overview]
Message-ID: <20180205082809.GT31354@dragon> (raw)
In-Reply-To: <20180131213544.4508-1-benoit.thebaudeau.dev@gmail.com>
On Wed, Jan 31, 2018 at 10:35:43PM +0100, Beno?t Th?baudeau wrote:
> This file had several naming inconsistencies for eSDHC:
> - the instances were named sometimes SDn, sometimes SDHCn, whereas they
> are named ESDHCn in the reference manual, e.g.:
> MX25_PAD_SD1_CMD__SD1_CMD
> MX25_PAD_D15__SDHC1_DAT7
> - the data ports were named sometimes DATAn, sometimes DATn like in the
> reference manual, e.g.:
> MX25_PAD_SD1_DATA0__SD1_DATA0
> MX25_PAD_D15__SDHC1_DAT7
> - in one case, the clock port was named DAT_CLK instead of CLK:
> MX25_PAD_CSI_D7__SDHC2_DAT_CLK
>
> This change:
> - introduces new definitions using the naming from the reference
> manual,
> - keeps definitions using the legacy naming in order not to break
> compatibility for out-of-tree users (they can be removed later),
> - updates the in-tree files that were using the legacy naming.
>
> Cc: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
> Signed-off-by: Beno?t Th?baudeau <benoit.thebaudeau.dev@gmail.com>
> Acked-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
Applied both, thanks.
WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: "Benoît Thébaudeau"
<benoit.thebaudeau.dev-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
"Russell King" <linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org>,
"Mark Rutland" <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
"Rob Herring" <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
"Fabio Estevam" <fabio.estevam-3arQi8VN3Tc@public.gmane.org>,
"Sascha Hauer" <kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
"Uwe Kleine-König"
<u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
"Michael Nazzareno Trimarchi"
<michael-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org>
Subject: Re: [PATCH v3 1/2] ARM: dts: imx25-pinfunc: Use consistent naming for eSDHC
Date: Mon, 5 Feb 2018 16:28:11 +0800 [thread overview]
Message-ID: <20180205082809.GT31354@dragon> (raw)
In-Reply-To: <20180131213544.4508-1-benoit.thebaudeau.dev-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
On Wed, Jan 31, 2018 at 10:35:43PM +0100, Benoît Thébaudeau wrote:
> This file had several naming inconsistencies for eSDHC:
> - the instances were named sometimes SDn, sometimes SDHCn, whereas they
> are named ESDHCn in the reference manual, e.g.:
> MX25_PAD_SD1_CMD__SD1_CMD
> MX25_PAD_D15__SDHC1_DAT7
> - the data ports were named sometimes DATAn, sometimes DATn like in the
> reference manual, e.g.:
> MX25_PAD_SD1_DATA0__SD1_DATA0
> MX25_PAD_D15__SDHC1_DAT7
> - in one case, the clock port was named DAT_CLK instead of CLK:
> MX25_PAD_CSI_D7__SDHC2_DAT_CLK
>
> This change:
> - introduces new definitions using the naming from the reference
> manual,
> - keeps definitions using the legacy naming in order not to break
> compatibility for out-of-tree users (they can be removed later),
> - updates the in-tree files that were using the legacy naming.
>
> Cc: Uwe Kleine-König <u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
> Signed-off-by: Benoît Thébaudeau <benoit.thebaudeau.dev-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> Acked-by: Uwe Kleine-König <u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Applied both, thanks.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org>
To: "Benoît Thébaudeau" <benoit.thebaudeau.dev@gmail.com>
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
"Russell King" <linux@armlinux.org.uk>,
"Mark Rutland" <mark.rutland@arm.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Fabio Estevam" <fabio.estevam@nxp.com>,
"Sascha Hauer" <kernel@pengutronix.de>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Michael Nazzareno Trimarchi" <michael@amarulasolutions.com>
Subject: Re: [PATCH v3 1/2] ARM: dts: imx25-pinfunc: Use consistent naming for eSDHC
Date: Mon, 5 Feb 2018 16:28:11 +0800 [thread overview]
Message-ID: <20180205082809.GT31354@dragon> (raw)
In-Reply-To: <20180131213544.4508-1-benoit.thebaudeau.dev@gmail.com>
On Wed, Jan 31, 2018 at 10:35:43PM +0100, Benoît Thébaudeau wrote:
> This file had several naming inconsistencies for eSDHC:
> - the instances were named sometimes SDn, sometimes SDHCn, whereas they
> are named ESDHCn in the reference manual, e.g.:
> MX25_PAD_SD1_CMD__SD1_CMD
> MX25_PAD_D15__SDHC1_DAT7
> - the data ports were named sometimes DATAn, sometimes DATn like in the
> reference manual, e.g.:
> MX25_PAD_SD1_DATA0__SD1_DATA0
> MX25_PAD_D15__SDHC1_DAT7
> - in one case, the clock port was named DAT_CLK instead of CLK:
> MX25_PAD_CSI_D7__SDHC2_DAT_CLK
>
> This change:
> - introduces new definitions using the naming from the reference
> manual,
> - keeps definitions using the legacy naming in order not to break
> compatibility for out-of-tree users (they can be removed later),
> - updates the in-tree files that were using the legacy naming.
>
> Cc: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> Signed-off-by: Benoît Thébaudeau <benoit.thebaudeau.dev@gmail.com>
> Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Applied both, thanks.
next prev parent reply other threads:[~2018-02-05 8:28 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-31 21:35 [PATCH v3 1/2] ARM: dts: imx25-pinfunc: Use consistent naming for eSDHC Benoît Thébaudeau
2018-01-31 21:35 ` Benoît Thébaudeau
2018-01-31 21:35 ` [PATCH v3 2/2] ARM: dts: imx25-pinfunc: Always set SION for eSDHC CMD Benoît Thébaudeau
2018-01-31 21:35 ` Benoît Thébaudeau
2018-02-01 7:57 ` Uwe Kleine-König
2018-02-01 7:57 ` Uwe Kleine-König
2018-02-01 7:57 ` Uwe Kleine-König
2018-02-05 6:08 ` Rob Herring
2018-02-05 6:08 ` Rob Herring
2018-02-05 6:08 ` Rob Herring
2018-01-31 22:22 ` [PATCH v3 1/2] ARM: dts: imx25-pinfunc: Use consistent naming for eSDHC Fabio Estevam
2018-01-31 22:22 ` Fabio Estevam
2018-02-05 6:08 ` Rob Herring
2018-02-05 6:08 ` Rob Herring
2018-02-05 8:28 ` Shawn Guo [this message]
2018-02-05 8:28 ` Shawn Guo
2018-02-05 8:28 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180205082809.GT31354@dragon \
--to=shawnguo@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.