From: Brian Woods <brian.woods@amd.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Brian Woods <brian.woods@amd.com>,
Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>,
xen-devel@lists.xen.org
Subject: Re: [PATCH 2/3] x86/svm: add EFER SVME support for VGIF/VLOAD
Date: Mon, 5 Feb 2018 10:47:32 -0600 [thread overview]
Message-ID: <20180205164732.GB8527@amd.com> (raw)
In-Reply-To: <5A782D4B02000078001A519C@prv-mh.provo.novell.com>
On Mon, Feb 05, 2018 at 02:09:15AM -0700, Jan Beulich wrote:
> If the latter check was moved to the caller, the whole function
> would perhaps be better placed in nestedsvm.c?
I thought about putting it in nestedsvm.c but I thought having it as a
static function would be better. I could move it to nestedsvm.c
though.
> Can you please avoid "== 0" and "== 1" on boolean fields (even
> if, like in the case here, the bitfield has u64 as underlying type,
> which is sort of pointless)?
>
> Jan
svm.c is older and uses "== X", and I was trying to keep it consistent
within the file. For things like if () {\n,} \{, which are
inconsistent, I always use if () \n \{. Should I only be using boolean?
--
Brian Woods
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-02-05 16:47 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-31 20:35 [PATCH 0/3] Various SVM Cleanups Brian Woods
2018-01-31 20:35 ` [PATCH 1/3] x86/svm: update VGIF support Brian Woods
2018-02-03 16:51 ` Boris Ostrovsky
2018-01-31 20:35 ` [PATCH 2/3] x86/svm: add EFER SVME support for VGIF/VLOAD Brian Woods
2018-02-03 16:55 ` Boris Ostrovsky
2018-02-05 9:09 ` Jan Beulich
2018-02-05 16:47 ` Brian Woods [this message]
2018-02-05 17:02 ` Jan Beulich
2018-02-05 15:37 ` Andrew Cooper
2018-02-05 16:39 ` Brian Woods
2018-02-07 21:06 ` [PATCH v2 " Brian Woods
2018-02-07 21:15 ` Brian Woods
[not found] ` <5A7B6A7C0200003403432E6E@prv-mh.provo.novell.com>
2018-02-08 9:45 ` Jan Beulich
2018-02-08 16:23 ` Brian Woods
[not found] ` <5A7C82880200003F043E54B7@prv-mh.provo.novell.com>
2018-02-13 9:31 ` [PATCH v3 " Jan Beulich
2018-02-13 18:37 ` Woods, Brian
2018-02-14 8:01 ` Jan Beulich
2018-02-08 17:01 ` Brian Woods
2018-02-20 22:27 ` [PATCH v4 " Brian Woods
2018-02-20 22:52 ` Boris Ostrovsky
2018-02-20 22:00 ` [PATCH v2 " Brian Woods
2018-02-20 22:09 ` Boris Ostrovsky
2018-02-20 22:14 ` Brian Woods
2018-01-31 20:35 ` [PATCH 3/3] x86/svm: correct EFER.SVME intercept checks Brian Woods
2018-02-03 17:03 ` Boris Ostrovsky
2018-02-03 17:10 ` Andrew Cooper
2018-02-03 17:15 ` Boris Ostrovsky
2018-02-05 9:18 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180205164732.GB8527@amd.com \
--to=brian.woods@amd.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.