From: Brian Woods <brian.woods@amd.com>
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
Brian Woods <brian.woods@amd.com>,
Jan Beulich <jbeulich@suse.com>,
Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>,
xen-devel@lists.xen.org
Subject: Re: [PATCH v2 2/3] x86/svm: add EFER SVME support for VGIF/VLOAD
Date: Tue, 20 Feb 2018 16:14:44 -0600 [thread overview]
Message-ID: <20180220221428.GA17542@amd.com> (raw)
In-Reply-To: <fb2888eb-6cc6-c256-79c0-dc7e167edcb5@oracle.com>
On Tue, Feb 20, 2018 at 05:09:24PM -0500, Boris Ostrovsky wrote:
> That's possibly because you needed an SVM maintainer ACK.
>
> I think Jan was waiting for decision on how to present the ASSERT. From
> the 3 options I slightly more prefer
>
> ASSERT(nestedhvm_enabled(v->domain) || !(v->arch.hvm_vcpu.guest_efer & EFER_SVME));
>
> (which wasn't the first choice for either of you ;-))
>
> -boris
I'll change it and send out a new version then.
--
Brian Woods
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-02-20 22:14 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-31 20:35 [PATCH 0/3] Various SVM Cleanups Brian Woods
2018-01-31 20:35 ` [PATCH 1/3] x86/svm: update VGIF support Brian Woods
2018-02-03 16:51 ` Boris Ostrovsky
2018-01-31 20:35 ` [PATCH 2/3] x86/svm: add EFER SVME support for VGIF/VLOAD Brian Woods
2018-02-03 16:55 ` Boris Ostrovsky
2018-02-05 9:09 ` Jan Beulich
2018-02-05 16:47 ` Brian Woods
2018-02-05 17:02 ` Jan Beulich
2018-02-05 15:37 ` Andrew Cooper
2018-02-05 16:39 ` Brian Woods
2018-02-07 21:06 ` [PATCH v2 " Brian Woods
2018-02-07 21:15 ` Brian Woods
[not found] ` <5A7B6A7C0200003403432E6E@prv-mh.provo.novell.com>
2018-02-08 9:45 ` Jan Beulich
2018-02-08 16:23 ` Brian Woods
[not found] ` <5A7C82880200003F043E54B7@prv-mh.provo.novell.com>
2018-02-13 9:31 ` [PATCH v3 " Jan Beulich
2018-02-13 18:37 ` Woods, Brian
2018-02-14 8:01 ` Jan Beulich
2018-02-08 17:01 ` Brian Woods
2018-02-20 22:27 ` [PATCH v4 " Brian Woods
2018-02-20 22:52 ` Boris Ostrovsky
2018-02-20 22:00 ` [PATCH v2 " Brian Woods
2018-02-20 22:09 ` Boris Ostrovsky
2018-02-20 22:14 ` Brian Woods [this message]
2018-01-31 20:35 ` [PATCH 3/3] x86/svm: correct EFER.SVME intercept checks Brian Woods
2018-02-03 17:03 ` Boris Ostrovsky
2018-02-03 17:10 ` Andrew Cooper
2018-02-03 17:15 ` Boris Ostrovsky
2018-02-05 9:18 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180220221428.GA17542@amd.com \
--to=brian.woods@amd.com \
--cc=andrew.cooper3@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=jbeulich@suse.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.