From: keith.busch@intel.com (Keith Busch)
Subject: [PATCH] nvme-pci: Fix incorrect use of CMB size to calculate q_depth
Date: Tue, 6 Feb 2018 08:05:52 -0700 [thread overview]
Message-ID: <20180206150552.GD31110@localhost.localdomain> (raw)
In-Reply-To: <1517869943-3655-1-git-send-email-sbates@raithlin.com>
On Mon, Feb 05, 2018@03:32:23PM -0700, sbates@raithlin.com wrote:
>
> - if (dev->cmb && (dev->cmbsz & NVME_CMBSZ_SQS)) {
> + if (dev->cmb && use_cmb_sqes && (dev->cmbsz & NVME_CMBSZ_SQS)) {
Is this a prep patch for something coming later? dev->cmb is already
NULL if use_cmb_sqes is false.
WARNING: multiple messages have this Message-ID (diff)
From: Keith Busch <keith.busch@intel.com>
To: sbates@raithlin.com
Cc: axboe@fb.com, hch@lst.de, sagi@grimberg.me,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nvme-pci: Fix incorrect use of CMB size to calculate q_depth
Date: Tue, 6 Feb 2018 08:05:52 -0700 [thread overview]
Message-ID: <20180206150552.GD31110@localhost.localdomain> (raw)
In-Reply-To: <1517869943-3655-1-git-send-email-sbates@raithlin.com>
On Mon, Feb 05, 2018 at 03:32:23PM -0700, sbates@raithlin.com wrote:
>
> - if (dev->cmb && (dev->cmbsz & NVME_CMBSZ_SQS)) {
> + if (dev->cmb && use_cmb_sqes && (dev->cmbsz & NVME_CMBSZ_SQS)) {
Is this a prep patch for something coming later? dev->cmb is already
NULL if use_cmb_sqes is false.
next prev parent reply other threads:[~2018-02-06 15:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-05 22:32 [PATCH] nvme-pci: Fix incorrect use of CMB size to calculate q_depth sbates
2018-02-05 22:32 ` sbates
2018-02-06 9:48 ` Sagi Grimberg
2018-02-06 9:48 ` Sagi Grimberg
2018-02-06 10:16 ` Max Gurtovoy
2018-02-06 10:16 ` Max Gurtovoy
2018-02-06 15:05 ` Keith Busch [this message]
2018-02-06 15:05 ` Keith Busch
2018-02-06 15:56 ` Stephen Bates
2018-02-06 15:56 ` Stephen Bates
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180206150552.GD31110@localhost.localdomain \
--to=keith.busch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.