qemu-xen fails to build in staging

qemu-xen fails to build in staging

[Olaf Hering]

[-- Attachment #1.1: Type: text/plain, Size: 1391 bytes --]

With current staging, qemu-xen fails to build. It looks like a ordering
issue, I assume ui/input-keymap-linux-to-qcode.c is a generated file.
It is (as always) a fresh clean checkout in a clean chroot.

[  505s] /home/abuild/rpmbuild/BUILD/xen-4.11.20180206T183258.30cbd0c83e/non-dbg/tools/qemu-xen-dir/ui/input-keymap.c:8:44: fatal error: ui/input-keymap-linux-to-qcode.c: No such file or directory
[  505s]  #include "ui/input-keymap-linux-to-qcode.c"
[  505s]                                             ^
[  505s] compilation terminated.
[  505s] /home/abuild/rpmbuild/BUILD/xen-4.11.20180206T183258.30cbd0c83e/non-dbg/tools/qemu-xen-dir/rules.mak:66: recipe for target 'ui/input-keymap.o' failed
[  505s] make: *** [ui/input-keymap.o] Error 1

The previous snapshot did not have this issue:
xen_commit b6c2c7f48ab8bd5566759cb404afd80fd0df2dfe Wed Jan 10 10:33:26 UTC 2018
seabios_tag 5f4c7b13cdf9c450eb55645f4362ea58fa61b79b Fri Feb 24 14:01:20 UTC 2017
minios_tag 0b4b7897e08b967a09bed2028a79fabff82342dd Fri Oct 20 10:50:35 UTC 2017
ipxe_tag 356f6c1b64d7a97746d1816cef8ca22bdd8d0b5d Tue May 23 17:48:06 UTC 2017
ovmf_tag 947f3737abf65fda63f3ffd97fddfa6986986868 Wed Sep 20 18:25:19 UTC 2017
qemu_xen_traditional_tag c8ea0457495342c417c3dc033bba25148b279f60 Fri Sep 15 18:37:27 UTC 2017
qemu_xen_upstream_tag b79708a8ed1b3d18bee67baeaf33b3fa529493e2 Thu Nov  9 15:46:00 UTC 2017

Olaf

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 157 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: qemu-xen fails to build in staging

[Jan Beulich]

>>> On 07.02.18 at 09:18, <olaf@aepfle.de> wrote:
> With current staging, qemu-xen fails to build. It looks like a ordering
> issue, I assume ui/input-keymap-linux-to-qcode.c is a generated file.
> It is (as always) a fresh clean checkout in a clean chroot.

I think I had seen this too, and only then I realized that now I need
to set up the respective submodule in the qemu tree.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: qemu-xen fails to build in staging

[Olaf Hering]

[-- Attachment #1.1: Type: text/plain, Size: 710 bytes --]

Am Wed, 07 Feb 2018 02:56:55 -0700
schrieb "Jan Beulich" <JBeulich@suse.com>:

> I think I had seen this too, and only then I realized that now I need
> to set up the respective submodule in the qemu tree.

Yes, it looks like qemu has now submodules which are required for build. Neither configure nor 'git archive' does not take that into account, as a result the "checkout" is incomplete. Great...

/xen-staging $ find -name .git
./.git
./tools/firmware/seabios-dir-remote/.git
./tools/qemu-xen-traditional-dir-remote/.git
./tools/qemu-xen-dir-remote/.git
./tools/qemu-xen-dir-remote/capstone/.git
./tools/qemu-xen-dir-remote/dtc/.git
./tools/qemu-xen-dir-remote/ui/keycodemapdb/.git

Olaf

[-- Attachment #1.2: Digitale Signatur von OpenPGP --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 157 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: qemu-xen fails to build in staging

[Olaf Hering]

[-- Attachment #1.1: Type: text/plain, Size: 542 bytes --]

Am Wed, 7 Feb 2018 11:13:22 +0100
schrieb Olaf Hering <olaf@aepfle.de>:

> Yes, it looks like qemu has now submodules which are required for build.

How is the required state of the submodules tracked? When I did a local build I got 10739aa from qemu.org, and building xen.git#staging succeeds. After that I updated my packaging, created a new tar from keycodemapdb.git#master and got a non-working build. It turned out that 044f21d was packaged.

Does the build of xen.git#staging now depend on random state at git.qemu.org?

Olaf

[-- Attachment #1.2: Digitale Signatur von OpenPGP --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 157 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: qemu-xen fails to build in staging

[Jan Beulich]

>>> On 07.02.18 at 13:40, <olaf@aepfle.de> wrote:
> Am Wed, 7 Feb 2018 11:13:22 +0100
> schrieb Olaf Hering <olaf@aepfle.de>:
> 
>> Yes, it looks like qemu has now submodules which are required for build.
> 
> How is the required state of the submodules tracked? When I did a local 
> build I got 10739aa from qemu.org, and building xen.git#staging succeeds. 
> After that I updated my packaging, created a new tar from 
> keycodemapdb.git#master and got a non-working build. It turned out that 
> 044f21d was packaged.
> 
> Does the build of xen.git#staging now depend on random state at 
> git.qemu.org?

No - the git tree containing the submodule tracks the intended
commit at which the submodule is to be used. You need to fish
out that hash instead of using plain master from the other repo.
"git submodule status" should tell you, I think.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: qemu-xen fails to build in staging

[Anthony PERARD]

On Wed, Feb 07, 2018 at 01:40:04PM +0100, Olaf Hering wrote:
> Am Wed, 7 Feb 2018 11:13:22 +0100
> schrieb Olaf Hering <olaf@aepfle.de>:
> 
> > Yes, it looks like qemu has now submodules which are required for build.
> 
> How is the required state of the submodules tracked?

Hi,

QEMU have now a script to take care of submodules when building qemu,
it's ./scripts/git-submodule.sh

The ./configure script will find out which submodules are needed. If the
script can find a libdtc, then the submodule dtc should not be build.
But I think the submodule ui/keycodemapdb is likely to be required.


> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xenproject.org
> https://lists.xenproject.org/mailman/listinfo/xen-devel


-- 
Anthony PERARD

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: qemu-xen fails to build in staging

[Anthony PERARD]

On Wed, Feb 07, 2018 at 02:44:05PM +0000, Anthony PERARD wrote:
> On Wed, Feb 07, 2018 at 01:40:04PM +0100, Olaf Hering wrote:
> > Am Wed, 7 Feb 2018 11:13:22 +0100
> > schrieb Olaf Hering <olaf@aepfle.de>:
> > 
> > > Yes, it looks like qemu has now submodules which are required for build.
> > 
> > How is the required state of the submodules tracked?
> 
> Hi,
> 
> QEMU have now a script to take care of submodules when building qemu,
> it's ./scripts/git-submodule.sh
> 
> The ./configure script will find out which submodules are needed. If the
> script can find a libdtc, then the submodule dtc should not be build.
> But I think the submodule ui/keycodemapdb is likely to be required.

Maybe the option '--disable-git-update' of the QEMU configure script
will be useful to you, there is some explanation in this commit message:
https://xenbits.xen.org/gitweb/?p=qemu-xen.git;a=commit;h=f62bbee55d503f639ee9498878ebf42ff4f4299a

-- 
Anthony PERARD

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel