From: shawnguo@kernel.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/2] soc: imx: gpcv2: Do not pass static memory as platform data
Date: Thu, 8 Feb 2018 14:47:10 +0800 [thread overview]
Message-ID: <20180208064709.GB31910@dragon> (raw)
In-Reply-To: <20180122150748.1742-1-andrew.smirnov@gmail.com>
On Mon, Jan 22, 2018 at 07:07:47AM -0800, Andrey Smirnov wrote:
> Platform device core assumes the ownership of dev.platform_data as
> well as that it is dynamically allocated and it will try to kfree it
> as a part of platform_device_release(). Change the code to pass
> kzalloc'ed chunk of memory instead of a pointer to a static memory to
> avoid causing a BUG() when calling platform_device_put().
>
> The problem can be reproduced by artificially enabling the error path
> of platform_device_add() call (around line 357).
>
> Note that this change also allows us to constify imx7_pgc_domains,
> since we no longer need to be able to modify it.
>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: Stefan Agner <stefan@agner.ch>
> Cc: Lucas Stach <l.stach@pengutronix.de>
> Cc: linux-arm-kernel at lists.infradead.org
> Cc: linux-kernel at vger.kernel.org
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
Applied both, thanks.
WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org>
To: Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: Stefan Agner <stefan@agner.ch>,
Lucas Stach <l.stach@pengutronix.de>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] soc: imx: gpcv2: Do not pass static memory as platform data
Date: Thu, 8 Feb 2018 14:47:10 +0800 [thread overview]
Message-ID: <20180208064709.GB31910@dragon> (raw)
In-Reply-To: <20180122150748.1742-1-andrew.smirnov@gmail.com>
On Mon, Jan 22, 2018 at 07:07:47AM -0800, Andrey Smirnov wrote:
> Platform device core assumes the ownership of dev.platform_data as
> well as that it is dynamically allocated and it will try to kfree it
> as a part of platform_device_release(). Change the code to pass
> kzalloc'ed chunk of memory instead of a pointer to a static memory to
> avoid causing a BUG() when calling platform_device_put().
>
> The problem can be reproduced by artificially enabling the error path
> of platform_device_add() call (around line 357).
>
> Note that this change also allows us to constify imx7_pgc_domains,
> since we no longer need to be able to modify it.
>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: Stefan Agner <stefan@agner.ch>
> Cc: Lucas Stach <l.stach@pengutronix.de>
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
Applied both, thanks.
next prev parent reply other threads:[~2018-02-08 6:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-22 15:07 [PATCH v2 1/2] soc: imx: gpcv2: Do not pass static memory as platform data Andrey Smirnov
2018-01-22 15:07 ` Andrey Smirnov
2018-01-22 15:07 ` [PATCH v2 2/2] soc: imx: gpc: " Andrey Smirnov
2018-01-22 15:07 ` Andrey Smirnov
2018-02-08 6:47 ` Shawn Guo [this message]
2018-02-08 6:47 ` [PATCH v2 1/2] soc: imx: gpcv2: " Shawn Guo
2018-03-15 3:08 ` Shawn Guo
2018-03-15 3:08 ` Shawn Guo
2018-03-15 13:00 ` Andrey Smirnov
2018-03-15 13:00 ` Andrey Smirnov
2018-03-15 13:52 ` Shawn Guo
2018-03-15 13:52 ` Shawn Guo
2018-03-15 14:12 ` Andrey Smirnov
2018-03-15 14:12 ` Andrey Smirnov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180208064709.GB31910@dragon \
--to=shawnguo@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.