All of lore.kernel.org
 help / color / mirror / Atom feed
From: jolsa@redhat.com (Jiri Olsa)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/9] perf utils: add support for pmu events vendor sub-directory
Date: Thu, 8 Feb 2018 14:55:54 +0100	[thread overview]
Message-ID: <20180208135554.GL10234@krava> (raw)
In-Reply-To: <1517939104-230881-3-git-send-email-john.garry@huawei.com>

On Wed, Feb 07, 2018 at 01:44:57AM +0800, John Garry wrote:
> For some architectures (like arm), it is required to support
> a vendor sub-directory and not locate all the JSONs for a
> specific vendor in the same folder.
> 
> This is because all the events for the same vendor will be
> placed in the same pmu events table, which may cause conflict.
> This conflict would be in the instance that a vendor's custom
> implemented events do have the same meaning on different platforms,
> so events in the pmu table would conflict. In addition, per list
> command may show events which are not even supported for a given
> platform.
> 
> This patch adds support for a arch/vendor/platform directory
> hierarchy, while maintaining backwards-compatibility for existing
> arch/platform structure. In this, each platform would always have
> its own pmu events table.
> 
> In generated file pmu_events.c, each platform table name is in
> the format pme{_vendor}_platform, like this:
> 
> struct pmu_events_map pmu_events_map[] = {
> {
> 	.cpuid = "0x00000000420f5160",
> 	.version = "v1",
> 	.type = "core",
> 	.table = pme_cavium_thunderx2
> },
> {
> 	.cpuid = 0,
> 	.version = 0,
> 	.type = 0,
> 	.table = 0,
> },
> };
> 
> Signed-off-by: John Garry <john.garry@huawei.com>

Acked-by: Jiri Olsa <jolsa@kernel.org>

thanks,
jirka

WARNING: multiple messages have this Message-ID (diff)
From: Jiri Olsa <jolsa@redhat.com>
To: John Garry <john.garry@huawei.com>
Cc: peterz@infradead.org, mingo@redhat.com, acme@kernel.org,
	alexander.shishkin@linux.intel.com, namhyung@kernel.org,
	ak@linux.intel.com, wcohen@redhat.com, will.deacon@arm.com,
	ganapatrao.kulkarni@cavium.com, linux-kernel@vger.kernel.org,
	linuxarm@huawei.com, zhangshaokun@hisilicon.com,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/9] perf utils: add support for pmu events vendor sub-directory
Date: Thu, 8 Feb 2018 14:55:54 +0100	[thread overview]
Message-ID: <20180208135554.GL10234@krava> (raw)
In-Reply-To: <1517939104-230881-3-git-send-email-john.garry@huawei.com>

On Wed, Feb 07, 2018 at 01:44:57AM +0800, John Garry wrote:
> For some architectures (like arm), it is required to support
> a vendor sub-directory and not locate all the JSONs for a
> specific vendor in the same folder.
> 
> This is because all the events for the same vendor will be
> placed in the same pmu events table, which may cause conflict.
> This conflict would be in the instance that a vendor's custom
> implemented events do have the same meaning on different platforms,
> so events in the pmu table would conflict. In addition, per list
> command may show events which are not even supported for a given
> platform.
> 
> This patch adds support for a arch/vendor/platform directory
> hierarchy, while maintaining backwards-compatibility for existing
> arch/platform structure. In this, each platform would always have
> its own pmu events table.
> 
> In generated file pmu_events.c, each platform table name is in
> the format pme{_vendor}_platform, like this:
> 
> struct pmu_events_map pmu_events_map[] = {
> {
> 	.cpuid = "0x00000000420f5160",
> 	.version = "v1",
> 	.type = "core",
> 	.table = pme_cavium_thunderx2
> },
> {
> 	.cpuid = 0,
> 	.version = 0,
> 	.type = 0,
> 	.table = 0,
> },
> };
> 
> Signed-off-by: John Garry <john.garry@huawei.com>

Acked-by: Jiri Olsa <jolsa@kernel.org>

thanks,
jirka

  reply	other threads:[~2018-02-08 13:55 UTC|newest]

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-06 17:44 [PATCH 0/9] perf events patches for improved ARM64 support John Garry
2018-02-06 17:44 ` John Garry
2018-02-06 17:44 ` [PATCH 1/9] perf vendor events: drop incomplete multiple mapfile support John Garry
2018-02-06 17:44   ` John Garry
2018-02-08 13:55   ` Jiri Olsa
2018-02-08 13:55     ` Jiri Olsa
2018-02-06 17:44 ` [PATCH 2/9] perf utils: add support for pmu events vendor sub-directory John Garry
2018-02-06 17:44   ` John Garry
2018-02-08 13:55   ` Jiri Olsa [this message]
2018-02-08 13:55     ` Jiri Olsa
2018-02-06 17:44 ` [PATCH 3/9] perf vendor events arm64: Relocate ThunderX2 JSON John Garry
2018-02-06 17:44   ` John Garry
2018-02-06 17:44 ` [PATCH 4/9] perf vendor events arm64: Relocate Cortex A53 JSONs John Garry
2018-02-06 17:44   ` John Garry
2018-02-06 17:45 ` [PATCH 5/9] perf utils: add support for arch standard events John Garry
2018-02-06 17:45   ` John Garry
2018-02-08 13:54   ` Jiri Olsa
2018-02-08 13:54     ` Jiri Olsa
2018-02-08 15:57     ` John Garry
2018-02-08 15:57       ` John Garry
2018-02-08 13:54   ` Jiri Olsa
2018-02-08 13:54     ` Jiri Olsa
2018-02-08 13:54   ` Jiri Olsa
2018-02-08 13:54     ` Jiri Olsa
2018-02-08 14:02     ` Alan Cox
2018-02-08 14:02       ` Alan Cox
2018-02-08 15:31       ` John Garry
2018-02-08 15:31         ` John Garry
2018-02-08 13:54   ` Jiri Olsa
2018-02-08 13:54     ` Jiri Olsa
2018-02-08 13:54   ` Jiri Olsa
2018-02-08 13:54     ` Jiri Olsa
2018-02-08 13:54   ` Jiri Olsa
2018-02-08 13:54     ` Jiri Olsa
2018-02-08 13:55   ` Jiri Olsa
2018-02-08 13:55     ` Jiri Olsa
2018-02-08 14:45     ` John Garry
2018-02-08 14:45       ` John Garry
2018-02-08 14:54       ` Jiri Olsa
2018-02-08 14:54         ` Jiri Olsa
2018-02-08 13:55   ` Jiri Olsa
2018-02-08 13:55     ` Jiri Olsa
2018-02-08 13:55   ` Jiri Olsa
2018-02-08 13:55     ` Jiri Olsa
2018-02-08 15:25     ` John Garry
2018-02-08 15:25       ` John Garry
2018-02-09  8:53       ` Jiri Olsa
2018-02-09  8:53         ` Jiri Olsa
2018-02-08 13:55   ` Jiri Olsa
2018-02-08 13:55     ` Jiri Olsa
2018-02-08 14:59     ` John Garry
2018-02-08 14:59       ` John Garry
2018-02-06 17:45 ` [PATCH 6/9] perf utils: add armv8-recommended.json John Garry
2018-02-06 17:45   ` John Garry
2018-02-06 17:45 ` [PATCH 7/9] perf utils: fixup Cavium ThunderX2 JSON to use ARMv8 recommended events John Garry
2018-02-06 17:45   ` John Garry
2018-02-06 17:45 ` [PATCH 8/9] perf utils: fixup ARM Cortex A53 JSONs " John Garry
2018-02-06 17:45   ` John Garry
2018-02-06 17:45 ` [PATCH 9/9] perf utils: add HiSilicon hip08 JSON file John Garry
2018-02-06 17:45   ` John Garry

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180208135554.GL10234@krava \
    --to=jolsa@redhat.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.