All of lore.kernel.org
 help / color / mirror / Atom feed
From: "tj@kernel.org" <tj@kernel.org>
To: Bart Van Assche <Bart.VanAssche@wdc.com>
Cc: "hch@lst.de" <hch@lst.de>,
	"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
	"axboe@kernel.dk" <axboe@kernel.dk>
Subject: Re: [PATCH v2] blk-mq: Fix race between resetting the timer and completion handling
Date: Thu, 8 Feb 2018 09:40:17 -0800	[thread overview]
Message-ID: <20180208174017.GR695913@devbig577.frc2.facebook.com> (raw)
In-Reply-To: <1518111465.3611.36.camel@wdc.com>

On Thu, Feb 08, 2018 at 05:37:46PM +0000, Bart Van Assche wrote:
> On Thu, 2018-02-08 at 09:19 -0800, tj@kernel.org wrote:
> > Hello, Bart.
> > 
> > On Thu, Feb 08, 2018 at 05:10:45PM +0000, Bart Van Assche wrote:
> > > I think "dereferencing a pointer" means reading the memory location that pointer points
> > > at? Anyway, I think we both interpret the crash report in the same way, namely that it
> > > means that scmd->device == NULL.
> > 
> > No, what I'm trying to say is that it's is the device->host reference
> > not the scmd->device reference.
> 
> Again, I think that means that we agree about the interpretation of the crash
> report. The big question here is what the next step should be to analyze this
> further and/or to avoid that this crash can occur?

Heh, sorry about not being clear.  What I'm trying to say is that
scmd->device != NULL && device->host == NULL.  Or was this what you
were saying all along?

Thanks.

-- 
tejun

  reply	other threads:[~2018-02-08 17:40 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-07  1:11 [PATCH v2] blk-mq: Fix race between resetting the timer and completion handling Bart Van Assche
2018-02-07 17:06 ` Tejun Heo
2018-02-07 17:27   ` Bart Van Assche
2018-02-07 17:35     ` tj
2018-02-07 18:14       ` Bart Van Assche
2018-02-07 20:07         ` tj
2018-02-07 23:48           ` Bart Van Assche
2018-02-08  1:09             ` Bart Van Assche
2018-02-08 15:39               ` tj
2018-02-08 15:40                 ` tj
2018-02-08 16:31                 ` Bart Van Assche
2018-02-08 17:00                   ` tj
2018-02-08 17:10                     ` Bart Van Assche
2018-02-08 17:19                       ` tj
2018-02-08 17:37                         ` Bart Van Assche
2018-02-08 17:40                           ` tj [this message]
2018-02-08 17:48                             ` Bart Van Assche
2018-02-08 17:54                               ` tj
2018-02-13 21:20                   ` tj
2018-02-14 16:58                     ` Bart Van Assche
2018-02-18 13:11                       ` tj
2018-02-21 18:53                         ` Bart Van Assche
2018-02-21 19:21                           ` tj
2018-02-21 22:55                             ` Bart Van Assche
2018-02-07 19:03   ` Bart Van Assche
2018-02-07 20:09     ` tj
2018-02-07 21:02       ` Bart Van Assche
2018-02-07 21:40         ` tj

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180208174017.GR695913@devbig577.frc2.facebook.com \
    --to=tj@kernel.org \
    --cc=Bart.VanAssche@wdc.com \
    --cc=axboe@kernel.dk \
    --cc=hch@lst.de \
    --cc=linux-block@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.