From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Mike Rapoport <rppt@linux.vnet.ibm.com>
Cc: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
Minchan Kim <minchan@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Subject: Re: [PATCH 1/2] zsmalloc: introduce zs_huge_object() function
Date: Fri, 9 Feb 2018 11:55:20 +0900 [thread overview]
Message-ID: <20180209025520.GA3423@jagdpanzerIV> (raw)
In-Reply-To: <20180208163006.GB17354@rapoport-lnx>
On (02/08/18 18:30), Mike Rapoport wrote:
[..]
> >
> > +/*
> > + * Check if the object's size falls into huge_class area. We must take
> > + * ZS_HANDLE_SIZE into account and test the actual size we are going to
> > + * use up. zs_malloc() unconditionally adds handle size before it performs
> > + * size_class lookup, so we may endup in a huge class yet zs_huge_object()
> > + * returned 'false'.
> > + */
>
> Can you please reformat this comment as kernel-doc?
Is this - Documentation/doc-guide/kernel-doc.rst - the right thing
to use as a reference?
-ss
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Mike Rapoport <rppt@linux.vnet.ibm.com>
Cc: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
Minchan Kim <minchan@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Subject: Re: [PATCH 1/2] zsmalloc: introduce zs_huge_object() function
Date: Fri, 9 Feb 2018 11:55:20 +0900 [thread overview]
Message-ID: <20180209025520.GA3423@jagdpanzerIV> (raw)
In-Reply-To: <20180208163006.GB17354@rapoport-lnx>
On (02/08/18 18:30), Mike Rapoport wrote:
[..]
> >
> > +/*
> > + * Check if the object's size falls into huge_class area. We must take
> > + * ZS_HANDLE_SIZE into account and test the actual size we are going to
> > + * use up. zs_malloc() unconditionally adds handle size before it performs
> > + * size_class lookup, so we may endup in a huge class yet zs_huge_object()
> > + * returned 'false'.
> > + */
>
> Can you please reformat this comment as kernel-doc?
Is this - Documentation/doc-guide/kernel-doc.rst - the right thing
to use as a reference?
-ss
next prev parent reply other threads:[~2018-02-09 2:55 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-07 9:29 [PATCH 0/2] zsmalloc/zram: drop zram's max_zpage_size Sergey Senozhatsky
2018-02-07 9:29 ` Sergey Senozhatsky
2018-02-07 9:29 ` [PATCH 1/2] zsmalloc: introduce zs_huge_object() function Sergey Senozhatsky
2018-02-07 9:29 ` Sergey Senozhatsky
2018-02-08 16:30 ` Mike Rapoport
2018-02-08 16:30 ` Mike Rapoport
2018-02-09 2:55 ` Sergey Senozhatsky [this message]
2018-02-09 2:55 ` Sergey Senozhatsky
2018-02-09 4:10 ` Matthew Wilcox
2018-02-09 4:10 ` Matthew Wilcox
2018-02-09 5:04 ` Sergey Senozhatsky
2018-02-09 5:04 ` Sergey Senozhatsky
2018-02-09 5:36 ` Sergey Senozhatsky
2018-02-09 5:36 ` Sergey Senozhatsky
2018-02-09 5:48 ` Sergey Senozhatsky
2018-02-09 5:48 ` Sergey Senozhatsky
2018-02-09 11:11 ` Mike Rapoport
2018-02-09 11:11 ` Mike Rapoport
2018-02-09 12:34 ` Sergey Senozhatsky
2018-02-09 12:34 ` Sergey Senozhatsky
2018-02-10 8:23 ` [PATCHv2 " Sergey Senozhatsky
2018-02-10 8:23 ` Sergey Senozhatsky
2018-02-11 7:05 ` Mike Rapoport
2018-02-11 7:05 ` Mike Rapoport
2018-02-14 5:52 ` Sergey Senozhatsky
2018-02-14 5:52 ` Sergey Senozhatsky
2018-02-14 5:57 ` [PATCHv3 " Sergey Senozhatsky
2018-02-14 5:57 ` Sergey Senozhatsky
2018-02-20 1:24 ` Minchan Kim
2018-02-20 1:24 ` Minchan Kim
2018-02-26 5:49 ` Sergey Senozhatsky
2018-02-26 5:49 ` Sergey Senozhatsky
2018-02-26 5:58 ` Minchan Kim
2018-02-26 5:58 ` Minchan Kim
2018-02-26 6:50 ` Sergey Senozhatsky
2018-02-26 6:50 ` Sergey Senozhatsky
2018-02-26 7:46 ` Minchan Kim
2018-02-26 7:46 ` Minchan Kim
2018-02-26 8:12 ` Sergey Senozhatsky
2018-02-26 8:12 ` Sergey Senozhatsky
2018-02-07 9:29 ` [PATCH 2/2] zram: drop max_zpage_size and use zs_huge_object() Sergey Senozhatsky
2018-02-07 9:29 ` Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180209025520.GA3423@jagdpanzerIV \
--to=sergey.senozhatsky.work@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=rppt@linux.vnet.ibm.com \
--cc=sergey.senozhatsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.