From: Mark Brown <broonie@kernel.org>
To: Cosmin Samoila <cosmin.samoila@nxp.com>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"S.j. Wang" <shengjiu.wang@nxp.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"wakasugi.jb@om.asahi-kasei.co.jp"
<wakasugi.jb@om.asahi-kasei.co.jp>,
dl-linux-imx <linux-imx@nxp.com>,
"mihai.serban@nxp.com" <mihai.serban@nxp.com>,
Daniel Baluta <daniel.baluta@nxp.com>,
"mihai.serban@gmail.com" <mihai.serban@gmail.com>
Subject: Re: [PATCH] ASoC: codecs: Add support for AK4458 DAC driver
Date: Fri, 9 Feb 2018 15:47:46 +0000 [thread overview]
Message-ID: <20180209154746.GA10104@sirena.org.uk> (raw)
In-Reply-To: <1518171736.19973.7.camel@nxp.com>
[-- Attachment #1.1: Type: text/plain, Size: 868 bytes --]
On Fri, Feb 09, 2018 at 10:22:16AM +0000, Cosmin Samoila wrote:
> > > +static const char * const ak4458_dac_select_texts[] = { "OFF",
> > > "ON" };
> > This looks like the users should be switch controls - what's the goal
> > here?
> I think this is to allow users to switch off sound for all channels but
> it seems silly to have 4 controls doing the same thing.
> We now have two options:
> - one control to switch off sound for all channels
> - one controll per DAC
If they're mutes they shouldn't be in DAPM at all, just make them
standard controls - they should stack up with the matching volume
controls.
> What do you mean by "users should be switch controls" ?
> Should we use SND_SOC_DAPM_SWITCH instead of SND_SOC_DAPM_MUX?
They quite clearly aren't muxes so if they need to be in DAPM probably
switches but it's not clear that they need to be in DAPM.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Cosmin Samoila <cosmin.samoila@nxp.com>
Cc: dl-linux-imx <linux-imx@nxp.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"wakasugi.jb@om.asahi-kasei.co.jp"
<wakasugi.jb@om.asahi-kasei.co.jp>,
"mihai.serban@gmail.com" <mihai.serban@gmail.com>,
"S.j. Wang" <shengjiu.wang@nxp.com>,
Daniel Baluta <daniel.baluta@nxp.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"mihai.serban@nxp.com" <mihai.serban@nxp.com>
Subject: Re: [PATCH] ASoC: codecs: Add support for AK4458 DAC driver
Date: Fri, 9 Feb 2018 15:47:46 +0000 [thread overview]
Message-ID: <20180209154746.GA10104@sirena.org.uk> (raw)
In-Reply-To: <1518171736.19973.7.camel@nxp.com>
[-- Attachment #1: Type: text/plain, Size: 868 bytes --]
On Fri, Feb 09, 2018 at 10:22:16AM +0000, Cosmin Samoila wrote:
> > > +static const char * const ak4458_dac_select_texts[] = { "OFF",
> > > "ON" };
> > This looks like the users should be switch controls - what's the goal
> > here?
> I think this is to allow users to switch off sound for all channels but
> it seems silly to have 4 controls doing the same thing.
> We now have two options:
> - one control to switch off sound for all channels
> - one controll per DAC
If they're mutes they shouldn't be in DAPM at all, just make them
standard controls - they should stack up with the matching volume
controls.
> What do you mean by "users should be switch controls" ?
> Should we use SND_SOC_DAPM_SWITCH instead of SND_SOC_DAPM_MUX?
They quite clearly aren't muxes so if they need to be in DAPM probably
switches but it's not clear that they need to be in DAPM.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2018-02-09 15:47 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-31 13:20 [PATCH] ASoC: codecs: Add support for AK4458 DAC driver Cosmin-Gabriel Samoila
2018-01-31 13:20 ` Cosmin-Gabriel Samoila
2018-01-31 17:03 ` Mark Brown
2018-01-31 17:03 ` Mark Brown
[not found] ` <20180131170330.GB7763-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2018-02-09 10:22 ` Cosmin Samoila
2018-02-09 10:22 ` Cosmin Samoila
2018-02-09 15:47 ` Mark Brown [this message]
2018-02-09 15:47 ` Mark Brown
2018-02-13 9:22 ` Cosmin Samoila
2018-02-13 9:22 ` Cosmin Samoila
2018-02-13 11:55 ` Mark Brown
2018-02-05 6:08 ` Rob Herring
2018-02-05 6:08 ` Rob Herring
[not found] ` <1517404809-25250-1-git-send-email-cosmin.samoila-3arQi8VN3Tc@public.gmane.org>
2018-02-12 12:47 ` Fabio Estevam
2018-02-12 12:47 ` Fabio Estevam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180209154746.GA10104@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=cosmin.samoila@nxp.com \
--cc=daniel.baluta@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mihai.serban@gmail.com \
--cc=mihai.serban@nxp.com \
--cc=shengjiu.wang@nxp.com \
--cc=wakasugi.jb@om.asahi-kasei.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.