From: Tony Lindgren <tony@atomide.com>
To: Grygorii Strashko <grygorii.strashko@ti.com>
Cc: Tero Kristo <t-kristo@ti.com>,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Dave Gerlach <d-gerlach@ti.com>
Subject: Re: [PATCH] ARM: OMAP2+: Handle errors from cpu_pm_enter()
Date: Fri, 9 Feb 2018 12:54:22 -0800 [thread overview]
Message-ID: <20180209205422.GC4383@atomide.com> (raw)
In-Reply-To: <b00819ef-2daf-6209-c6e4-4c27d1074b94@ti.com>
* Grygorii Strashko <grygorii.strashko@ti.com> [180209 20:09]:
> On 02/09/2018 11:47 AM, Tony Lindgren wrote:
> > @@ -196,18 +199,18 @@ static int omap_enter_idle_coupled(struct cpuidle_device *dev,
> > }
> > }
> > - /*
> > - * Call idle CPU PM exit notifier chain to restore
> > - * VFP and per CPU IRQ context.
> > - */
> > - cpu_pm_exit();
> > -
> > /*
> > * Call idle CPU cluster PM exit notifier chain
> > * to restore GIC and wakeupgen context.
> > */
> > if (dev->cpu == 0 && mpuss_can_lose_context)
> > cpu_cluster_pm_exit();
> > +cpu_pm_out:
> > + /*
> > + * Call idle CPU PM exit notifier chain to restore
> > + * VFP and per CPU IRQ context.
> > + */
> > + cpu_pm_exit();
>
> It looks ok, in general, but you've changed order of calls here,
> so may be commit message need to be updated
Hmm yeah good point, that's how it's usually done. I'll check
and update the description like you suggested.
Regards,
Tony
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: OMAP2+: Handle errors from cpu_pm_enter()
Date: Fri, 9 Feb 2018 12:54:22 -0800 [thread overview]
Message-ID: <20180209205422.GC4383@atomide.com> (raw)
In-Reply-To: <b00819ef-2daf-6209-c6e4-4c27d1074b94@ti.com>
* Grygorii Strashko <grygorii.strashko@ti.com> [180209 20:09]:
> On 02/09/2018 11:47 AM, Tony Lindgren wrote:
> > @@ -196,18 +199,18 @@ static int omap_enter_idle_coupled(struct cpuidle_device *dev,
> > }
> > }
> > - /*
> > - * Call idle CPU PM exit notifier chain to restore
> > - * VFP and per CPU IRQ context.
> > - */
> > - cpu_pm_exit();
> > -
> > /*
> > * Call idle CPU cluster PM exit notifier chain
> > * to restore GIC and wakeupgen context.
> > */
> > if (dev->cpu == 0 && mpuss_can_lose_context)
> > cpu_cluster_pm_exit();
> > +cpu_pm_out:
> > + /*
> > + * Call idle CPU PM exit notifier chain to restore
> > + * VFP and per CPU IRQ context.
> > + */
> > + cpu_pm_exit();
>
> It looks ok, in general, but you've changed order of calls here,
> so may be commit message need to be updated
Hmm yeah good point, that's how it's usually done. I'll check
and update the description like you suggested.
Regards,
Tony
next prev parent reply other threads:[~2018-02-09 20:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-09 17:47 [PATCH] ARM: OMAP2+: Handle errors from cpu_pm_enter() Tony Lindgren
2018-02-09 17:47 ` Tony Lindgren
2018-02-09 20:08 ` Grygorii Strashko
2018-02-09 20:08 ` Grygorii Strashko
2018-02-09 20:54 ` Tony Lindgren [this message]
2018-02-09 20:54 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180209205422.GC4383@atomide.com \
--to=tony@atomide.com \
--cc=d-gerlach@ti.com \
--cc=grygorii.strashko@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=t-kristo@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.