[virtio] [PATCH 0/2] two versioning related changes

[virtio] [PATCH 0/2] two versioning related changes

[Halil Pasic]

Regarding patch #1 please see also:
https://lists.oasis-open.org/archives/virtio/201802/msg00018.html

Halil Pasic (2):
  ccw: be more precise the semantic of revision 1
  introduction: simplify the designation of legacy

 content.tex      |    2 +-
 introduction.tex |    4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)


---------------------------------------------------------------------
To unsubscribe from this mail list, you must leave the OASIS TC that 
generates this mail.  Follow this link to all your TCs in OASIS at:
https://www.oasis-open.org/apps/org/workgroup/portal/my_workgroups.php 

[virtio] [PATCH 1/2] ccw: be more precise the semantic of revision 1

[Halil Pasic]

Revision 1 of the CCW transport is currently defined as virtio 1.0. This
could become confusing when we bump the version of the virtio
specification to 1.1, in a sense that it could be interpreted like one
can not use any features not part of the 1.0 specification.

So let us try to avoid confusion regarding the semantic of virtio-ccw
revision 1.

Signed-off-by: Halil Pasic <pasic@linux.vnet.ibm.com>
---
 content.tex |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/content.tex b/content.tex
index c7ef7fd..86044dd 100644
--- a/content.tex
+++ b/content.tex
@@ -2572,7 +2572,7 @@ The following values are supported:
 \hline \hline
 0        & 0      & <empty>   & legacy interface; transitional devices only \\
 \hline
-1        & 0      & <empty>   & Virtio 1.0 \\
+1        & 0      & <empty>   & Virtio 1 \\
 \hline
 2        & 0      & <empty>   & CCW_CMD_READ_STATUS support \\
 \hline
-- 
1.7.1


---------------------------------------------------------------------
To unsubscribe from this mail list, you must leave the OASIS TC that 
generates this mail.  Follow this link to all your TCs in OASIS at:
https://www.oasis-open.org/apps/org/workgroup/portal/my_workgroups.php 

[virtio] [PATCH 2/2] introduction: simplify the designation of legacy

[Halil Pasic]

The sentence designating the documents defining what later
became known as the legacy virtio interface had the most
important piece of information placed in parenthesis.

Let's reword this sentence so we avoid using an ambiguous designation
based on a relative anchor (i.e. 'earlier drafts of this specification')
and just use the absolute anchor (version 1.0).

Signed-off-by: Halil Pasic <pasic@linux.vnet.ibm.com>
---
 introduction.tex |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/introduction.tex b/introduction.tex
index 979881e..78c340d 100644
--- a/introduction.tex
+++ b/introduction.tex
@@ -78,8 +78,8 @@ The key words ``MUST'', ``MUST NOT'', ``REQUIRED'', ``SHALL'', ``SHALL NOT'', ``
 \subsection{Legacy Interface: Terminology}\label{intro:Legacy
 Interface: Terminology}
 
-Earlier drafts of this specification (i.e. revisions before 1.0,
-see e.g. \hyperref[intro:Virtio PCI Draft]{[Virtio PCI Draft]})
+Specification drafts preceding version 1.0 of this specification
+(e.g. see \hyperref[intro:Virtio PCI Draft]{[Virtio PCI Draft]})
 defined a similar, but different
 interface between the driver and the device.
 Since these are widely deployed, this specification
-- 
1.7.1


---------------------------------------------------------------------
To unsubscribe from this mail list, you must leave the OASIS TC that 
generates this mail.  Follow this link to all your TCs in OASIS at:
https://www.oasis-open.org/apps/org/workgroup/portal/my_workgroups.php 

[virtio] Re: [PATCH 0/2] two versioning related changes

[Michael S. Tsirkin]

On Fri, Feb 09, 2018 at 08:59:12PM +0100, Halil Pasic wrote:
> Regarding patch #1 please see also:
> https://lists.oasis-open.org/archives/virtio/201802/msg00018.html

Fine by me. Can you please open an issue to track it?
This makes it easier for me to start voting.

If you would rather use github issues,
that'd be great. There seem to be easy tools
to work with their API, e.g.
http://search.cpan.org/~fayland/Net-GitHub-0.93/lib/Net/GitHub/V3/Issues.pm

We need to come up with a schema to keep the following info in github:
- what is the issue title/short description
- which version fixes the issue?
- what is the proposed spec change?

and then send a script that can get an issue # and
print that, similar to virtio-jira.pl in virtio-admin.

Help with that is very welcome but if you'd rather not you
can just use jira for now.
Pls remember to set fixed in to 1.1 and environment to
reporter name and email (yourself).


> Halil Pasic (2):
>   ccw: be more precise the semantic of revision 1
>   introduction: simplify the designation of legacy
> 
>  content.tex      |    2 +-
>  introduction.tex |    4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)

---------------------------------------------------------------------
To unsubscribe from this mail list, you must leave the OASIS TC that 
generates this mail.  Follow this link to all your TCs in OASIS at:
https://www.oasis-open.org/apps/org/workgroup/portal/my_workgroups.php 

[virtio] Re: [PATCH 1/2] ccw: be more precise the semantic of revision 1

[Cornelia Huck]

On Fri,  9 Feb 2018 20:59:13 +0100
Halil Pasic <pasic@linux.vnet.ibm.com> wrote:

s/precise/precise about/

> Revision 1 of the CCW transport is currently defined as virtio 1.0. This
> could become confusing when we bump the version of the virtio
> specification to 1.1, in a sense that it could be interpreted like one
> can not use any features not part of the 1.0 specification.
> 
> So let us try to avoid confusion regarding the semantic of virtio-ccw
> revision 1.
> 
> Signed-off-by: Halil Pasic <pasic@linux.vnet.ibm.com>
> ---
>  content.tex |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/content.tex b/content.tex
> index c7ef7fd..86044dd 100644
> --- a/content.tex
> +++ b/content.tex
> @@ -2572,7 +2572,7 @@ The following values are supported:
>  \hline \hline
>  0        & 0      & <empty>   & legacy interface; transitional devices only \\
>  \hline
> -1        & 0      & <empty>   & Virtio 1.0 \\
> +1        & 0      & <empty>   & Virtio 1 \\
>  \hline
>  2        & 0      & <empty>   & CCW_CMD_READ_STATUS support \\
>  \hline

Reviewed-by: Cornelia Huck <cohuck@redhat.com>

---------------------------------------------------------------------
To unsubscribe from this mail list, you must leave the OASIS TC that 
generates this mail.  Follow this link to all your TCs in OASIS at:
https://www.oasis-open.org/apps/org/workgroup/portal/my_workgroups.php 

[virtio] Re: [PATCH 2/2] introduction: simplify the designation of legacy

[Cornelia Huck]

On Fri,  9 Feb 2018 20:59:14 +0100
Halil Pasic <pasic@linux.vnet.ibm.com> wrote:

> The sentence designating the documents defining what later
> became known as the legacy virtio interface had the most
> important piece of information placed in parenthesis.
> 
> Let's reword this sentence so we avoid using an ambiguous designation
> based on a relative anchor (i.e. 'earlier drafts of this specification')
> and just use the absolute anchor (version 1.0).
> 
> Signed-off-by: Halil Pasic <pasic@linux.vnet.ibm.com>
> ---
>  introduction.tex |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/introduction.tex b/introduction.tex
> index 979881e..78c340d 100644
> --- a/introduction.tex
> +++ b/introduction.tex
> @@ -78,8 +78,8 @@ The key words ``MUST'', ``MUST NOT'', ``REQUIRED'', ``SHALL'', ``SHALL NOT'', ``
>  \subsection{Legacy Interface: Terminology}\label{intro:Legacy
>  Interface: Terminology}
>  
> -Earlier drafts of this specification (i.e. revisions before 1.0,
> -see e.g. \hyperref[intro:Virtio PCI Draft]{[Virtio PCI Draft]})
> +Specification drafts preceding version 1.0 of this specification
> +(e.g. see \hyperref[intro:Virtio PCI Draft]{[Virtio PCI Draft]})
>  defined a similar, but different
>  interface between the driver and the device.
>  Since these are widely deployed, this specification

Reviewed-by: Cornelia Huck <cohuck@redhat.com>

---------------------------------------------------------------------
To unsubscribe from this mail list, you must leave the OASIS TC that 
generates this mail.  Follow this link to all your TCs in OASIS at:
https://www.oasis-open.org/apps/org/workgroup/portal/my_workgroups.php 

[virtio] Re: [PATCH 0/2] two versioning related changes

[Cornelia Huck]

On Fri, 9 Feb 2018 22:43:23 +0200
"Michael S. Tsirkin" <mst@redhat.com> wrote:

> On Fri, Feb 09, 2018 at 08:59:12PM +0100, Halil Pasic wrote:
> > Regarding patch #1 please see also:
> > https://lists.oasis-open.org/archives/virtio/201802/msg00018.html  
> 
> Fine by me. Can you please open an issue to track it?
> This makes it easier for me to start voting.
> 
> If you would rather use github issues,
> that'd be great. There seem to be easy tools
> to work with their API, e.g.
> http://search.cpan.org/~fayland/Net-GitHub-0.93/lib/Net/GitHub/V3/Issues.pm
> 
> We need to come up with a schema to keep the following info in github:
> - what is the issue title/short description
> - which version fixes the issue?
> - what is the proposed spec change?
> 
> and then send a script that can get an issue # and
> print that, similar to virtio-jira.pl in virtio-admin.

I'd vote (heh) to just use jira for now. Especially as I'd like to get
the big batch of the packed ring updates out of the way before we start
to tweak our tooling...

> 
> Help with that is very welcome but if you'd rather not you
> can just use jira for now.
> Pls remember to set fixed in to 1.1 and environment to
> reporter name and email (yourself).
> 
> 
> > Halil Pasic (2):
> >   ccw: be more precise the semantic of revision 1
> >   introduction: simplify the designation of legacy
> > 
> >  content.tex      |    2 +-
> >  introduction.tex |    4 ++--
> >  2 files changed, 3 insertions(+), 3 deletions(-)  


---------------------------------------------------------------------
To unsubscribe from this mail list, you must leave the OASIS TC that 
generates this mail.  Follow this link to all your TCs in OASIS at:
https://www.oasis-open.org/apps/org/workgroup/portal/my_workgroups.php 

[virtio] Re: [virtio-dev] Re: [PATCH 1/2] ccw: be more precise the semantic of revision 1

[Halil Pasic]

On 02/12/2018 01:59 PM, Cornelia Huck wrote:
> On Fri,  9 Feb 2018 20:59:13 +0100
> Halil Pasic <pasic@linux.vnet.ibm.com> wrote:
> 
> s/precise/precise about/

Nod. Should I spin a v2 or is it better handled
via fixup by maintainer?

> 
>> Revision 1 of the CCW transport is currently defined as virtio 1.0. This
>> could become confusing when we bump the version of the virtio
>> specification to 1.1, in a sense that it could be interpreted like one
>> can not use any features not part of the 1.0 specification.
>>
>> So let us try to avoid confusion regarding the semantic of virtio-ccw
>> revision 1.
>>
>> Signed-off-by: Halil Pasic <pasic@linux.vnet.ibm.com>
>> ---
>>  content.tex |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/content.tex b/content.tex
>> index c7ef7fd..86044dd 100644
>> --- a/content.tex
>> +++ b/content.tex
>> @@ -2572,7 +2572,7 @@ The following values are supported:
>>  \hline \hline
>>  0        & 0      & <empty>   & legacy interface; transitional devices only \\
>>  \hline
>> -1        & 0      & <empty>   & Virtio 1.0 \\
>> +1        & 0      & <empty>   & Virtio 1 \\
>>  \hline
>>  2        & 0      & <empty>   & CCW_CMD_READ_STATUS support \\
>>  \hline
> 
> Reviewed-by: Cornelia Huck <cohuck@redhat.com>

Thanks!

> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
> For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
> 


---------------------------------------------------------------------
To unsubscribe from this mail list, you must leave the OASIS TC that 
generates this mail.  Follow this link to all your TCs in OASIS at:
https://www.oasis-open.org/apps/org/workgroup/portal/my_workgroups.php 

[virtio] Re: [PATCH 0/2] two versioning related changes

[Halil Pasic]

On 02/12/2018 02:03 PM, Cornelia Huck wrote:
> On Fri, 9 Feb 2018 22:43:23 +0200
> "Michael S. Tsirkin" <mst@redhat.com> wrote:
> 
>> On Fri, Feb 09, 2018 at 08:59:12PM +0100, Halil Pasic wrote:
>>> Regarding patch #1 please see also:
>>> https://lists.oasis-open.org/archives/virtio/201802/msg00018.html  
>>
>> Fine by me. Can you please open an issue to track it?
>> This makes it easier for me to start voting.
>>
>> If you would rather use github issues,
>> that'd be great. There seem to be easy tools
>> to work with their API, e.g.
>> http://search.cpan.org/~fayland/Net-GitHub-0.93/lib/Net/GitHub/V3/Issues.pm
>>
>> We need to come up with a schema to keep the following info in github:
>> - what is the issue title/short description
>> - which version fixes the issue?
>> - what is the proposed spec change?
>>
>> and then send a script that can get an issue # and
>> print that, similar to virtio-jira.pl in virtio-admin.
> 
> I'd vote (heh) to just use jira for now. Especially as I'd like to get
> the big batch of the packed ring updates out of the way before we start
> to tweak our tooling...
> 
>>
>> Help with that is very welcome but if you'd rather not you
>> can just use jira for now.


I had a look at the script mentioned above and the GitHub API. I'm not
too eager to do this GitHub issues support at the moment, so I'm going
to stick with Jira.

Regards,
Halil

>> Pls remember to set fixed in to 1.1 and environment to
>> reporter name and email (yourself).
>>
>>
>>> Halil Pasic (2):
>>>   ccw: be more precise the semantic of revision 1
>>>   introduction: simplify the designation of legacy
>>>
>>>  content.tex      |    2 +-
>>>  introduction.tex |    4 ++--
>>>  2 files changed, 3 insertions(+), 3 deletions(-)  
> 


---------------------------------------------------------------------
To unsubscribe from this mail list, you must leave the OASIS TC that 
generates this mail.  Follow this link to all your TCs in OASIS at:
https://www.oasis-open.org/apps/org/workgroup/portal/my_workgroups.php 

[virtio] Re: [virtio-dev] Re: [PATCH 1/2] ccw: be more precise the semantic of revision 1

[Michael S. Tsirkin]

On Mon, Feb 12, 2018 at 03:25:12PM +0100, Halil Pasic wrote:
> 
> 
> On 02/12/2018 01:59 PM, Cornelia Huck wrote:
> > On Fri,  9 Feb 2018 20:59:13 +0100
> > Halil Pasic <pasic@linux.vnet.ibm.com> wrote:
> > 
> > s/precise/precise about/
> 
> Nod. Should I spin a v2 or is it better handled
> via fixup by maintainer?

I prefer a respin. How about that jira issue(s)?
You could then also include the # in the patch commit log then.
Just say

VIRTIO-XXXX

in the commit log

> > 
> >> Revision 1 of the CCW transport is currently defined as virtio 1.0. This
> >> could become confusing when we bump the version of the virtio
> >> specification to 1.1, in a sense that it could be interpreted like one
> >> can not use any features not part of the 1.0 specification.
> >>
> >> So let us try to avoid confusion regarding the semantic of virtio-ccw
> >> revision 1.
> >>
> >> Signed-off-by: Halil Pasic <pasic@linux.vnet.ibm.com>
> >> ---
> >>  content.tex |    2 +-
> >>  1 files changed, 1 insertions(+), 1 deletions(-)
> >>
> >> diff --git a/content.tex b/content.tex
> >> index c7ef7fd..86044dd 100644
> >> --- a/content.tex
> >> +++ b/content.tex
> >> @@ -2572,7 +2572,7 @@ The following values are supported:
> >>  \hline \hline
> >>  0        & 0      & <empty>   & legacy interface; transitional devices only \\
> >>  \hline
> >> -1        & 0      & <empty>   & Virtio 1.0 \\
> >> +1        & 0      & <empty>   & Virtio 1 \\
> >>  \hline
> >>  2        & 0      & <empty>   & CCW_CMD_READ_STATUS support \\
> >>  \hline
> > 
> > Reviewed-by: Cornelia Huck <cohuck@redhat.com>
> 
> Thanks!
> 
> > 
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
> > For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
> > 

---------------------------------------------------------------------
To unsubscribe from this mail list, you must leave the OASIS TC that 
generates this mail.  Follow this link to all your TCs in OASIS at:
https://www.oasis-open.org/apps/org/workgroup/portal/my_workgroups.php 

Re: [virtio-dev] Re: [PATCH 1/2] ccw: be more precise the semantic of revision 1

[Halil Pasic]

On 02/12/2018 10:09 PM, Michael S. Tsirkin wrote:
> On Mon, Feb 12, 2018 at 03:25:12PM +0100, Halil Pasic wrote:
>>
>>
>> On 02/12/2018 01:59 PM, Cornelia Huck wrote:
>>> On Fri,  9 Feb 2018 20:59:13 +0100
>>> Halil Pasic <pasic@linux.vnet.ibm.com> wrote:
>>>
>>> s/precise/precise about/
>>
>> Nod. Should I spin a v2 or is it better handled
>> via fixup by maintainer?
> 
> I prefer a respin. How about that jira issue(s)?
> You could then also include the # in the patch commit log then.
> Just say
> 
> VIRTIO-XXXX
> 
> in the commit log
> 

Will do. Thanks!


---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org