From: Thierry Reding <thierry.reding@gmail.com>
To: Manikanta Maddireddy <mmaddireddy@nvidia.com>
Cc: bhelgaas@google.com, lorenzo.pieralisi@arm.com, cyndis@kapsi.fi,
jonathanh@nvidia.com, linux-pci@vger.kernel.org,
linux-tegra@vger.kernel.org, vidyas@nvidia.com,
kthota@nvidia.com
Subject: Re: [PATCH V7 0/4] Add loadable kernel module and power management support
Date: Tue, 13 Feb 2018 14:08:58 +0100 [thread overview]
Message-ID: <20180213130858.GG6764@ulmo> (raw)
In-Reply-To: <1517289851-14111-1-git-send-email-mmaddireddy@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 2220 bytes --]
On Tue, Jan 30, 2018 at 10:54:07AM +0530, Manikanta Maddireddy wrote:
> This series of patches adds loadable kernel module and power management
> support to Tegra PCIe host controller driver. irq_set_msi_desc() and
> tegra_cpuidle_pcie_irqs_in_use() symbols will be taken care in next
> set of patches.
>
> These patches are tested on Jetson TK1, TX1 and TX2 platforms, following
> are the verification details.
> - Multiple module insert & remove
> - PCIe device functionality after module insert
> - Free clock, resets, regulators, powergate, iomem and interrupt
> resources after module remove
> - PCIe device functionality after resume from RAM
>
> V2: PM QoS fix is dropped in V2 from this series because the fix is
> incorporated in latest 'commit 0759e80b84e3 ("PM / QoS: Fix device resume
> latency framework")'. Update commit message of few patches in V2.
>
> V3: Patches to export irq_set_msi_desc() and tegra_cpuidle_pcie_irqs_in_use()
> are dropped based on review comments. These symbols will be addressed in next
> series. Took care of few other review comments.
>
> V4: Dropped pci_find_host_bridge() export patch and added new patch to use
> bus->sysdata for private data.
>
> V5: Decouple from https://patchwork.ozlabs.org/patch/832053/ and rebase
> on top of linux-next
>
> V6: Rebased on lpieralisi/pci/tegra branch
>
> V7: Addressed comments on patch: 6 and 7 in V6
> Limiting this series to linux-tegra & linux-pci since patches for other
> subsystem are merged or dropped
>
> Manikanta Maddireddy (4):
> PCI: tegra: Free resources on probe failure
> PCI: tegra: Add loadable kernel module support
> PCI: tegra: Broadcast PME_Turn_Off message before link goes to L2
> PCI: tegra: Add power management support
>
> drivers/pci/host/Kconfig | 2 +-
> drivers/pci/host/pci-tegra.c | 347 +++++++++++++++++++++++++++++++++----------
> 2 files changed, 272 insertions(+), 77 deletions(-)
With the exception of the failure when building as a module that I
mentioned on patch 3/4, I've successfully tested this on Tegra20
(TrimSlice), Tegra30 (Beaver) and Tegra186 (Jetson TX2):
Tested-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Manikanta Maddireddy
<mmaddireddy-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Cc: bhelgaas-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org,
lorenzo.pieralisi-5wv7dgnIgG8@public.gmane.org,
cyndis-/1wQRMveznE@public.gmane.org,
jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org,
linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
vidyas-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org,
kthota-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org
Subject: Re: [PATCH V7 0/4] Add loadable kernel module and power management support
Date: Tue, 13 Feb 2018 14:08:58 +0100 [thread overview]
Message-ID: <20180213130858.GG6764@ulmo> (raw)
In-Reply-To: <1517289851-14111-1-git-send-email-mmaddireddy-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 2249 bytes --]
On Tue, Jan 30, 2018 at 10:54:07AM +0530, Manikanta Maddireddy wrote:
> This series of patches adds loadable kernel module and power management
> support to Tegra PCIe host controller driver. irq_set_msi_desc() and
> tegra_cpuidle_pcie_irqs_in_use() symbols will be taken care in next
> set of patches.
>
> These patches are tested on Jetson TK1, TX1 and TX2 platforms, following
> are the verification details.
> - Multiple module insert & remove
> - PCIe device functionality after module insert
> - Free clock, resets, regulators, powergate, iomem and interrupt
> resources after module remove
> - PCIe device functionality after resume from RAM
>
> V2: PM QoS fix is dropped in V2 from this series because the fix is
> incorporated in latest 'commit 0759e80b84e3 ("PM / QoS: Fix device resume
> latency framework")'. Update commit message of few patches in V2.
>
> V3: Patches to export irq_set_msi_desc() and tegra_cpuidle_pcie_irqs_in_use()
> are dropped based on review comments. These symbols will be addressed in next
> series. Took care of few other review comments.
>
> V4: Dropped pci_find_host_bridge() export patch and added new patch to use
> bus->sysdata for private data.
>
> V5: Decouple from https://patchwork.ozlabs.org/patch/832053/ and rebase
> on top of linux-next
>
> V6: Rebased on lpieralisi/pci/tegra branch
>
> V7: Addressed comments on patch: 6 and 7 in V6
> Limiting this series to linux-tegra & linux-pci since patches for other
> subsystem are merged or dropped
>
> Manikanta Maddireddy (4):
> PCI: tegra: Free resources on probe failure
> PCI: tegra: Add loadable kernel module support
> PCI: tegra: Broadcast PME_Turn_Off message before link goes to L2
> PCI: tegra: Add power management support
>
> drivers/pci/host/Kconfig | 2 +-
> drivers/pci/host/pci-tegra.c | 347 +++++++++++++++++++++++++++++++++----------
> 2 files changed, 272 insertions(+), 77 deletions(-)
With the exception of the failure when building as a module that I
mentioned on patch 3/4, I've successfully tested this on Tegra20
(TrimSlice), Tegra30 (Beaver) and Tegra186 (Jetson TX2):
Tested-by: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-02-13 13:09 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-30 5:24 [PATCH V7 0/4] Add loadable kernel module and power management support Manikanta Maddireddy
2018-01-30 5:24 ` Manikanta Maddireddy
2018-01-30 5:24 ` [PATCH V7 1/4] PCI: tegra: Free resources on probe failure Manikanta Maddireddy
2018-01-30 5:24 ` Manikanta Maddireddy
2018-01-30 5:24 ` [PATCH V7 2/4] PCI: tegra: Add loadable kernel module support Manikanta Maddireddy
2018-01-30 5:24 ` Manikanta Maddireddy
2018-02-13 11:39 ` Thierry Reding
2018-02-13 11:39 ` Thierry Reding
2018-02-13 13:07 ` Thierry Reding
2018-02-13 13:18 ` Manikanta Maddireddy
2018-02-13 13:18 ` Manikanta Maddireddy
2018-02-13 13:51 ` Thierry Reding
2018-02-13 13:51 ` Thierry Reding
2018-02-13 15:26 ` Manikanta Maddireddy
2018-02-13 15:26 ` Manikanta Maddireddy
2018-02-13 15:30 ` Manikanta Maddireddy
2018-02-13 15:30 ` Manikanta Maddireddy
2018-01-30 5:24 ` [PATCH V7 3/4] PCI: tegra: Broadcast PME_Turn_Off message before link goes to L2 Manikanta Maddireddy
2018-01-30 5:24 ` Manikanta Maddireddy
2018-02-13 11:30 ` Thierry Reding
2018-02-13 11:30 ` Thierry Reding
2018-01-30 5:24 ` [PATCH V7 4/4] PCI: tegra: Add power management support Manikanta Maddireddy
2018-01-30 5:24 ` Manikanta Maddireddy
2018-02-13 13:07 ` Thierry Reding
2018-02-13 13:07 ` Thierry Reding
2018-02-13 13:08 ` Thierry Reding [this message]
2018-02-13 13:08 ` [PATCH V7 0/4] Add loadable kernel module and " Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180213130858.GG6764@ulmo \
--to=thierry.reding@gmail.com \
--cc=bhelgaas@google.com \
--cc=cyndis@kapsi.fi \
--cc=jonathanh@nvidia.com \
--cc=kthota@nvidia.com \
--cc=linux-pci@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=mmaddireddy@nvidia.com \
--cc=vidyas@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.