* [PATCH] netfilter: ipt_ah: return boolean instead of integer
@ 2018-02-13 14:25 Gustavo A. R. Silva
2018-03-05 22:10 ` Pablo Neira Ayuso
0 siblings, 1 reply; 3+ messages in thread
From: Gustavo A. R. Silva @ 2018-02-13 14:25 UTC (permalink / raw)
To: Pablo Neira Ayuso, Jozsef Kadlecsik, Florian Westphal,
David S. Miller, Alexey Kuznetsov, Hideaki YOSHIFUJI
Cc: netfilter-devel, coreteam, netdev, linux-kernel,
Gustavo A. R. Silva
Return statements in functions returning bool should use
true/false instead of 1/0.
This issue was detected with the help of Coccinelle.
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
---
net/ipv4/netfilter/ipt_ah.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ipv4/netfilter/ipt_ah.c b/net/ipv4/netfilter/ipt_ah.c
index a787d07..7c6c20e 100644
--- a/net/ipv4/netfilter/ipt_ah.c
+++ b/net/ipv4/netfilter/ipt_ah.c
@@ -47,7 +47,7 @@ static bool ah_mt(const struct sk_buff *skb, struct xt_action_param *par)
*/
pr_debug("Dropping evil AH tinygram.\n");
par->hotdrop = true;
- return 0;
+ return false;
}
return spi_match(ahinfo->spis[0], ahinfo->spis[1],
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] netfilter: ipt_ah: return boolean instead of integer
2018-02-13 14:25 [PATCH] netfilter: ipt_ah: return boolean instead of integer Gustavo A. R. Silva
@ 2018-03-05 22:10 ` Pablo Neira Ayuso
2018-03-05 22:22 ` Gustavo A. R. Silva
0 siblings, 1 reply; 3+ messages in thread
From: Pablo Neira Ayuso @ 2018-03-05 22:10 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: Jozsef Kadlecsik, Florian Westphal, David S. Miller,
Alexey Kuznetsov, Hideaki YOSHIFUJI, netfilter-devel, coreteam,
netdev, linux-kernel
On Tue, Feb 13, 2018 at 08:25:57AM -0600, Gustavo A. R. Silva wrote:
> Return statements in functions returning bool should use
> true/false instead of 1/0.
>
> This issue was detected with the help of Coccinelle.
This one didn't get in time for the previous merge window.
Now applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] netfilter: ipt_ah: return boolean instead of integer
2018-03-05 22:10 ` Pablo Neira Ayuso
@ 2018-03-05 22:22 ` Gustavo A. R. Silva
0 siblings, 0 replies; 3+ messages in thread
From: Gustavo A. R. Silva @ 2018-03-05 22:22 UTC (permalink / raw)
To: Pablo Neira Ayuso
Cc: Jozsef Kadlecsik, Florian Westphal, David S. Miller,
Alexey Kuznetsov, Hideaki YOSHIFUJI, netfilter-devel, coreteam,
netdev, linux-kernel
On 03/05/2018 04:10 PM, Pablo Neira Ayuso wrote:
> On Tue, Feb 13, 2018 at 08:25:57AM -0600, Gustavo A. R. Silva wrote:
>> Return statements in functions returning bool should use
>> true/false instead of 1/0.
>>
>> This issue was detected with the help of Coccinelle.
> This one didn't get in time for the previous merge window.
>
> Now applied, thanks.
Great.
Thanks, Pablo.
--
Gustavo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-03-05 22:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-02-13 14:25 [PATCH] netfilter: ipt_ah: return boolean instead of integer Gustavo A. R. Silva
2018-03-05 22:10 ` Pablo Neira Ayuso
2018-03-05 22:22 ` Gustavo A. R. Silva
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.