* [U-Boot] [PATCH] drivers/ddr/fsl: Dual-license DDR driver
2018-02-13 16:30 ` York Sun
@ 2018-02-13 16:39 ` Alexander Merkle
2018-02-13 16:42 ` York Sun
` (7 subsequent siblings)
8 siblings, 0 replies; 29+ messages in thread
From: Alexander Merkle @ 2018-02-13 16:39 UTC (permalink / raw)
To: u-boot
Am 13.02.2018 um 17:30 schrieb York Sun:
> On 02/13/2018 04:49 AM, Wolfgang Denk wrote:
>> Dear York,
>>
>> In message <VI1PR04MB20785EF7D2578E39C048EE219AF70@VI1PR04MB2078.eurprd04.prod.outlook.com> you wrote:
>>> Nobody said anything. Some addresses bounced. And most changes made out
>>> people outside Freescale/NXP are minor changes, except twice the files
>>> were moved during U-Boot structure change. What options do I have?
>> Ask all people who contributed to that code for their explicit
>> permission. Legally it is a huge difference between actively
>> confirming approval and not reacting at all.
>>
>
> All,
>
> If you haven't responded, please give your explicit approval to change
> Freescale DDR driver to dual-license so it can be re-used by other
> project(s) with BSD license. Here is the list I compiled from the git
> history. All commits made by Freescale/NXP employees are removed from
> this list.
>
>
> 00caae6 - Simon Glass, sjg at chromium.org, 6 months ago : env: Rename
> getenv/_f() to env_get()
> 457e51c - Simon Glass, sjg at chromium.org, 9 months ago : common: arm:
> freescale: layerscape: Move header files out of common.h
> 6e2941d - Simon Glass, sjg at chromium.org, 9 months ago : common:
> freescale: Move arch-specific declarations
> 3c476d8 - Tom Rini, trini at konsulko.com, 10 months ago : Merge
> git://git.denx.de/u-boot-fsl-qoriq
> 0e0de24 - xypron.glpk at gmx.de, xypron.glpk at gmx.de, 10 months ago : ddr:
> fsl: incorrect logical constraint in populate_memctl_options
> 97fbf26 - Thomas Schaefer, thomas.schaefer at kontron.com, 11 months ago :
> drivers: ddr: fsl: fix unused-const-variable warnings
> f1683aa - Simon Glass, sjg at chromium.org, 10 months ago : board_f: Rename
> initdram() to dram_init()
> 3eace37 - Simon Glass, sjg at chromium.org, 10 months ago : arm: freescale:
> Rename initdram() to fsl_initdram()
> 088454c - Simon Glass, sjg at chromium.org, 11 months ago : board_f: Drop
> return value from initdram()
> cbe7706 - Tom Rini, trini at konsulko.com, 1 year, 5 months ago : Merge
> git://git.denx.de/u-boot-fsl-qoriq
> a4ca379 - Masahiro Yamada, yamada.masahiro at socionext.com, 1 year, 5
> months ago : drivers: squash lines for immediate return
> 62a3b7d - Robert P. J. Day, rpjday at crashcourse.ca, 1 year, 7 months ago
> : Various, unrelated tree-wide typo fixes.
> dd8d8da - Alexander Merkle, alexander.merkle at lauterbach.com, 1 year, 11
> months ago : Fix typo choosen in comments and printf logs
> 5b8031c - Tom Rini, trini at konsulko.com, 2 years, 1 month ago : Add more
> SPDX-License-Identifier tags
> da58dec - Tom Rini, trini at konsulko.com, 2 years, 3 months ago : Various
> Makefiles: Add SPDX-License-Identifier tags
> e368c20 - Joakim Tjernlund, joakim.tjernlund at transmode.se, 2 years, 4
> months ago : drivers/ddr/fsl_ddr: Make SR_IE configurable
> d7c865b - Curt Brune, curt at cumulusnetworks.com, 3 years ago :
> MPC8541/MPC8555: Enable SS_EN in DDR_SDRAM_CLK_CNLT register
> b414119 - Masahiro Yamada, yamada.m at jp.panasonic.com, 3 years, 3 months
> ago : linux/kernel.h: sync min, max, min3, max3 macros with Linux
> e1bf824 - Simon Glass, sjg at chromium.org, 3 years, 10 months ago : Add
> cli_ prefix to readline functions
> 18d6653 - Simon Glass, sjg at chromium.org, 3 years, 10 months ago : move
> CLI prototypes to cli.h and add comments
> 06c1411 - Masahiro Yamada, yamada.m at jp.panasonic.com, 4 years, 4 months
> ago : powerpc: convert makefiles to Kbuild style
> 7e157b0 - Valentin Longchamp, valentin.longchamp at keymile.com, 4 years, 4
> months ago : mpc8xxx: set x2 DDR3 refresh rate if SPD config requires it
> 0778bbe - Valentin Longchamp, valentin.longchamp at keymile.com, 4 years, 4
> months ago : mpc8xxx: call i2c_set_bus_num in __get_spd
> 2f848f9 - Shruti Kanetkar, Shruti at Freescale.com, 4 years, 6 months ago :
> powerpc: Use print_size() where appropriate
> 1a45966 - Wolfgang Denk, wd at denx.de, 4 years, 7 months ago : Add
> GPL-2.0+ SPDX-License-Identifier to source files
> 5b93394 - Anatolij Gustschin, agust at denx.de, 5 years ago : mpc8xxx: fix
> DDR init value to use CONFIG_MEM_INIT_VALUE
> 411e150 - Kumar Gala, galak at kernel.crashing.org, 6 years ago :
> arch/powerpc/cpu/mpc8xxx/ddr/interactive.c: Fix GCC 4.6 build warning
> 2f3a71f - Ira W. Snyder, iws at ovro.caltech.edu, 6 years ago : mpc8xxx:
> update module_type values from JEDEC DDR3 SPD Specification
> dea7f88 - Kumar Gala, galak at kernel.crashing.org, 6 years ago :
> arch/powerpc/cpu/mpc8xxx/ddr/ctrl_regs.c: Fix GCC 4.6 build warning
> 667bc17 - Kumar Gala, galak at kernel.crashing.org, 6 years ago :
> arch/powerpc/cpu/mpc8xxx/ddr/options.c: Fix GCC 4.6 build warning
> cd84b1f - Marek Vasut, marek.vasut at gmail.com, 6 years ago : GCC4.6:
> Squash warnings in ddr[123]_dimm_params.c
> a287963 - Kyle Moffett, Kyle.D.Moffett at boeing.com, 7 years ago :
> fsl-ddr: Fix mixed-case macro names
> c2a63f4 - Kumar Gala, galak at kernel.crashing.org, 7 years ago :
> powerpc/8xxx: Fix typo for address hashing message
> c7fd27c - Kyle Moffett, Kyle.D.Moffett at boeing.com, 7 years ago :
> mpc8xxx: DDR2/DDR3: Clean up DIMM-type switch statements
> e820a13 - Kyle Moffett, Kyle.D.Moffett at boeing.com, 7 years ago :
> fsl_ddr: Don't use full 64-bit divides on 32-bit PowerPC
> c39f44d - Kumar Gala, galak at kernel.crashing.org, 7 years ago :
> powerpc/8xxx: Refactor fsl_ddr_get_spd into common code from board
> 5df4b0a - Kumar Gala, galak at kernel.crashing.org, 7 years ago :
> powerpc/8xxx: Replace fsl_ddr_get_mem_data_rate with get_ddr_freq()
> 9296683 - Kumar Gala, galak at kernel.crashing.org, 7 years ago :
> powerpc/8xxx: Fix compile warning when build for a DDR1 or DDR2 board
> dd50af2 - Kumar Gala, galak at kernel.crashing.org, 7 years ago :
> powerpc/8xxx: Add hwconfig APIs to address early parsing used by DDR init
> 3dbd5d7 - Kumar Gala, galak at kernel.crashing.org, 7 years ago :
> powerpc/8xxx: Move fsl_is_spd() into generic 8xxx ddr code
> 7ea3871 - Becky Bruce, beckyb at kernel.crashing.org, 7 years ago : MPC8xxx
> DDR: align informational prints
> 6d8962e - Sebastien Carlier, sebastien.carlier at gmail.com, 7 years ago :
> Switch from archive libraries to partial linking
> 79e4e64 - Kumar Gala, galak at kernel.crashing.org, 8 years ago :
> powerpc/8xxx: Enabled hwconfig for memory interleaving
> a47a12b - Stefan Roese, sr at denx.de, 8 years ago : Move arch/ppc to
> arch/powerpc
> 8d1f268 - Peter Tyser, ptyser at xes-inc.com, 8 years ago : ppc: Move
> cpu/$CPU to arch/ppc/cpu/$CPU
>
> Thanks.
>
> York
Ack.
^ permalink raw reply [flat|nested] 29+ messages in thread* [U-Boot] [PATCH] drivers/ddr/fsl: Dual-license DDR driver
2018-02-13 16:30 ` York Sun
2018-02-13 16:39 ` Alexander Merkle
@ 2018-02-13 16:42 ` York Sun
2018-02-13 17:00 ` York Sun
2018-02-13 17:07 ` Marek Vasut
` (6 subsequent siblings)
8 siblings, 1 reply; 29+ messages in thread
From: York Sun @ 2018-02-13 16:42 UTC (permalink / raw)
To: u-boot
On 02/13/2018 08:30 AM, York Sun wrote:
> On 02/13/2018 04:49 AM, Wolfgang Denk wrote:
>> Dear York,
>>
>> In message <VI1PR04MB20785EF7D2578E39C048EE219AF70@VI1PR04MB2078.eurprd04.prod.outlook.com> you wrote:
>>>
>>> Nobody said anything. Some addresses bounced. And most changes made out
>>> people outside Freescale/NXP are minor changes, except twice the files
>>> were moved during U-Boot structure change. What options do I have?
>>
>> Ask all people who contributed to that code for their explicit
>> permission. Legally it is a huge difference between actively
>> confirming approval and not reacting at all.
>>
>
>
> All,
>
> If you haven't responded, please give your explicit approval to change
> Freescale DDR driver to dual-license so it can be re-used by other
> project(s) with BSD license. Here is the list I compiled from the git
> history. All commits made by Freescale/NXP employees are removed from
> this list.
>
>
I should have removed Kumar Gala and Becky Bruce from the git log. They
were Freescale employees then. Sorry for the confusion.
York
^ permalink raw reply [flat|nested] 29+ messages in thread* [U-Boot] [PATCH] drivers/ddr/fsl: Dual-license DDR driver
2018-02-13 16:42 ` York Sun
@ 2018-02-13 17:00 ` York Sun
0 siblings, 0 replies; 29+ messages in thread
From: York Sun @ 2018-02-13 17:00 UTC (permalink / raw)
To: u-boot
On 02/13/2018 08:44 AM, York Sun wrote:
> On 02/13/2018 08:30 AM, York Sun wrote:
>> On 02/13/2018 04:49 AM, Wolfgang Denk wrote:
>>> Dear York,
>>>
>>> In message <VI1PR04MB20785EF7D2578E39C048EE219AF70@VI1PR04MB2078.eurprd04.prod.outlook.com> you wrote:
>>>>
>>>> Nobody said anything. Some addresses bounced. And most changes made out
>>>> people outside Freescale/NXP are minor changes, except twice the files
>>>> were moved during U-Boot structure change. What options do I have?
>>>
>>> Ask all people who contributed to that code for their explicit
>>> permission. Legally it is a huge difference between actively
>>> confirming approval and not reacting at all.
>>>
>>
>>
>> All,
>>
>> If you haven't responded, please give your explicit approval to change
>> Freescale DDR driver to dual-license so it can be re-used by other
>> project(s) with BSD license. Here is the list I compiled from the git
>> history. All commits made by Freescale/NXP employees are removed from
>> this list.
>>
>>
>
> I should have removed Kumar Gala and Becky Bruce from the git log. They
> were Freescale employees then. Sorry for the confusion.
>
Thanks to those who already replied. Sorry for spamming your inbox.
+Paul Gortmaker
I missed these commits in previous git log list.
8d1f268 - Peter Tyser, ptyser at xes-inc.com, 8 years ago : ppc: Move
cpu/$CPU to arch/ppc/cpu/$CPU
d11823c - Paul Gortmaker, paul.gortmaker at windriver.com, 8 years ago :
mpc8xxx: improve LAW error messages when setting up DDR
d9c147f - Peter Tyser, ptyser at xes-inc.com, 9 years ago : 85xx, 86xx: Add
common board_add_ram_info()
6d0f6bc - Jean-Christophe PLAGNIOL-VILLARD, plagnioj at jcrosoft.com, 9
years ago : rename CFG_ macros to CONFIG_SYS
f12e454 - Wolfgang Denk, wd at denx.de, 9 years ago : Coding style cleanup,
update CHANGELOG
York
^ permalink raw reply [flat|nested] 29+ messages in thread
* [U-Boot] [PATCH] drivers/ddr/fsl: Dual-license DDR driver
2018-02-13 16:30 ` York Sun
2018-02-13 16:39 ` Alexander Merkle
2018-02-13 16:42 ` York Sun
@ 2018-02-13 17:07 ` Marek Vasut
2018-02-13 18:32 ` York Sun
2018-02-13 17:11 ` York Sun
` (5 subsequent siblings)
8 siblings, 1 reply; 29+ messages in thread
From: Marek Vasut @ 2018-02-13 17:07 UTC (permalink / raw)
To: u-boot
On 02/13/2018 05:30 PM, York Sun wrote:
> On 02/13/2018 04:49 AM, Wolfgang Denk wrote:
>> Dear York,
>>
>> In message <VI1PR04MB20785EF7D2578E39C048EE219AF70@VI1PR04MB2078.eurprd04.prod.outlook.com> you wrote:
>>>
>>> Nobody said anything. Some addresses bounced. And most changes made out
>>> people outside Freescale/NXP are minor changes, except twice the files
>>> were moved during U-Boot structure change. What options do I have?
>>
>> Ask all people who contributed to that code for their explicit
>> permission. Legally it is a huge difference between actively
>> confirming approval and not reacting at all.
>>
>
>
> All,
>
> If you haven't responded, please give your explicit approval to change
> Freescale DDR driver to dual-license so it can be re-used by other
> project(s) with BSD license. Here is the list I compiled from the git
> history. All commits made by Freescale/NXP employees are removed from
> this list.
[...]
> cd84b1f - Marek Vasut, marek.vasut at gmail.com, 6 years ago : GCC4.6:
> Squash warnings in ddr[123]_dimm_params.c
I do NOT approve.
My previous experience with dual-licensed code was with wpa-supplicant.
A certain company manufacturing handhelds took it, modified it and was
selling the binary. While we were porting Linux onto the device, we
asked for the modifications to get the WiFi operational in the Linux port.
What we got from this company was "it's BSD licensed, go away". Were the
code GPL, they would be legally obliged to provide the changes, but it
was BSD, so the company in question could make profit and the community
lost.
This was a prime example of how BSD license is harmful to software
freedom and how the community lost because of the BSD license. I do not
want to see this happening ever again and I like GPL for that very much.
--
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 29+ messages in thread* [U-Boot] [PATCH] drivers/ddr/fsl: Dual-license DDR driver
2018-02-13 17:07 ` Marek Vasut
@ 2018-02-13 18:32 ` York Sun
2018-02-13 19:16 ` Marek Vasut
0 siblings, 1 reply; 29+ messages in thread
From: York Sun @ 2018-02-13 18:32 UTC (permalink / raw)
To: u-boot
On 02/13/2018 09:38 AM, Marek Vasut wrote:
> On 02/13/2018 05:30 PM, York Sun wrote:
>> On 02/13/2018 04:49 AM, Wolfgang Denk wrote:
>>> Dear York,
>>>
>>> In message <VI1PR04MB20785EF7D2578E39C048EE219AF70@VI1PR04MB2078.eurprd04.prod.outlook.com> you wrote:
>>>>
>>>> Nobody said anything. Some addresses bounced. And most changes made out
>>>> people outside Freescale/NXP are minor changes, except twice the files
>>>> were moved during U-Boot structure change. What options do I have?
>>>
>>> Ask all people who contributed to that code for their explicit
>>> permission. Legally it is a huge difference between actively
>>> confirming approval and not reacting at all.
>>>
>>
>>
>> All,
>>
>> If you haven't responded, please give your explicit approval to change
>> Freescale DDR driver to dual-license so it can be re-used by other
>> project(s) with BSD license. Here is the list I compiled from the git
>> history. All commits made by Freescale/NXP employees are removed from
>> this list.
>
> [...]
>
>> cd84b1f - Marek Vasut, marek.vasut at gmail.com, 6 years ago : GCC4.6:
>> Squash warnings in ddr[123]_dimm_params.c
>
> I do NOT approve.
>
> My previous experience with dual-licensed code was with wpa-supplicant.
> A certain company manufacturing handhelds took it, modified it and was
> selling the binary. While we were porting Linux onto the device, we
> asked for the modifications to get the WiFi operational in the Linux port.
>
> What we got from this company was "it's BSD licensed, go away". Were the
> code GPL, they would be legally obliged to provide the changes, but it
> was BSD, so the company in question could make profit and the community
> lost.
>
> This was a prime example of how BSD license is harmful to software
> freedom and how the community lost because of the BSD license. I do not
> want to see this happening ever again and I like GPL for that very much.
>
Marek,
Please allow me to try to convince you.
Git log shows you have one commit cd84b1f which fixed the compiling
warning for GCC 4.6 on three debug messages. I appreciate your fix.
This driver is for Freescale/NXP DDR controllers, specifically designed
on Freescale/NXP SoCs. We spent tremendous effort to make it robust.
This driver is useful to initialize DDR for the platforms. While we are
moving the platform initialization to ATF (Arm Trusted Firmware), or
other pre-bootloader code (such as NXP's implementation of ATF), this
driver can be reused to provide the same level of hardware support. As
you may know, ATF uses BSD-3 license (some files have GPL/BSD dual
licnese). Your approval will make our life easier without having to
rewrite the entire driver from scratch.
Thanks for your reconsideration.
York
^ permalink raw reply [flat|nested] 29+ messages in thread
* [U-Boot] [PATCH] drivers/ddr/fsl: Dual-license DDR driver
2018-02-13 18:32 ` York Sun
@ 2018-02-13 19:16 ` Marek Vasut
2018-02-13 19:33 ` York Sun
0 siblings, 1 reply; 29+ messages in thread
From: Marek Vasut @ 2018-02-13 19:16 UTC (permalink / raw)
To: u-boot
On 02/13/2018 07:32 PM, York Sun wrote:
> On 02/13/2018 09:38 AM, Marek Vasut wrote:
>> On 02/13/2018 05:30 PM, York Sun wrote:
>>> On 02/13/2018 04:49 AM, Wolfgang Denk wrote:
>>>> Dear York,
>>>>
>>>> In message <VI1PR04MB20785EF7D2578E39C048EE219AF70@VI1PR04MB2078.eurprd04.prod.outlook.com> you wrote:
>>>>>
>>>>> Nobody said anything. Some addresses bounced. And most changes made out
>>>>> people outside Freescale/NXP are minor changes, except twice the files
>>>>> were moved during U-Boot structure change. What options do I have?
>>>>
>>>> Ask all people who contributed to that code for their explicit
>>>> permission. Legally it is a huge difference between actively
>>>> confirming approval and not reacting at all.
>>>>
>>>
>>>
>>> All,
>>>
>>> If you haven't responded, please give your explicit approval to change
>>> Freescale DDR driver to dual-license so it can be re-used by other
>>> project(s) with BSD license. Here is the list I compiled from the git
>>> history. All commits made by Freescale/NXP employees are removed from
>>> this list.
>>
>> [...]
>>
>>> cd84b1f - Marek Vasut, marek.vasut at gmail.com, 6 years ago : GCC4.6:
>>> Squash warnings in ddr[123]_dimm_params.c
>>
>> I do NOT approve.
>>
>> My previous experience with dual-licensed code was with wpa-supplicant.
>> A certain company manufacturing handhelds took it, modified it and was
>> selling the binary. While we were porting Linux onto the device, we
>> asked for the modifications to get the WiFi operational in the Linux port.
>>
>> What we got from this company was "it's BSD licensed, go away". Were the
>> code GPL, they would be legally obliged to provide the changes, but it
>> was BSD, so the company in question could make profit and the community
>> lost.
>>
>> This was a prime example of how BSD license is harmful to software
>> freedom and how the community lost because of the BSD license. I do not
>> want to see this happening ever again and I like GPL for that very much.
>>
>
> Marek,
>
> Please allow me to try to convince you.
> Git log shows you have one commit cd84b1f which fixed the compiling
> warning for GCC 4.6 on three debug messages. I appreciate your fix.
>
> This driver is for Freescale/NXP DDR controllers, specifically designed
> on Freescale/NXP SoCs. We spent tremendous effort to make it robust.
> This driver is useful to initialize DDR for the platforms. While we are
> moving the platform initialization to ATF (Arm Trusted Firmware), or
> other pre-bootloader code (such as NXP's implementation of ATF), this
> driver can be reused to provide the same level of hardware support. As
> you may know, ATF uses BSD-3 license (some files have GPL/BSD dual
> licnese). Your approval will make our life easier without having to
> rewrite the entire driver from scratch.
So what is in it for me ?
If the code remains GPL, I can ask NXP for changes to the driver if I
have the binary which contains this code.
If the code gets re-licensed to dual GPL/BSD, I assume in certain cases,
NXP will choose BSD and will not be obliged to provide the changes.
I don't see any benefit for me, any way I look at it, I'm either even or
loose .
Why can't you use the code under the current (GPL) license anyway ?
--
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 29+ messages in thread
* [U-Boot] [PATCH] drivers/ddr/fsl: Dual-license DDR driver
2018-02-13 19:16 ` Marek Vasut
@ 2018-02-13 19:33 ` York Sun
2018-02-13 20:09 ` Marek Vasut
0 siblings, 1 reply; 29+ messages in thread
From: York Sun @ 2018-02-13 19:33 UTC (permalink / raw)
To: u-boot
On 02/13/2018 11:16 AM, Marek Vasut wrote:
> On 02/13/2018 07:32 PM, York Sun wrote:
>> On 02/13/2018 09:38 AM, Marek Vasut wrote:
>>> On 02/13/2018 05:30 PM, York Sun wrote:
>>>> On 02/13/2018 04:49 AM, Wolfgang Denk wrote:
>>>>> Dear York,
>>>>>
>>>>> In message <VI1PR04MB20785EF7D2578E39C048EE219AF70@VI1PR04MB2078.eurprd04.prod.outlook.com> you wrote:
>>>>>>
>>>>>> Nobody said anything. Some addresses bounced. And most changes made out
>>>>>> people outside Freescale/NXP are minor changes, except twice the files
>>>>>> were moved during U-Boot structure change. What options do I have?
>>>>>
>>>>> Ask all people who contributed to that code for their explicit
>>>>> permission. Legally it is a huge difference between actively
>>>>> confirming approval and not reacting at all.
>>>>>
>>>>
>>>>
>>>> All,
>>>>
>>>> If you haven't responded, please give your explicit approval to change
>>>> Freescale DDR driver to dual-license so it can be re-used by other
>>>> project(s) with BSD license. Here is the list I compiled from the git
>>>> history. All commits made by Freescale/NXP employees are removed from
>>>> this list.
>>>
>>> [...]
>>>
>>>> cd84b1f - Marek Vasut, marek.vasut at gmail.com, 6 years ago : GCC4.6:
>>>> Squash warnings in ddr[123]_dimm_params.c
>>>
>>> I do NOT approve.
>>>
>>> My previous experience with dual-licensed code was with wpa-supplicant.
>>> A certain company manufacturing handhelds took it, modified it and was
>>> selling the binary. While we were porting Linux onto the device, we
>>> asked for the modifications to get the WiFi operational in the Linux port.
>>>
>>> What we got from this company was "it's BSD licensed, go away". Were the
>>> code GPL, they would be legally obliged to provide the changes, but it
>>> was BSD, so the company in question could make profit and the community
>>> lost.
>>>
>>> This was a prime example of how BSD license is harmful to software
>>> freedom and how the community lost because of the BSD license. I do not
>>> want to see this happening ever again and I like GPL for that very much.
>>>
>>
>> Marek,
>>
>> Please allow me to try to convince you.
>> Git log shows you have one commit cd84b1f which fixed the compiling
>> warning for GCC 4.6 on three debug messages. I appreciate your fix.
>>
>> This driver is for Freescale/NXP DDR controllers, specifically designed
>> on Freescale/NXP SoCs. We spent tremendous effort to make it robust.
>> This driver is useful to initialize DDR for the platforms. While we are
>> moving the platform initialization to ATF (Arm Trusted Firmware), or
>> other pre-bootloader code (such as NXP's implementation of ATF), this
>> driver can be reused to provide the same level of hardware support. As
>> you may know, ATF uses BSD-3 license (some files have GPL/BSD dual
>> licnese). Your approval will make our life easier without having to
>> rewrite the entire driver from scratch.
>
> So what is in it for me ?
You may have the flexibility to use ATF or other pre-bootloader software
_if_ we successfully upstream this driver to ATF project.
>
> If the code remains GPL, I can ask NXP for changes to the driver if I
> have the binary which contains this code.
>
> If the code gets re-licensed to dual GPL/BSD, I assume in certain cases,
> NXP will choose BSD and will not be obliged to provide the changes.
Guess who makes substantial changes to the hardware driver? The people
with extensive knowledge of the hardware design. It's not our interest
to hide our design from any users.
>
> I don't see any benefit for me, any way I look at it, I'm either even or
> loose .
If we don't find a way to reuse this driver, I will have to write a new
driver. It's not easy to keep two different drivers in sync. So _this_
driver will probably be left behind. I don't think that's in anyone's
interest.
>
> Why can't you use the code under the current (GPL) license anyway ?
>
Do you think the GPL driver can be added to ATF project? I don't think
so. So it is a matter of we either can have it in ATF, or we can't.
York
^ permalink raw reply [flat|nested] 29+ messages in thread
* [U-Boot] [PATCH] drivers/ddr/fsl: Dual-license DDR driver
2018-02-13 19:33 ` York Sun
@ 2018-02-13 20:09 ` Marek Vasut
2018-02-13 20:14 ` York Sun
0 siblings, 1 reply; 29+ messages in thread
From: Marek Vasut @ 2018-02-13 20:09 UTC (permalink / raw)
To: u-boot
On 02/13/2018 08:33 PM, York Sun wrote:
> On 02/13/2018 11:16 AM, Marek Vasut wrote:
>> On 02/13/2018 07:32 PM, York Sun wrote:
>>> On 02/13/2018 09:38 AM, Marek Vasut wrote:
>>>> On 02/13/2018 05:30 PM, York Sun wrote:
>>>>> On 02/13/2018 04:49 AM, Wolfgang Denk wrote:
>>>>>> Dear York,
>>>>>>
>>>>>> In message <VI1PR04MB20785EF7D2578E39C048EE219AF70@VI1PR04MB2078.eurprd04.prod.outlook.com> you wrote:
>>>>>>>
>>>>>>> Nobody said anything. Some addresses bounced. And most changes made out
>>>>>>> people outside Freescale/NXP are minor changes, except twice the files
>>>>>>> were moved during U-Boot structure change. What options do I have?
>>>>>>
>>>>>> Ask all people who contributed to that code for their explicit
>>>>>> permission. Legally it is a huge difference between actively
>>>>>> confirming approval and not reacting at all.
>>>>>>
>>>>>
>>>>>
>>>>> All,
>>>>>
>>>>> If you haven't responded, please give your explicit approval to change
>>>>> Freescale DDR driver to dual-license so it can be re-used by other
>>>>> project(s) with BSD license. Here is the list I compiled from the git
>>>>> history. All commits made by Freescale/NXP employees are removed from
>>>>> this list.
>>>>
>>>> [...]
>>>>
>>>>> cd84b1f - Marek Vasut, marek.vasut at gmail.com, 6 years ago : GCC4.6:
>>>>> Squash warnings in ddr[123]_dimm_params.c
>>>>
>>>> I do NOT approve.
>>>>
>>>> My previous experience with dual-licensed code was with wpa-supplicant.
>>>> A certain company manufacturing handhelds took it, modified it and was
>>>> selling the binary. While we were porting Linux onto the device, we
>>>> asked for the modifications to get the WiFi operational in the Linux port.
>>>>
>>>> What we got from this company was "it's BSD licensed, go away". Were the
>>>> code GPL, they would be legally obliged to provide the changes, but it
>>>> was BSD, so the company in question could make profit and the community
>>>> lost.
>>>>
>>>> This was a prime example of how BSD license is harmful to software
>>>> freedom and how the community lost because of the BSD license. I do not
>>>> want to see this happening ever again and I like GPL for that very much.
>>>>
>>>
>>> Marek,
>>>
>>> Please allow me to try to convince you.
>>> Git log shows you have one commit cd84b1f which fixed the compiling
>>> warning for GCC 4.6 on three debug messages. I appreciate your fix.
>>>
>>> This driver is for Freescale/NXP DDR controllers, specifically designed
>>> on Freescale/NXP SoCs. We spent tremendous effort to make it robust.
>>> This driver is useful to initialize DDR for the platforms. While we are
>>> moving the platform initialization to ATF (Arm Trusted Firmware), or
>>> other pre-bootloader code (such as NXP's implementation of ATF), this
>>> driver can be reused to provide the same level of hardware support. As
>>> you may know, ATF uses BSD-3 license (some files have GPL/BSD dual
>>> licnese). Your approval will make our life easier without having to
>>> rewrite the entire driver from scratch.
>>
>> So what is in it for me ?
>
> You may have the flexibility to use ATF or other pre-bootloader software
> _if_ we successfully upstream this driver to ATF project.
It also allows you to just distribute binaries of the ATF without
releasing the source.
>> If the code remains GPL, I can ask NXP for changes to the driver if I
>> have the binary which contains this code.
>>
>> If the code gets re-licensed to dual GPL/BSD, I assume in certain cases,
>> NXP will choose BSD and will not be obliged to provide the changes.
>
> Guess who makes substantial changes to the hardware driver? The people
> with extensive knowledge of the hardware design. It's not our interest
> to hide our design from any users.
>
>> I don't see any benefit for me, any way I look at it, I'm either even or
>> loose .
>
> If we don't find a way to reuse this driver, I will have to write a new
> driver. It's not easy to keep two different drivers in sync. So _this_
> driver will probably be left behind. I don't think that's in anyone's
> interest.
>
>>
>> Why can't you use the code under the current (GPL) license anyway ?
>>
>
> Do you think the GPL driver can be added to ATF project? I don't think
> so. So it is a matter of we either can have it in ATF, or we can't.
Well, it seems this patch was applied to U-Boot master anyway [1], even
though there are concerns and ongoing discussion ... so I lost anyway.
I am _extremely_ disappointed !
[1] https://patchwork.ozlabs.org/patch/872169/
--
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 29+ messages in thread
* [U-Boot] [PATCH] drivers/ddr/fsl: Dual-license DDR driver
2018-02-13 20:09 ` Marek Vasut
@ 2018-02-13 20:14 ` York Sun
2018-02-13 22:02 ` Marek Vasut
0 siblings, 1 reply; 29+ messages in thread
From: York Sun @ 2018-02-13 20:14 UTC (permalink / raw)
To: u-boot
On 02/13/2018 12:09 PM, Marek Vasut wrote:
> On 02/13/2018 08:33 PM, York Sun wrote:
>> On 02/13/2018 11:16 AM, Marek Vasut wrote:
>>> On 02/13/2018 07:32 PM, York Sun wrote:
>>>> On 02/13/2018 09:38 AM, Marek Vasut wrote:
>>>>> On 02/13/2018 05:30 PM, York Sun wrote:
>>>>>> On 02/13/2018 04:49 AM, Wolfgang Denk wrote:
>>>>>>> Dear York,
>>>>>>>
>>>>>>> In message <VI1PR04MB20785EF7D2578E39C048EE219AF70@VI1PR04MB2078.eurprd04.prod.outlook.com> you wrote:
>>>>>>>>
>>>>>>>> Nobody said anything. Some addresses bounced. And most changes made out
>>>>>>>> people outside Freescale/NXP are minor changes, except twice the files
>>>>>>>> were moved during U-Boot structure change. What options do I have?
>>>>>>>
>>>>>>> Ask all people who contributed to that code for their explicit
>>>>>>> permission. Legally it is a huge difference between actively
>>>>>>> confirming approval and not reacting at all.
>>>>>>>
>>>>>>
>>>>>>
>>>>>> All,
>>>>>>
>>>>>> If you haven't responded, please give your explicit approval to change
>>>>>> Freescale DDR driver to dual-license so it can be re-used by other
>>>>>> project(s) with BSD license. Here is the list I compiled from the git
>>>>>> history. All commits made by Freescale/NXP employees are removed from
>>>>>> this list.
>>>>>
>>>>> [...]
>>>>>
>>>>>> cd84b1f - Marek Vasut, marek.vasut at gmail.com, 6 years ago : GCC4.6:
>>>>>> Squash warnings in ddr[123]_dimm_params.c
>>>>>
>>>>> I do NOT approve.
>>>>>
>>>>> My previous experience with dual-licensed code was with wpa-supplicant.
>>>>> A certain company manufacturing handhelds took it, modified it and was
>>>>> selling the binary. While we were porting Linux onto the device, we
>>>>> asked for the modifications to get the WiFi operational in the Linux port.
>>>>>
>>>>> What we got from this company was "it's BSD licensed, go away". Were the
>>>>> code GPL, they would be legally obliged to provide the changes, but it
>>>>> was BSD, so the company in question could make profit and the community
>>>>> lost.
>>>>>
>>>>> This was a prime example of how BSD license is harmful to software
>>>>> freedom and how the community lost because of the BSD license. I do not
>>>>> want to see this happening ever again and I like GPL for that very much.
>>>>>
>>>>
>>>> Marek,
>>>>
>>>> Please allow me to try to convince you.
>>>> Git log shows you have one commit cd84b1f which fixed the compiling
>>>> warning for GCC 4.6 on three debug messages. I appreciate your fix.
>>>>
>>>> This driver is for Freescale/NXP DDR controllers, specifically designed
>>>> on Freescale/NXP SoCs. We spent tremendous effort to make it robust.
>>>> This driver is useful to initialize DDR for the platforms. While we are
>>>> moving the platform initialization to ATF (Arm Trusted Firmware), or
>>>> other pre-bootloader code (such as NXP's implementation of ATF), this
>>>> driver can be reused to provide the same level of hardware support. As
>>>> you may know, ATF uses BSD-3 license (some files have GPL/BSD dual
>>>> licnese). Your approval will make our life easier without having to
>>>> rewrite the entire driver from scratch.
>>>
>>> So what is in it for me ?
>>
>> You may have the flexibility to use ATF or other pre-bootloader software
>> _if_ we successfully upstream this driver to ATF project.
>
> It also allows you to just distribute binaries of the ATF without
> releasing the source.
>
>>> If the code remains GPL, I can ask NXP for changes to the driver if I
>>> have the binary which contains this code.
>>>
>>> If the code gets re-licensed to dual GPL/BSD, I assume in certain cases,
>>> NXP will choose BSD and will not be obliged to provide the changes.
>>
>> Guess who makes substantial changes to the hardware driver? The people
>> with extensive knowledge of the hardware design. It's not our interest
>> to hide our design from any users.
>>
>>> I don't see any benefit for me, any way I look at it, I'm either even or
>>> loose .
>>
>> If we don't find a way to reuse this driver, I will have to write a new
>> driver. It's not easy to keep two different drivers in sync. So _this_
>> driver will probably be left behind. I don't think that's in anyone's
>> interest.
>>
>>>
>>> Why can't you use the code under the current (GPL) license anyway ?
>>>
>>
>> Do you think the GPL driver can be added to ATF project? I don't think
>> so. So it is a matter of we either can have it in ATF, or we can't.
>
> Well, it seems this patch was applied to U-Boot master anyway [1], even
> though there are concerns and ongoing discussion ... so I lost anyway.
>
> I am _extremely_ disappointed !
I take the responsibility for requesting the pull without getting your
approval in time. I am still trying to convince you it is right to use
dual license on this driver. Do you want to continue the discussion?
York
^ permalink raw reply [flat|nested] 29+ messages in thread
* [U-Boot] [PATCH] drivers/ddr/fsl: Dual-license DDR driver
2018-02-13 20:14 ` York Sun
@ 2018-02-13 22:02 ` Marek Vasut
0 siblings, 0 replies; 29+ messages in thread
From: Marek Vasut @ 2018-02-13 22:02 UTC (permalink / raw)
To: u-boot
On 02/13/2018 09:14 PM, York Sun wrote:
> On 02/13/2018 12:09 PM, Marek Vasut wrote:
>> On 02/13/2018 08:33 PM, York Sun wrote:
>>> On 02/13/2018 11:16 AM, Marek Vasut wrote:
>>>> On 02/13/2018 07:32 PM, York Sun wrote:
>>>>> On 02/13/2018 09:38 AM, Marek Vasut wrote:
>>>>>> On 02/13/2018 05:30 PM, York Sun wrote:
>>>>>>> On 02/13/2018 04:49 AM, Wolfgang Denk wrote:
>>>>>>>> Dear York,
>>>>>>>>
>>>>>>>> In message <VI1PR04MB20785EF7D2578E39C048EE219AF70@VI1PR04MB2078.eurprd04.prod.outlook.com> you wrote:
>>>>>>>>>
>>>>>>>>> Nobody said anything. Some addresses bounced. And most changes made out
>>>>>>>>> people outside Freescale/NXP are minor changes, except twice the files
>>>>>>>>> were moved during U-Boot structure change. What options do I have?
>>>>>>>>
>>>>>>>> Ask all people who contributed to that code for their explicit
>>>>>>>> permission. Legally it is a huge difference between actively
>>>>>>>> confirming approval and not reacting at all.
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> All,
>>>>>>>
>>>>>>> If you haven't responded, please give your explicit approval to change
>>>>>>> Freescale DDR driver to dual-license so it can be re-used by other
>>>>>>> project(s) with BSD license. Here is the list I compiled from the git
>>>>>>> history. All commits made by Freescale/NXP employees are removed from
>>>>>>> this list.
>>>>>>
>>>>>> [...]
>>>>>>
>>>>>>> cd84b1f - Marek Vasut, marek.vasut at gmail.com, 6 years ago : GCC4.6:
>>>>>>> Squash warnings in ddr[123]_dimm_params.c
>>>>>>
>>>>>> I do NOT approve.
>>>>>>
>>>>>> My previous experience with dual-licensed code was with wpa-supplicant.
>>>>>> A certain company manufacturing handhelds took it, modified it and was
>>>>>> selling the binary. While we were porting Linux onto the device, we
>>>>>> asked for the modifications to get the WiFi operational in the Linux port.
>>>>>>
>>>>>> What we got from this company was "it's BSD licensed, go away". Were the
>>>>>> code GPL, they would be legally obliged to provide the changes, but it
>>>>>> was BSD, so the company in question could make profit and the community
>>>>>> lost.
>>>>>>
>>>>>> This was a prime example of how BSD license is harmful to software
>>>>>> freedom and how the community lost because of the BSD license. I do not
>>>>>> want to see this happening ever again and I like GPL for that very much.
>>>>>>
>>>>>
>>>>> Marek,
>>>>>
>>>>> Please allow me to try to convince you.
>>>>> Git log shows you have one commit cd84b1f which fixed the compiling
>>>>> warning for GCC 4.6 on three debug messages. I appreciate your fix.
>>>>>
>>>>> This driver is for Freescale/NXP DDR controllers, specifically designed
>>>>> on Freescale/NXP SoCs. We spent tremendous effort to make it robust.
>>>>> This driver is useful to initialize DDR for the platforms. While we are
>>>>> moving the platform initialization to ATF (Arm Trusted Firmware), or
>>>>> other pre-bootloader code (such as NXP's implementation of ATF), this
>>>>> driver can be reused to provide the same level of hardware support. As
>>>>> you may know, ATF uses BSD-3 license (some files have GPL/BSD dual
>>>>> licnese). Your approval will make our life easier without having to
>>>>> rewrite the entire driver from scratch.
>>>>
>>>> So what is in it for me ?
>>>
>>> You may have the flexibility to use ATF or other pre-bootloader software
>>> _if_ we successfully upstream this driver to ATF project.
>>
>> It also allows you to just distribute binaries of the ATF without
>> releasing the source.
>>
>>>> If the code remains GPL, I can ask NXP for changes to the driver if I
>>>> have the binary which contains this code.
>>>>
>>>> If the code gets re-licensed to dual GPL/BSD, I assume in certain cases,
>>>> NXP will choose BSD and will not be obliged to provide the changes.
>>>
>>> Guess who makes substantial changes to the hardware driver? The people
>>> with extensive knowledge of the hardware design. It's not our interest
>>> to hide our design from any users.
>>>
>>>> I don't see any benefit for me, any way I look at it, I'm either even or
>>>> loose .
>>>
>>> If we don't find a way to reuse this driver, I will have to write a new
>>> driver. It's not easy to keep two different drivers in sync. So _this_
>>> driver will probably be left behind. I don't think that's in anyone's
>>> interest.
>>>
>>>>
>>>> Why can't you use the code under the current (GPL) license anyway ?
>>>>
>>>
>>> Do you think the GPL driver can be added to ATF project? I don't think
>>> so. So it is a matter of we either can have it in ATF, or we can't.
>>
>> Well, it seems this patch was applied to U-Boot master anyway [1], even
>> though there are concerns and ongoing discussion ... so I lost anyway.
>>
>> I am _extremely_ disappointed !
>
> I take the responsibility for requesting the pull without getting your
> approval in time. I am still trying to convince you it is right to use
> dual license on this driver. Do you want to continue the discussion?
No, do whatever you want with this file.
I am not looking forward to the day when this salami-method progresses
enough so that everything that used to be GPL will be nicely GPL/BSD
dual-licensed, everything will be technically open-source on paper, but
noone will be able to get sources for anything anymore. That is exactly
what the BSD license allows.
--
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 29+ messages in thread
* [U-Boot] [PATCH] drivers/ddr/fsl: Dual-license DDR driver
2018-02-13 16:30 ` York Sun
` (2 preceding siblings ...)
2018-02-13 17:07 ` Marek Vasut
@ 2018-02-13 17:11 ` York Sun
2018-02-13 17:32 ` Wolfgang Denk
` (4 subsequent siblings)
8 siblings, 0 replies; 29+ messages in thread
From: York Sun @ 2018-02-13 17:11 UTC (permalink / raw)
To: u-boot
On 02/13/2018 08:35 AM, York Sun wrote:
> On 02/13/2018 04:49 AM, Wolfgang Denk wrote:
>> Dear York,
>>
>> In message <VI1PR04MB20785EF7D2578E39C048EE219AF70@VI1PR04MB2078.eurprd04.prod.outlook.com> you wrote:
>>>
>>> Nobody said anything. Some addresses bounced. And most changes made out
>>> people outside Freescale/NXP are minor changes, except twice the files
>>> were moved during U-Boot structure change. What options do I have?
>>
>> Ask all people who contributed to that code for their explicit
>> permission. Legally it is a huge difference between actively
>> confirming approval and not reacting at all.
>>
>
>
> All,
>
> If you haven't responded, please give your explicit approval to change
> Freescale DDR driver to dual-license so it can be re-used by other
> project(s) with BSD license. Here is the list I compiled from the git
> history. All commits made by Freescale/NXP employees are removed from
> this list.
>
>
Kyle,
Can you give your explicit approval for this change? These are the
changes you made:
a287963 - Kyle Moffett, Kyle.D.Moffett at boeing.com, 7 years ago :
fsl-ddr: Fix mixed-case macro names
c7fd27c - Kyle Moffett, Kyle.D.Moffett at boeing.com, 7 years ago :
mpc8xxx: DDR2/DDR3: Clean up DIMM-type switch statements
e820a13 - Kyle Moffett, Kyle.D.Moffett at boeing.com, 7 years ago :
fsl_ddr: Don't use full 64-bit divides on 32-bit PowerPC
Thanks.
York
^ permalink raw reply [flat|nested] 29+ messages in thread* [U-Boot] [PATCH] drivers/ddr/fsl: Dual-license DDR driver
2018-02-13 16:30 ` York Sun
` (3 preceding siblings ...)
2018-02-13 17:11 ` York Sun
@ 2018-02-13 17:32 ` Wolfgang Denk
2018-02-13 17:43 ` Heinrich Schuchardt
` (3 subsequent siblings)
8 siblings, 0 replies; 29+ messages in thread
From: Wolfgang Denk @ 2018-02-13 17:32 UTC (permalink / raw)
To: u-boot
Dear York,
In message <VI1PR04MB2078F6101F6100B572C602C89AF60@VI1PR04MB2078.eurprd04.prod.outlook.com> you wrote:
>
> > Ask all people who contributed to that code for their explicit
> > permission. Legally it is a huge difference between actively
> > confirming approval and not reacting at all.
...
> 1a45966 - Wolfgang Denk, wd at denx.de, 4 years, 7 months ago : Add
> GPL-2.0+ SPDX-License-Identifier to source files
I did not contribute any code here; the change is supposed to be
technically and legally a no-op. Thus I am not in a position to
make any license claims.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Include the success of others in your dreams for your own success.
^ permalink raw reply [flat|nested] 29+ messages in thread* [U-Boot] [PATCH] drivers/ddr/fsl: Dual-license DDR driver
2018-02-13 16:30 ` York Sun
` (4 preceding siblings ...)
2018-02-13 17:32 ` Wolfgang Denk
@ 2018-02-13 17:43 ` Heinrich Schuchardt
2018-02-13 19:51 ` Sebastien
` (2 subsequent siblings)
8 siblings, 0 replies; 29+ messages in thread
From: Heinrich Schuchardt @ 2018-02-13 17:43 UTC (permalink / raw)
To: u-boot
On 02/13/2018 05:30 PM, York Sun wrote:
> On 02/13/2018 04:49 AM, Wolfgang Denk wrote:
>> Dear York,
>>
>> In message <VI1PR04MB20785EF7D2578E39C048EE219AF70@VI1PR04MB2078.eurprd04.prod.outlook.com> you wrote:
>>>
>>> Nobody said anything. Some addresses bounced. And most changes made out
>>> people outside Freescale/NXP are minor changes, except twice the files
>>> were moved during U-Boot structure change. What options do I have?
>>
>> Ask all people who contributed to that code for their explicit
>> permission. Legally it is a huge difference between actively
>> confirming approval and not reacting at all.
>>
>
>
> All,
>
> If you haven't responded, please give your explicit approval to change
> Freescale DDR driver to dual-license so it can be re-used by other
> project(s) with BSD license. Here is the list I compiled from the git
> history. All commits made by Freescale/NXP employees are removed from
> this list.
>
>
> 00caae6 - Simon Glass, sjg at chromium.org, 6 months ago : env: Rename
> getenv/_f() to env_get()
> 457e51c - Simon Glass, sjg at chromium.org, 9 months ago : common: arm:
> freescale: layerscape: Move header files out of common.h
> 6e2941d - Simon Glass, sjg at chromium.org, 9 months ago : common:
> freescale: Move arch-specific declarations
> 3c476d8 - Tom Rini, trini at konsulko.com, 10 months ago : Merge
> git://git.denx.de/u-boot-fsl-qoriq
> 0e0de24 - xypron.glpk at gmx.de, xypron.glpk at gmx.de, 10 months ago : ddr:
A single line correction certainly does not deserve copyright. So I
won't stop this change.
I can understand that NXP wants to save double work. In general I prefer
GPL as a license for U-Boot because it requires that source code changes
are made available on request.
Regards
Heinrich
> fsl: incorrect logical constraint in populate_memctl_options
> 97fbf26 - Thomas Schaefer, thomas.schaefer at kontron.com, 11 months ago :
> drivers: ddr: fsl: fix unused-const-variable warnings
> f1683aa - Simon Glass, sjg at chromium.org, 10 months ago : board_f: Rename
> initdram() to dram_init()
> 3eace37 - Simon Glass, sjg at chromium.org, 10 months ago : arm: freescale:
> Rename initdram() to fsl_initdram()
> 088454c - Simon Glass, sjg at chromium.org, 11 months ago : board_f: Drop
> return value from initdram()
> cbe7706 - Tom Rini, trini at konsulko.com, 1 year, 5 months ago : Merge
> git://git.denx.de/u-boot-fsl-qoriq
> a4ca379 - Masahiro Yamada, yamada.masahiro at socionext.com, 1 year, 5
> months ago : drivers: squash lines for immediate return
> 62a3b7d - Robert P. J. Day, rpjday at crashcourse.ca, 1 year, 7 months ago
> : Various, unrelated tree-wide typo fixes.
> dd8d8da - Alexander Merkle, alexander.merkle at lauterbach.com, 1 year, 11
> months ago : Fix typo choosen in comments and printf logs
> 5b8031c - Tom Rini, trini at konsulko.com, 2 years, 1 month ago : Add more
> SPDX-License-Identifier tags
> da58dec - Tom Rini, trini at konsulko.com, 2 years, 3 months ago : Various
> Makefiles: Add SPDX-License-Identifier tags
> e368c20 - Joakim Tjernlund, joakim.tjernlund at transmode.se, 2 years, 4
> months ago : drivers/ddr/fsl_ddr: Make SR_IE configurable
> d7c865b - Curt Brune, curt at cumulusnetworks.com, 3 years ago :
> MPC8541/MPC8555: Enable SS_EN in DDR_SDRAM_CLK_CNLT register
> b414119 - Masahiro Yamada, yamada.m at jp.panasonic.com, 3 years, 3 months
> ago : linux/kernel.h: sync min, max, min3, max3 macros with Linux
> e1bf824 - Simon Glass, sjg at chromium.org, 3 years, 10 months ago : Add
> cli_ prefix to readline functions
> 18d6653 - Simon Glass, sjg at chromium.org, 3 years, 10 months ago : move
> CLI prototypes to cli.h and add comments
> 06c1411 - Masahiro Yamada, yamada.m at jp.panasonic.com, 4 years, 4 months
> ago : powerpc: convert makefiles to Kbuild style
> 7e157b0 - Valentin Longchamp, valentin.longchamp at keymile.com, 4 years, 4
> months ago : mpc8xxx: set x2 DDR3 refresh rate if SPD config requires it
> 0778bbe - Valentin Longchamp, valentin.longchamp at keymile.com, 4 years, 4
> months ago : mpc8xxx: call i2c_set_bus_num in __get_spd
> 2f848f9 - Shruti Kanetkar, Shruti at Freescale.com, 4 years, 6 months ago :
> powerpc: Use print_size() where appropriate
> 1a45966 - Wolfgang Denk, wd at denx.de, 4 years, 7 months ago : Add
> GPL-2.0+ SPDX-License-Identifier to source files
> 5b93394 - Anatolij Gustschin, agust at denx.de, 5 years ago : mpc8xxx: fix
> DDR init value to use CONFIG_MEM_INIT_VALUE
> 411e150 - Kumar Gala, galak at kernel.crashing.org, 6 years ago :
> arch/powerpc/cpu/mpc8xxx/ddr/interactive.c: Fix GCC 4.6 build warning
> 2f3a71f - Ira W. Snyder, iws at ovro.caltech.edu, 6 years ago : mpc8xxx:
> update module_type values from JEDEC DDR3 SPD Specification
> dea7f88 - Kumar Gala, galak at kernel.crashing.org, 6 years ago :
> arch/powerpc/cpu/mpc8xxx/ddr/ctrl_regs.c: Fix GCC 4.6 build warning
> 667bc17 - Kumar Gala, galak at kernel.crashing.org, 6 years ago :
> arch/powerpc/cpu/mpc8xxx/ddr/options.c: Fix GCC 4.6 build warning
> cd84b1f - Marek Vasut, marek.vasut at gmail.com, 6 years ago : GCC4.6:
> Squash warnings in ddr[123]_dimm_params.c
> a287963 - Kyle Moffett, Kyle.D.Moffett at boeing.com, 7 years ago :
> fsl-ddr: Fix mixed-case macro names
> c2a63f4 - Kumar Gala, galak at kernel.crashing.org, 7 years ago :
> powerpc/8xxx: Fix typo for address hashing message
> c7fd27c - Kyle Moffett, Kyle.D.Moffett at boeing.com, 7 years ago :
> mpc8xxx: DDR2/DDR3: Clean up DIMM-type switch statements
> e820a13 - Kyle Moffett, Kyle.D.Moffett at boeing.com, 7 years ago :
> fsl_ddr: Don't use full 64-bit divides on 32-bit PowerPC
> c39f44d - Kumar Gala, galak at kernel.crashing.org, 7 years ago :
> powerpc/8xxx: Refactor fsl_ddr_get_spd into common code from board
> 5df4b0a - Kumar Gala, galak at kernel.crashing.org, 7 years ago :
> powerpc/8xxx: Replace fsl_ddr_get_mem_data_rate with get_ddr_freq()
> 9296683 - Kumar Gala, galak at kernel.crashing.org, 7 years ago :
> powerpc/8xxx: Fix compile warning when build for a DDR1 or DDR2 board
> dd50af2 - Kumar Gala, galak at kernel.crashing.org, 7 years ago :
> powerpc/8xxx: Add hwconfig APIs to address early parsing used by DDR init
> 3dbd5d7 - Kumar Gala, galak at kernel.crashing.org, 7 years ago :
> powerpc/8xxx: Move fsl_is_spd() into generic 8xxx ddr code
> 7ea3871 - Becky Bruce, beckyb at kernel.crashing.org, 7 years ago : MPC8xxx
> DDR: align informational prints
> 6d8962e - Sebastien Carlier, sebastien.carlier at gmail.com, 7 years ago :
> Switch from archive libraries to partial linking
> 79e4e64 - Kumar Gala, galak at kernel.crashing.org, 8 years ago :
> powerpc/8xxx: Enabled hwconfig for memory interleaving
> a47a12b - Stefan Roese, sr at denx.de, 8 years ago : Move arch/ppc to
> arch/powerpc
> 8d1f268 - Peter Tyser, ptyser at xes-inc.com, 8 years ago : ppc: Move
> cpu/$CPU to arch/ppc/cpu/$CPU
>
> Thanks.
>
> York
>
^ permalink raw reply [flat|nested] 29+ messages in thread* [U-Boot] [PATCH] drivers/ddr/fsl: Dual-license DDR driver
2018-02-13 16:30 ` York Sun
` (5 preceding siblings ...)
2018-02-13 17:43 ` Heinrich Schuchardt
@ 2018-02-13 19:51 ` Sebastien
2018-02-13 21:39 ` Anatolij Gustschin
2018-02-14 7:38 ` Stefan Roese
8 siblings, 0 replies; 29+ messages in thread
From: Sebastien @ 2018-02-13 19:51 UTC (permalink / raw)
To: u-boot
The changes I contributed were to the build system (which has been replaced
since), so I make no license claims on this driver (or any of the u-boot
code).
On Tue, Feb 13, 2018 at 4:30 PM, York Sun <york.sun@nxp.com> wrote:
> On 02/13/2018 04:49 AM, Wolfgang Denk wrote:
> > Dear York,
> >
> > In message <VI1PR04MB20785EF7D2578E39C048EE219AF70@VI1PR04MB2078.
> eurprd04.prod.outlook.com> you wrote:
> >>
> >> Nobody said anything. Some addresses bounced. And most changes made out
> >> people outside Freescale/NXP are minor changes, except twice the files
> >> were moved during U-Boot structure change. What options do I have?
> >
> > Ask all people who contributed to that code for their explicit
> > permission. Legally it is a huge difference between actively
> > confirming approval and not reacting at all.
> >
>
>
> All,
>
> If you haven't responded, please give your explicit approval to change
> Freescale DDR driver to dual-license so it can be re-used by other
> project(s) with BSD license. Here is the list I compiled from the git
> history. All commits made by Freescale/NXP employees are removed from
> this list.
>
>
> 00caae6 - Simon Glass, sjg at chromium.org, 6 months ago : env: Rename
> getenv/_f() to env_get()
> 457e51c - Simon Glass, sjg at chromium.org, 9 months ago : common: arm:
> freescale: layerscape: Move header files out of common.h
> 6e2941d - Simon Glass, sjg at chromium.org, 9 months ago : common:
> freescale: Move arch-specific declarations
> 3c476d8 - Tom Rini, trini at konsulko.com, 10 months ago : Merge
> git://git.denx.de/u-boot-fsl-qoriq
> 0e0de24 - xypron.glpk at gmx.de, xypron.glpk at gmx.de, 10 months ago : ddr:
> fsl: incorrect logical constraint in populate_memctl_options
> 97fbf26 - Thomas Schaefer, thomas.schaefer at kontron.com, 11 months ago :
> drivers: ddr: fsl: fix unused-const-variable warnings
> f1683aa - Simon Glass, sjg at chromium.org, 10 months ago : board_f: Rename
> initdram() to dram_init()
> 3eace37 - Simon Glass, sjg at chromium.org, 10 months ago : arm: freescale:
> Rename initdram() to fsl_initdram()
> 088454c - Simon Glass, sjg at chromium.org, 11 months ago : board_f: Drop
> return value from initdram()
> cbe7706 - Tom Rini, trini at konsulko.com, 1 year, 5 months ago : Merge
> git://git.denx.de/u-boot-fsl-qoriq
> a4ca379 - Masahiro Yamada, yamada.masahiro at socionext.com, 1 year, 5
> months ago : drivers: squash lines for immediate return
> 62a3b7d - Robert P. J. Day, rpjday at crashcourse.ca, 1 year, 7 months ago
> : Various, unrelated tree-wide typo fixes.
> dd8d8da - Alexander Merkle, alexander.merkle at lauterbach.com, 1 year, 11
> months ago : Fix typo choosen in comments and printf logs
> 5b8031c - Tom Rini, trini at konsulko.com, 2 years, 1 month ago : Add more
> SPDX-License-Identifier tags
> da58dec - Tom Rini, trini at konsulko.com, 2 years, 3 months ago : Various
> Makefiles: Add SPDX-License-Identifier tags
> e368c20 - Joakim Tjernlund, joakim.tjernlund at transmode.se, 2 years, 4
> months ago : drivers/ddr/fsl_ddr: Make SR_IE configurable
> d7c865b - Curt Brune, curt at cumulusnetworks.com, 3 years ago :
> MPC8541/MPC8555: Enable SS_EN in DDR_SDRAM_CLK_CNLT register
> b414119 - Masahiro Yamada, yamada.m at jp.panasonic.com, 3 years, 3 months
> ago : linux/kernel.h: sync min, max, min3, max3 macros with Linux
> e1bf824 - Simon Glass, sjg at chromium.org, 3 years, 10 months ago : Add
> cli_ prefix to readline functions
> 18d6653 - Simon Glass, sjg at chromium.org, 3 years, 10 months ago : move
> CLI prototypes to cli.h and add comments
> 06c1411 - Masahiro Yamada, yamada.m at jp.panasonic.com, 4 years, 4 months
> ago : powerpc: convert makefiles to Kbuild style
> 7e157b0 - Valentin Longchamp, valentin.longchamp at keymile.com, 4 years, 4
> months ago : mpc8xxx: set x2 DDR3 refresh rate if SPD config requires it
> 0778bbe - Valentin Longchamp, valentin.longchamp at keymile.com, 4 years, 4
> months ago : mpc8xxx: call i2c_set_bus_num in __get_spd
> 2f848f9 - Shruti Kanetkar, Shruti at Freescale.com, 4 years, 6 months ago :
> powerpc: Use print_size() where appropriate
> 1a45966 - Wolfgang Denk, wd at denx.de, 4 years, 7 months ago : Add
> GPL-2.0+ SPDX-License-Identifier to source files
> 5b93394 - Anatolij Gustschin, agust at denx.de, 5 years ago : mpc8xxx: fix
> DDR init value to use CONFIG_MEM_INIT_VALUE
> 411e150 - Kumar Gala, galak at kernel.crashing.org, 6 years ago :
> arch/powerpc/cpu/mpc8xxx/ddr/interactive.c: Fix GCC 4.6 build warning
> 2f3a71f - Ira W. Snyder, iws at ovro.caltech.edu, 6 years ago : mpc8xxx:
> update module_type values from JEDEC DDR3 SPD Specification
> dea7f88 - Kumar Gala, galak at kernel.crashing.org, 6 years ago :
> arch/powerpc/cpu/mpc8xxx/ddr/ctrl_regs.c: Fix GCC 4.6 build warning
> 667bc17 - Kumar Gala, galak at kernel.crashing.org, 6 years ago :
> arch/powerpc/cpu/mpc8xxx/ddr/options.c: Fix GCC 4.6 build warning
> cd84b1f - Marek Vasut, marek.vasut at gmail.com, 6 years ago : GCC4.6:
> Squash warnings in ddr[123]_dimm_params.c
> a287963 - Kyle Moffett, Kyle.D.Moffett at boeing.com, 7 years ago :
> fsl-ddr: Fix mixed-case macro names
> c2a63f4 - Kumar Gala, galak at kernel.crashing.org, 7 years ago :
> powerpc/8xxx: Fix typo for address hashing message
> c7fd27c - Kyle Moffett, Kyle.D.Moffett at boeing.com, 7 years ago :
> mpc8xxx: DDR2/DDR3: Clean up DIMM-type switch statements
> e820a13 - Kyle Moffett, Kyle.D.Moffett at boeing.com, 7 years ago :
> fsl_ddr: Don't use full 64-bit divides on 32-bit PowerPC
> c39f44d - Kumar Gala, galak at kernel.crashing.org, 7 years ago :
> powerpc/8xxx: Refactor fsl_ddr_get_spd into common code from board
> 5df4b0a - Kumar Gala, galak at kernel.crashing.org, 7 years ago :
> powerpc/8xxx: Replace fsl_ddr_get_mem_data_rate with get_ddr_freq()
> 9296683 - Kumar Gala, galak at kernel.crashing.org, 7 years ago :
> powerpc/8xxx: Fix compile warning when build for a DDR1 or DDR2 board
> dd50af2 - Kumar Gala, galak at kernel.crashing.org, 7 years ago :
> powerpc/8xxx: Add hwconfig APIs to address early parsing used by DDR init
> 3dbd5d7 - Kumar Gala, galak at kernel.crashing.org, 7 years ago :
> powerpc/8xxx: Move fsl_is_spd() into generic 8xxx ddr code
> 7ea3871 - Becky Bruce, beckyb at kernel.crashing.org, 7 years ago : MPC8xxx
> DDR: align informational prints
> 6d8962e - Sebastien Carlier, sebastien.carlier at gmail.com, 7 years ago :
> Switch from archive libraries to partial linking
> 79e4e64 - Kumar Gala, galak at kernel.crashing.org, 8 years ago :
> powerpc/8xxx: Enabled hwconfig for memory interleaving
> a47a12b - Stefan Roese, sr at denx.de, 8 years ago : Move arch/ppc to
> arch/powerpc
> 8d1f268 - Peter Tyser, ptyser at xes-inc.com, 8 years ago : ppc: Move
> cpu/$CPU to arch/ppc/cpu/$CPU
>
> Thanks.
>
> York
>
^ permalink raw reply [flat|nested] 29+ messages in thread* [U-Boot] [PATCH] drivers/ddr/fsl: Dual-license DDR driver
2018-02-13 16:30 ` York Sun
` (6 preceding siblings ...)
2018-02-13 19:51 ` Sebastien
@ 2018-02-13 21:39 ` Anatolij Gustschin
2018-02-14 7:38 ` Stefan Roese
8 siblings, 0 replies; 29+ messages in thread
From: Anatolij Gustschin @ 2018-02-13 21:39 UTC (permalink / raw)
To: u-boot
Hi York,
On Tue, 13 Feb 2018 16:30:58 +0000
York Sun york.sun at nxp.com wrote:
...
> 5b93394 - Anatolij Gustschin, agust at denx.de, 5 years ago : mpc8xxx: fix
> DDR init value to use CONFIG_MEM_INIT_VALUE
My small fix surely doesn't justify copyright claims on this driver,
so I can't stop this change.
--
Anatolij
^ permalink raw reply [flat|nested] 29+ messages in thread* [U-Boot] [PATCH] drivers/ddr/fsl: Dual-license DDR driver
2018-02-13 16:30 ` York Sun
` (7 preceding siblings ...)
2018-02-13 21:39 ` Anatolij Gustschin
@ 2018-02-14 7:38 ` Stefan Roese
8 siblings, 0 replies; 29+ messages in thread
From: Stefan Roese @ 2018-02-14 7:38 UTC (permalink / raw)
To: u-boot
On 13.02.2018 17:30, York Sun wrote:
> On 02/13/2018 04:49 AM, Wolfgang Denk wrote:
>> Dear York,
>>
>> In message <VI1PR04MB20785EF7D2578E39C048EE219AF70@VI1PR04MB2078.eurprd04.prod.outlook.com> you wrote:
>>>
>>> Nobody said anything. Some addresses bounced. And most changes made out
>>> people outside Freescale/NXP are minor changes, except twice the files
>>> were moved during U-Boot structure change. What options do I have?
>>
>> Ask all people who contributed to that code for their explicit
>> permission. Legally it is a huge difference between actively
>> confirming approval and not reacting at all.
>>
>
>
> All,
>
> If you haven't responded, please give your explicit approval to change
> Freescale DDR driver to dual-license so it can be re-used by other
> project(s) with BSD license. Here is the list I compiled from the git
> history. All commits made by Freescale/NXP employees are removed from
> this list.
>
>
> 00caae6 - Simon Glass, sjg at chromium.org, 6 months ago : env: Rename
> getenv/_f() to env_get()
> 457e51c - Simon Glass, sjg at chromium.org, 9 months ago : common: arm:
> freescale: layerscape: Move header files out of common.h
> 6e2941d - Simon Glass, sjg at chromium.org, 9 months ago : common:
> freescale: Move arch-specific declarations
> 3c476d8 - Tom Rini, trini at konsulko.com, 10 months ago : Merge
> git://git.denx.de/u-boot-fsl-qoriq
> 0e0de24 - xypron.glpk at gmx.de, xypron.glpk at gmx.de, 10 months ago : ddr:
> fsl: incorrect logical constraint in populate_memctl_options
> 97fbf26 - Thomas Schaefer, thomas.schaefer at kontron.com, 11 months ago :
> drivers: ddr: fsl: fix unused-const-variable warnings
> f1683aa - Simon Glass, sjg at chromium.org, 10 months ago : board_f: Rename
> initdram() to dram_init()
> 3eace37 - Simon Glass, sjg at chromium.org, 10 months ago : arm: freescale:
> Rename initdram() to fsl_initdram()
> 088454c - Simon Glass, sjg at chromium.org, 11 months ago : board_f: Drop
> return value from initdram()
> cbe7706 - Tom Rini, trini at konsulko.com, 1 year, 5 months ago : Merge
> git://git.denx.de/u-boot-fsl-qoriq
> a4ca379 - Masahiro Yamada, yamada.masahiro at socionext.com, 1 year, 5
> months ago : drivers: squash lines for immediate return
> 62a3b7d - Robert P. J. Day, rpjday at crashcourse.ca, 1 year, 7 months ago
> : Various, unrelated tree-wide typo fixes.
> dd8d8da - Alexander Merkle, alexander.merkle at lauterbach.com, 1 year, 11
> months ago : Fix typo choosen in comments and printf logs
> 5b8031c - Tom Rini, trini at konsulko.com, 2 years, 1 month ago : Add more
> SPDX-License-Identifier tags
> da58dec - Tom Rini, trini at konsulko.com, 2 years, 3 months ago : Various
> Makefiles: Add SPDX-License-Identifier tags
> e368c20 - Joakim Tjernlund, joakim.tjernlund at transmode.se, 2 years, 4
> months ago : drivers/ddr/fsl_ddr: Make SR_IE configurable
> d7c865b - Curt Brune, curt at cumulusnetworks.com, 3 years ago :
> MPC8541/MPC8555: Enable SS_EN in DDR_SDRAM_CLK_CNLT register
> b414119 - Masahiro Yamada, yamada.m at jp.panasonic.com, 3 years, 3 months
> ago : linux/kernel.h: sync min, max, min3, max3 macros with Linux
> e1bf824 - Simon Glass, sjg at chromium.org, 3 years, 10 months ago : Add
> cli_ prefix to readline functions
> 18d6653 - Simon Glass, sjg at chromium.org, 3 years, 10 months ago : move
> CLI prototypes to cli.h and add comments
> 06c1411 - Masahiro Yamada, yamada.m at jp.panasonic.com, 4 years, 4 months
> ago : powerpc: convert makefiles to Kbuild style
> 7e157b0 - Valentin Longchamp, valentin.longchamp at keymile.com, 4 years, 4
> months ago : mpc8xxx: set x2 DDR3 refresh rate if SPD config requires it
> 0778bbe - Valentin Longchamp, valentin.longchamp at keymile.com, 4 years, 4
> months ago : mpc8xxx: call i2c_set_bus_num in __get_spd
> 2f848f9 - Shruti Kanetkar, Shruti at Freescale.com, 4 years, 6 months ago :
> powerpc: Use print_size() where appropriate
> 1a45966 - Wolfgang Denk, wd at denx.de, 4 years, 7 months ago : Add
> GPL-2.0+ SPDX-License-Identifier to source files
> 5b93394 - Anatolij Gustschin, agust at denx.de, 5 years ago : mpc8xxx: fix
> DDR init value to use CONFIG_MEM_INIT_VALUE
> 411e150 - Kumar Gala, galak at kernel.crashing.org, 6 years ago :
> arch/powerpc/cpu/mpc8xxx/ddr/interactive.c: Fix GCC 4.6 build warning
> 2f3a71f - Ira W. Snyder, iws at ovro.caltech.edu, 6 years ago : mpc8xxx:
> update module_type values from JEDEC DDR3 SPD Specification
> dea7f88 - Kumar Gala, galak at kernel.crashing.org, 6 years ago :
> arch/powerpc/cpu/mpc8xxx/ddr/ctrl_regs.c: Fix GCC 4.6 build warning
> 667bc17 - Kumar Gala, galak at kernel.crashing.org, 6 years ago :
> arch/powerpc/cpu/mpc8xxx/ddr/options.c: Fix GCC 4.6 build warning
> cd84b1f - Marek Vasut, marek.vasut at gmail.com, 6 years ago : GCC4.6:
> Squash warnings in ddr[123]_dimm_params.c
> a287963 - Kyle Moffett, Kyle.D.Moffett at boeing.com, 7 years ago :
> fsl-ddr: Fix mixed-case macro names
> c2a63f4 - Kumar Gala, galak at kernel.crashing.org, 7 years ago :
> powerpc/8xxx: Fix typo for address hashing message
> c7fd27c - Kyle Moffett, Kyle.D.Moffett at boeing.com, 7 years ago :
> mpc8xxx: DDR2/DDR3: Clean up DIMM-type switch statements
> e820a13 - Kyle Moffett, Kyle.D.Moffett at boeing.com, 7 years ago :
> fsl_ddr: Don't use full 64-bit divides on 32-bit PowerPC
> c39f44d - Kumar Gala, galak at kernel.crashing.org, 7 years ago :
> powerpc/8xxx: Refactor fsl_ddr_get_spd into common code from board
> 5df4b0a - Kumar Gala, galak at kernel.crashing.org, 7 years ago :
> powerpc/8xxx: Replace fsl_ddr_get_mem_data_rate with get_ddr_freq()
> 9296683 - Kumar Gala, galak at kernel.crashing.org, 7 years ago :
> powerpc/8xxx: Fix compile warning when build for a DDR1 or DDR2 board
> dd50af2 - Kumar Gala, galak at kernel.crashing.org, 7 years ago :
> powerpc/8xxx: Add hwconfig APIs to address early parsing used by DDR init
> 3dbd5d7 - Kumar Gala, galak at kernel.crashing.org, 7 years ago :
> powerpc/8xxx: Move fsl_is_spd() into generic 8xxx ddr code
> 7ea3871 - Becky Bruce, beckyb at kernel.crashing.org, 7 years ago : MPC8xxx
> DDR: align informational prints
> 6d8962e - Sebastien Carlier, sebastien.carlier at gmail.com, 7 years ago :
> Switch from archive libraries to partial linking
> 79e4e64 - Kumar Gala, galak at kernel.crashing.org, 8 years ago :
> powerpc/8xxx: Enabled hwconfig for memory interleaving
> a47a12b - Stefan Roese, sr at denx.de, 8 years ago : Move arch/ppc to
> arch/powerpc
Its "only" a file move without real code contribution, so I'm not in
the position to make any license claims.
Thanks,
Stefan
^ permalink raw reply [flat|nested] 29+ messages in thread