From: Tony Lindgren <tony@atomide.com>
To: Aaro Koskinen <aaro.koskinen@iki.fi>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>,
Paul Walmsley <paul@pwsan.com>,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-clk@vger.kernel.org
Subject: Re: [PATCH] ARM: OMAP: clock: Fix debugfs_create_*() usage
Date: Wed, 14 Feb 2018 08:22:10 -0800 [thread overview]
Message-ID: <20180214162210.GG6364@atomide.com> (raw)
In-Reply-To: <20180109173734.tplddyd4d3akrzjr@darkstar.musicnaut.iki.fi>
* Aaro Koskinen <aaro.koskinen@iki.fi> [180109 17:40]:
> Hi,
>
> On Tue, Jan 02, 2018 at 04:25:35PM +0100, Geert Uytterhoeven wrote:
> > When exposing data access through debugfs, the correct
> > debugfs_create_*() functions must be used, depending on data type.
> >
> > Remove all casts from data pointers passed to debugfs_create_*()
> > functions, as such casts prevent the compiler from flagging bugs.
> >
> > Correct all wrong usage:
> > - clk.rate is unsigned long, not u32,
> > - clk.flags is u8, not u32, which exposed the successive
> > clk.rate_offset and clk.src_offset fields.
> >
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> Acked-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Applying into omap-for-v4.16/fixes thanks.
Tony
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: OMAP: clock: Fix debugfs_create_*() usage
Date: Wed, 14 Feb 2018 08:22:10 -0800 [thread overview]
Message-ID: <20180214162210.GG6364@atomide.com> (raw)
In-Reply-To: <20180109173734.tplddyd4d3akrzjr@darkstar.musicnaut.iki.fi>
* Aaro Koskinen <aaro.koskinen@iki.fi> [180109 17:40]:
> Hi,
>
> On Tue, Jan 02, 2018 at 04:25:35PM +0100, Geert Uytterhoeven wrote:
> > When exposing data access through debugfs, the correct
> > debugfs_create_*() functions must be used, depending on data type.
> >
> > Remove all casts from data pointers passed to debugfs_create_*()
> > functions, as such casts prevent the compiler from flagging bugs.
> >
> > Correct all wrong usage:
> > - clk.rate is unsigned long, not u32,
> > - clk.flags is u8, not u32, which exposed the successive
> > clk.rate_offset and clk.src_offset fields.
> >
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> Acked-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Applying into omap-for-v4.16/fixes thanks.
Tony
next prev parent reply other threads:[~2018-02-14 16:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-02 15:25 [PATCH] ARM: OMAP: clock: Fix debugfs_create_*() usage Geert Uytterhoeven
2018-01-02 15:25 ` Geert Uytterhoeven
2018-01-09 17:37 ` Aaro Koskinen
2018-01-09 17:37 ` Aaro Koskinen
2018-01-09 17:37 ` Aaro Koskinen
2018-02-14 16:22 ` Tony Lindgren [this message]
2018-02-14 16:22 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180214162210.GG6364@atomide.com \
--to=tony@atomide.com \
--cc=aaro.koskinen@iki.fi \
--cc=geert+renesas@glider.be \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.