From: acme@kernel.org (Arnaldo Carvalho de Melo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] perf inject: Emit instruction records on ETM trace discontinuity
Date: Thu, 15 Feb 2018 11:57:14 -0300 [thread overview]
Message-ID: <20180215145714.GE30974@kernel.org> (raw)
In-Reply-To: <20180213222233.GA23553@xps15>
Em Tue, Feb 13, 2018 at 03:22:33PM -0700, Mathieu Poirier escreveu:
> On Wed, Feb 07, 2018 at 01:57:25PM +0000, Robert Walker wrote:
> > @@ -946,20 +982,19 @@ static int cs_etm__run_decoder(struct cs_etm_queue *etmq)
> > /* Run trace decoder until buffer consumed or end of trace */
> > do {
> > processed = 0;
> > -
>
> this...
>
> > err = cs_etm_decoder__process_data_block(
> > etmq->decoder,
> > etmq->offset,
> > &buffer.buf[buffer_used],
> > buffer.len - buffer_used,
> > &processed);
> > -
>
> and this should have gone in the first patch.
>
> > if (err)
> > return err;
> >
> > etmq->offset += processed;
> > buffer_used += processed;
> >
> > + /* Process each packet in this chunk */
>
> And probably this too.
>
> With the above changes:
>
> Acked-by: Mathieu Poirier <mathieu.poirier@linaro.org>
Hi Robert,
Can you please address Mathieu's comments, and if you agree with
them, resubmit?
Thanks!
- Arnaldo
WARNING: multiple messages have this Message-ID (diff)
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: Robert Walker <robert.walker@arm.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, coresight@lists.linaro.org
Subject: Re: [PATCH 2/2] perf inject: Emit instruction records on ETM trace discontinuity
Date: Thu, 15 Feb 2018 11:57:14 -0300 [thread overview]
Message-ID: <20180215145714.GE30974@kernel.org> (raw)
In-Reply-To: <20180213222233.GA23553@xps15>
Em Tue, Feb 13, 2018 at 03:22:33PM -0700, Mathieu Poirier escreveu:
> On Wed, Feb 07, 2018 at 01:57:25PM +0000, Robert Walker wrote:
> > @@ -946,20 +982,19 @@ static int cs_etm__run_decoder(struct cs_etm_queue *etmq)
> > /* Run trace decoder until buffer consumed or end of trace */
> > do {
> > processed = 0;
> > -
>
> this...
>
> > err = cs_etm_decoder__process_data_block(
> > etmq->decoder,
> > etmq->offset,
> > &buffer.buf[buffer_used],
> > buffer.len - buffer_used,
> > &processed);
> > -
>
> and this should have gone in the first patch.
>
> > if (err)
> > return err;
> >
> > etmq->offset += processed;
> > buffer_used += processed;
> >
> > + /* Process each packet in this chunk */
>
> And probably this too.
>
> With the above changes:
>
> Acked-by: Mathieu Poirier <mathieu.poirier@linaro.org>
Hi Robert,
Can you please address Mathieu's comments, and if you agree with
them, resubmit?
Thanks!
- Arnaldo
next prev parent reply other threads:[~2018-02-15 14:57 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-07 13:57 [PATCH 0/2] Perf inject for ETM trace Robert Walker
2018-02-07 13:57 ` Robert Walker
2018-02-07 13:57 ` [PATCH 1/2] perf tools: inject capabilitity for CoreSight traces Robert Walker
2018-02-07 13:57 ` Robert Walker
2018-02-13 22:18 ` Mathieu Poirier
2018-02-13 22:18 ` Mathieu Poirier
2018-02-15 14:58 ` Arnaldo Carvalho de Melo
2018-02-15 14:58 ` Arnaldo Carvalho de Melo
2018-02-07 13:57 ` [PATCH 2/2] perf inject: Emit instruction records on ETM trace discontinuity Robert Walker
2018-02-07 13:57 ` Robert Walker
2018-02-13 22:22 ` Mathieu Poirier
2018-02-13 22:22 ` Mathieu Poirier
2018-02-15 14:57 ` Arnaldo Carvalho de Melo [this message]
2018-02-15 14:57 ` Arnaldo Carvalho de Melo
2018-02-15 15:22 ` Robert Walker
2018-02-15 15:22 ` Robert Walker
2018-02-15 17:08 ` 'Arnaldo Carvalho de Melo'
2018-02-15 17:08 ` 'Arnaldo Carvalho de Melo'
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180215145714.GE30974@kernel.org \
--to=acme@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.