[PATCH] staging: rtl8188eu: Fix "Missing a blank line after declaration".

[PATCH] staging: rtl8188eu: Fix "Missing a blank line after declaration".

[Dafna Hirschfeld]

Fix checkpatch.pl "missing a blank line after declaration" warning message from rtl8188eu module.

Signed-off-by: Dafna Hirschfeld <dafna3@gmail.com>
---

text here is ignored by git tools.

 drivers/staging/rtl8188eu/hal/usb_halinit.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8188eu/hal/usb_halinit.c b/drivers/staging/rtl8188eu/hal/usb_halinit.c
index 17967c9..c3bb183 100644
--- a/drivers/staging/rtl8188eu/hal/usb_halinit.c
+++ b/drivers/staging/rtl8188eu/hal/usb_halinit.c
@@ -1516,8 +1516,8 @@ void rtw_hal_set_hwreg(struct adapter *Adapter, u8 variable, u8 *val)
 	case HW_VAR_CAM_WRITE:
 		{
 			u32 cmd;
-
 			u32 *cam_val = (u32 *)val;
+
 			usb_write32(Adapter, WCAMI, cam_val[0]);
 
 			cmd = CAM_POLLINIG | CAM_WRITE | cam_val[1];
-- 
2.7.4

Re: [Outreachy kernel] [PATCH] staging: rtl8188eu: Fix "Missing a blank line after declaration".

[Julia Lawall]

Thanks for your patch, the first one submitted in this round :)

On Thu, 15 Feb 2018, Dafna Hirschfeld wrote:

> Fix checkpatch.pl "missing a blank line after declaration" warning message from rtl8188eu module.

Your commit log message needs to stay within around 70 characters, so that
it is within 80 when it gets slightly indented by git.

The subject line and the commit message should say what you have done and
why, rather than just saying what you fixed, which could be done in many
ways.  A subject line could be "Move a blank line" and the commit log
message could be

Move a blank line from in the middle of a declaration list to after the
declaration list, to improve readability.

Problem detected using checkpatch.

Please send a v2.

julia

>
> Signed-off-by: Dafna Hirschfeld <dafna3@gmail.com>
> ---
>
> text here is ignored by git tools.
>
>  drivers/staging/rtl8188eu/hal/usb_halinit.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8188eu/hal/usb_halinit.c b/drivers/staging/rtl8188eu/hal/usb_halinit.c
> index 17967c9..c3bb183 100644
> --- a/drivers/staging/rtl8188eu/hal/usb_halinit.c
> +++ b/drivers/staging/rtl8188eu/hal/usb_halinit.c
> @@ -1516,8 +1516,8 @@ void rtw_hal_set_hwreg(struct adapter *Adapter, u8 variable, u8 *val)
>  	case HW_VAR_CAM_WRITE:
>  		{
>  			u32 cmd;
> -
>  			u32 *cam_val = (u32 *)val;
> +
>  			usb_write32(Adapter, WCAMI, cam_val[0]);
>
>  			cmd = CAM_POLLINIG | CAM_WRITE | cam_val[1];
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20180215183900.GA12122%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>