[PATCH] arm64: Fix compilation error while accessing MPIDR_HWID

All of lore.kernel.org
 help / color / mirror / Atom feed

* [PATCH] arm64: Fix compilation error while accessing MPIDR_HWID_BITMASK from .S files
@ 2018-02-19  6:39 ` Bhupesh Sharma
  0 siblings, 0 replies; 20+ messages in thread
From: Bhupesh Sharma @ 2018-02-19  6:39 UTC (permalink / raw)
  To: linux-arm-kernel

Since commit e1a50de37860b3a93a9d643b09638db5aff47650 (arm64: cputype:
Silence Sparse warnings), compilation of arm64 architecture is broken
with the following error messages:

  AR      arch/arm64/kernel/built-in.o
  arch/arm64/kernel/head.S: Assembler messages:
  arch/arm64/kernel/head.S:677: Error: found 'L', expected: ')'
  arch/arm64/kernel/head.S:677: Error: found 'L', expected: ')'
  arch/arm64/kernel/head.S:677: Error: found 'L', expected: ')'
  arch/arm64/kernel/head.S:677: Error: junk at end of line, first
  unrecognized character is `L'
  arch/arm64/kernel/head.S:677: Error: unexpected characters following
  instruction at operand 2 -- `movz x1,:abs_g1_s:0xff00ffffffUL'
  arch/arm64/kernel/head.S:677: Error: unexpected characters following
  instruction at operand 2 -- `movk x1,:abs_g0_nc:0xff00ffffffUL'

This patch fixes the same by using the UL() macro correctly for
assigning the MPIDR_HWID_BITMASK macro value.

Signed-off-by: Bhupesh Sharma <bhsharma@redhat.com>
---
 arch/arm64/include/asm/cputype.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/include/asm/cputype.h b/arch/arm64/include/asm/cputype.h
index eda8c5f629fc..350c76a1d15b 100644
--- a/arch/arm64/include/asm/cputype.h
+++ b/arch/arm64/include/asm/cputype.h
@@ -20,7 +20,7 @@
 
 #define MPIDR_UP_BITMASK	(0x1 << 30)
 #define MPIDR_MT_BITMASK	(0x1 << 24)
-#define MPIDR_HWID_BITMASK	0xff00ffffffUL
+#define MPIDR_HWID_BITMASK	UL(0xff00ffffff)
 
 #define MPIDR_LEVEL_BITS_SHIFT	3
 #define MPIDR_LEVEL_BITS	(1 << MPIDR_LEVEL_BITS_SHIFT)
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 20+ messages in thread

* [PATCH] arm64: Fix compilation error while accessing MPIDR_HWID_BITMASK from .S files
@ 2018-02-19  6:39 ` Bhupesh Sharma
  0 siblings, 0 replies; 20+ messages in thread
From: Bhupesh Sharma @ 2018-02-19  6:39 UTC (permalink / raw)
  To: linux-arm-kernel, linux-kernel; +Cc: bhsharma, bhupesh.linux

Since commit e1a50de37860b3a93a9d643b09638db5aff47650 (arm64: cputype:
Silence Sparse warnings), compilation of arm64 architecture is broken
with the following error messages:

  AR      arch/arm64/kernel/built-in.o
  arch/arm64/kernel/head.S: Assembler messages:
  arch/arm64/kernel/head.S:677: Error: found 'L', expected: ')'
  arch/arm64/kernel/head.S:677: Error: found 'L', expected: ')'
  arch/arm64/kernel/head.S:677: Error: found 'L', expected: ')'
  arch/arm64/kernel/head.S:677: Error: junk at end of line, first
  unrecognized character is `L'
  arch/arm64/kernel/head.S:677: Error: unexpected characters following
  instruction at operand 2 -- `movz x1,:abs_g1_s:0xff00ffffffUL'
  arch/arm64/kernel/head.S:677: Error: unexpected characters following
  instruction at operand 2 -- `movk x1,:abs_g0_nc:0xff00ffffffUL'

This patch fixes the same by using the UL() macro correctly for
assigning the MPIDR_HWID_BITMASK macro value.

Signed-off-by: Bhupesh Sharma <bhsharma@redhat.com>
---
 arch/arm64/include/asm/cputype.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/include/asm/cputype.h b/arch/arm64/include/asm/cputype.h
index eda8c5f629fc..350c76a1d15b 100644
--- a/arch/arm64/include/asm/cputype.h
+++ b/arch/arm64/include/asm/cputype.h
@@ -20,7 +20,7 @@
 
 #define MPIDR_UP_BITMASK	(0x1 << 30)
 #define MPIDR_MT_BITMASK	(0x1 << 24)
-#define MPIDR_HWID_BITMASK	0xff00ffffffUL
+#define MPIDR_HWID_BITMASK	UL(0xff00ffffff)
 
 #define MPIDR_LEVEL_BITS_SHIFT	3
 #define MPIDR_LEVEL_BITS	(1 << MPIDR_LEVEL_BITS_SHIFT)
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 20+ messages in thread

* [PATCH] arm64: Fix compilation error while accessing MPIDR_HWID_BITMASK from .S files
  2018-02-19  6:39 ` Bhupesh Sharma
@ 2018-02-19 10:19   ` John Garry
  -1 siblings, 0 replies; 20+ messages in thread
From: John Garry @ 2018-02-19 10:19 UTC (permalink / raw)
  To: linux-arm-kernel

On 19/02/2018 06:39, Bhupesh Sharma wrote:
> Since commit e1a50de37860b3a93a9d643b09638db5aff47650 (arm64: cputype:
> Silence Sparse warnings), compilation of arm64 architecture is broken
> with the following error messages:
>
>   AR      arch/arm64/kernel/built-in.o
>   arch/arm64/kernel/head.S: Assembler messages:
>   arch/arm64/kernel/head.S:677: Error: found 'L', expected: ')'
>   arch/arm64/kernel/head.S:677: Error: found 'L', expected: ')'
>   arch/arm64/kernel/head.S:677: Error: found 'L', expected: ')'
>   arch/arm64/kernel/head.S:677: Error: junk at end of line, first
>   unrecognized character is `L'
>   arch/arm64/kernel/head.S:677: Error: unexpected characters following
>   instruction at operand 2 -- `movz x1,:abs_g1_s:0xff00ffffffUL'
>   arch/arm64/kernel/head.S:677: Error: unexpected characters following
>   instruction at operand 2 -- `movk x1,:abs_g0_nc:0xff00ffffffUL'
>
> This patch fixes the same by using the UL() macro correctly for
> assigning the MPIDR_HWID_BITMASK macro value.
>
> Signed-off-by: Bhupesh Sharma <bhsharma@redhat.com>
> ---
>  arch/arm64/include/asm/cputype.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/include/asm/cputype.h b/arch/arm64/include/asm/cputype.h
> index eda8c5f629fc..350c76a1d15b 100644
> --- a/arch/arm64/include/asm/cputype.h
> +++ b/arch/arm64/include/asm/cputype.h
> @@ -20,7 +20,7 @@
>
>  #define MPIDR_UP_BITMASK	(0x1 << 30)
>  #define MPIDR_MT_BITMASK	(0x1 << 24)
> -#define MPIDR_HWID_BITMASK	0xff00ffffffUL
> +#define MPIDR_HWID_BITMASK	UL(0xff00ffffff)

Works for me.

FYI, I am using (old) gcc-linaro-4.8-2015.06-x86_64_aarch64.

Thanks,
John

>
>  #define MPIDR_LEVEL_BITS_SHIFT	3
>  #define MPIDR_LEVEL_BITS	(1 << MPIDR_LEVEL_BITS_SHIFT)
>

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [PATCH] arm64: Fix compilation error while accessing MPIDR_HWID_BITMASK from .S files
@ 2018-02-19 10:19   ` John Garry
  0 siblings, 0 replies; 20+ messages in thread
From: John Garry @ 2018-02-19 10:19 UTC (permalink / raw)
  To: Bhupesh Sharma, linux-arm-kernel, linux-kernel; +Cc: bhupesh.linux

On 19/02/2018 06:39, Bhupesh Sharma wrote:
> Since commit e1a50de37860b3a93a9d643b09638db5aff47650 (arm64: cputype:
> Silence Sparse warnings), compilation of arm64 architecture is broken
> with the following error messages:
>
>   AR      arch/arm64/kernel/built-in.o
>   arch/arm64/kernel/head.S: Assembler messages:
>   arch/arm64/kernel/head.S:677: Error: found 'L', expected: ')'
>   arch/arm64/kernel/head.S:677: Error: found 'L', expected: ')'
>   arch/arm64/kernel/head.S:677: Error: found 'L', expected: ')'
>   arch/arm64/kernel/head.S:677: Error: junk at end of line, first
>   unrecognized character is `L'
>   arch/arm64/kernel/head.S:677: Error: unexpected characters following
>   instruction at operand 2 -- `movz x1,:abs_g1_s:0xff00ffffffUL'
>   arch/arm64/kernel/head.S:677: Error: unexpected characters following
>   instruction at operand 2 -- `movk x1,:abs_g0_nc:0xff00ffffffUL'
>
> This patch fixes the same by using the UL() macro correctly for
> assigning the MPIDR_HWID_BITMASK macro value.
>
> Signed-off-by: Bhupesh Sharma <bhsharma@redhat.com>
> ---
>  arch/arm64/include/asm/cputype.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/include/asm/cputype.h b/arch/arm64/include/asm/cputype.h
> index eda8c5f629fc..350c76a1d15b 100644
> --- a/arch/arm64/include/asm/cputype.h
> +++ b/arch/arm64/include/asm/cputype.h
> @@ -20,7 +20,7 @@
>
>  #define MPIDR_UP_BITMASK	(0x1 << 30)
>  #define MPIDR_MT_BITMASK	(0x1 << 24)
> -#define MPIDR_HWID_BITMASK	0xff00ffffffUL
> +#define MPIDR_HWID_BITMASK	UL(0xff00ffffff)

Works for me.

FYI, I am using (old) gcc-linaro-4.8-2015.06-x86_64_aarch64.

Thanks,
John

>
>  #define MPIDR_LEVEL_BITS_SHIFT	3
>  #define MPIDR_LEVEL_BITS	(1 << MPIDR_LEVEL_BITS_SHIFT)
>

^ permalink raw reply	[flat|nested] 20+ messages in thread

* [PATCH] arm64: Fix compilation error while accessing MPIDR_HWID_BITMASK from .S files
  2018-02-19 10:19   ` John Garry
@ 2018-02-19 11:02     ` Will Deacon
  -1 siblings, 0 replies; 20+ messages in thread
From: Will Deacon @ 2018-02-19 11:02 UTC (permalink / raw)
  To: linux-arm-kernel

Hi John,

On Mon, Feb 19, 2018 at 10:19:35AM +0000, John Garry wrote:
> On 19/02/2018 06:39, Bhupesh Sharma wrote:
> >Since commit e1a50de37860b3a93a9d643b09638db5aff47650 (arm64: cputype:
> >Silence Sparse warnings), compilation of arm64 architecture is broken
> >with the following error messages:
> >
> >  AR      arch/arm64/kernel/built-in.o
> >  arch/arm64/kernel/head.S: Assembler messages:
> >  arch/arm64/kernel/head.S:677: Error: found 'L', expected: ')'
> >  arch/arm64/kernel/head.S:677: Error: found 'L', expected: ')'
> >  arch/arm64/kernel/head.S:677: Error: found 'L', expected: ')'
> >  arch/arm64/kernel/head.S:677: Error: junk at end of line, first
> >  unrecognized character is `L'
> >  arch/arm64/kernel/head.S:677: Error: unexpected characters following
> >  instruction at operand 2 -- `movz x1,:abs_g1_s:0xff00ffffffUL'
> >  arch/arm64/kernel/head.S:677: Error: unexpected characters following
> >  instruction at operand 2 -- `movk x1,:abs_g0_nc:0xff00ffffffUL'
> >
> >This patch fixes the same by using the UL() macro correctly for
> >assigning the MPIDR_HWID_BITMASK macro value.
> >
> >Signed-off-by: Bhupesh Sharma <bhsharma@redhat.com>
> >---
> > arch/arm64/include/asm/cputype.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >diff --git a/arch/arm64/include/asm/cputype.h b/arch/arm64/include/asm/cputype.h
> >index eda8c5f629fc..350c76a1d15b 100644
> >--- a/arch/arm64/include/asm/cputype.h
> >+++ b/arch/arm64/include/asm/cputype.h
> >@@ -20,7 +20,7 @@
> >
> > #define MPIDR_UP_BITMASK	(0x1 << 30)
> > #define MPIDR_MT_BITMASK	(0x1 << 24)
> >-#define MPIDR_HWID_BITMASK	0xff00ffffffUL
> >+#define MPIDR_HWID_BITMASK	UL(0xff00ffffff)
> 
> Works for me.
> 
> FYI, I am using (old) gcc-linaro-4.8-2015.06-x86_64_aarch64.

Just to confirm: are you saying that this patch fixes the build for you,
or that mainline builds for you and the patch is not needed?

Cheers,

Will

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [PATCH] arm64: Fix compilation error while accessing MPIDR_HWID_BITMASK from .S files
@ 2018-02-19 11:02     ` Will Deacon
  0 siblings, 0 replies; 20+ messages in thread
From: Will Deacon @ 2018-02-19 11:02 UTC (permalink / raw)
  To: John Garry; +Cc: Bhupesh Sharma, linux-arm-kernel, linux-kernel, bhupesh.linux

Hi John,

On Mon, Feb 19, 2018 at 10:19:35AM +0000, John Garry wrote:
> On 19/02/2018 06:39, Bhupesh Sharma wrote:
> >Since commit e1a50de37860b3a93a9d643b09638db5aff47650 (arm64: cputype:
> >Silence Sparse warnings), compilation of arm64 architecture is broken
> >with the following error messages:
> >
> >  AR      arch/arm64/kernel/built-in.o
> >  arch/arm64/kernel/head.S: Assembler messages:
> >  arch/arm64/kernel/head.S:677: Error: found 'L', expected: ')'
> >  arch/arm64/kernel/head.S:677: Error: found 'L', expected: ')'
> >  arch/arm64/kernel/head.S:677: Error: found 'L', expected: ')'
> >  arch/arm64/kernel/head.S:677: Error: junk at end of line, first
> >  unrecognized character is `L'
> >  arch/arm64/kernel/head.S:677: Error: unexpected characters following
> >  instruction at operand 2 -- `movz x1,:abs_g1_s:0xff00ffffffUL'
> >  arch/arm64/kernel/head.S:677: Error: unexpected characters following
> >  instruction at operand 2 -- `movk x1,:abs_g0_nc:0xff00ffffffUL'
> >
> >This patch fixes the same by using the UL() macro correctly for
> >assigning the MPIDR_HWID_BITMASK macro value.
> >
> >Signed-off-by: Bhupesh Sharma <bhsharma@redhat.com>
> >---
> > arch/arm64/include/asm/cputype.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >diff --git a/arch/arm64/include/asm/cputype.h b/arch/arm64/include/asm/cputype.h
> >index eda8c5f629fc..350c76a1d15b 100644
> >--- a/arch/arm64/include/asm/cputype.h
> >+++ b/arch/arm64/include/asm/cputype.h
> >@@ -20,7 +20,7 @@
> >
> > #define MPIDR_UP_BITMASK	(0x1 << 30)
> > #define MPIDR_MT_BITMASK	(0x1 << 24)
> >-#define MPIDR_HWID_BITMASK	0xff00ffffffUL
> >+#define MPIDR_HWID_BITMASK	UL(0xff00ffffff)
> 
> Works for me.
> 
> FYI, I am using (old) gcc-linaro-4.8-2015.06-x86_64_aarch64.

Just to confirm: are you saying that this patch fixes the build for you,
or that mainline builds for you and the patch is not needed?

Cheers,

Will

^ permalink raw reply	[flat|nested] 20+ messages in thread

* [PATCH] arm64: Fix compilation error while accessing MPIDR_HWID_BITMASK from .S files
  2018-02-19 11:02     ` Will Deacon
@ 2018-02-19 11:12       ` John Garry
  -1 siblings, 0 replies; 20+ messages in thread
From: John Garry @ 2018-02-19 11:12 UTC (permalink / raw)
  To: linux-arm-kernel

On 19/02/2018 11:02, Will Deacon wrote:
> Hi John,
>
> On Mon, Feb 19, 2018 at 10:19:35AM +0000, John Garry wrote:
>> On 19/02/2018 06:39, Bhupesh Sharma wrote:
>>> Since commit e1a50de37860b3a93a9d643b09638db5aff47650 (arm64: cputype:
>>> Silence Sparse warnings), compilation of arm64 architecture is broken
>>> with the following error messages:
>>>
>>>  AR      arch/arm64/kernel/built-in.o
>>>  arch/arm64/kernel/head.S: Assembler messages:
>>>  arch/arm64/kernel/head.S:677: Error: found 'L', expected: ')'
>>>  arch/arm64/kernel/head.S:677: Error: found 'L', expected: ')'
>>>  arch/arm64/kernel/head.S:677: Error: found 'L', expected: ')'
>>>  arch/arm64/kernel/head.S:677: Error: junk at end of line, first
>>>  unrecognized character is `L'
>>>  arch/arm64/kernel/head.S:677: Error: unexpected characters following
>>>  instruction at operand 2 -- `movz x1,:abs_g1_s:0xff00ffffffUL'
>>>  arch/arm64/kernel/head.S:677: Error: unexpected characters following
>>>  instruction at operand 2 -- `movk x1,:abs_g0_nc:0xff00ffffffUL'
>>>
>>> This patch fixes the same by using the UL() macro correctly for
>>> assigning the MPIDR_HWID_BITMASK macro value.
>>>
>>> Signed-off-by: Bhupesh Sharma <bhsharma@redhat.com>
>>> ---
>>> arch/arm64/include/asm/cputype.h | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/arch/arm64/include/asm/cputype.h b/arch/arm64/include/asm/cputype.h
>>> index eda8c5f629fc..350c76a1d15b 100644
>>> --- a/arch/arm64/include/asm/cputype.h
>>> +++ b/arch/arm64/include/asm/cputype.h
>>> @@ -20,7 +20,7 @@
>>>
>>> #define MPIDR_UP_BITMASK	(0x1 << 30)
>>> #define MPIDR_MT_BITMASK	(0x1 << 24)
>>> -#define MPIDR_HWID_BITMASK	0xff00ffffffUL
>>> +#define MPIDR_HWID_BITMASK	UL(0xff00ffffff)
>>
>> Works for me.
>>
>> FYI, I am using (old) gcc-linaro-4.8-2015.06-x86_64_aarch64.
>
> Just to confirm: are you saying that this patch fixes the build for you,
> or that mainline builds for you and the patch is not needed?
>

Ah, what I said was ambigious.

I am saying that linux-next (20180219) is broken for me for the same 
reason and this patch fixes it.

I didn't spot the kernelci message Arnd mentioned, so I just wanted to 
mention the toolchain I used.

Cheers,
John

> Cheers,
>
> Will
>
> .
>

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [PATCH] arm64: Fix compilation error while accessing MPIDR_HWID_BITMASK from .S files
@ 2018-02-19 11:12       ` John Garry
  0 siblings, 0 replies; 20+ messages in thread
From: John Garry @ 2018-02-19 11:12 UTC (permalink / raw)
  To: Will Deacon; +Cc: Bhupesh Sharma, linux-arm-kernel, linux-kernel, bhupesh.linux

On 19/02/2018 11:02, Will Deacon wrote:
> Hi John,
>
> On Mon, Feb 19, 2018 at 10:19:35AM +0000, John Garry wrote:
>> On 19/02/2018 06:39, Bhupesh Sharma wrote:
>>> Since commit e1a50de37860b3a93a9d643b09638db5aff47650 (arm64: cputype:
>>> Silence Sparse warnings), compilation of arm64 architecture is broken
>>> with the following error messages:
>>>
>>>  AR      arch/arm64/kernel/built-in.o
>>>  arch/arm64/kernel/head.S: Assembler messages:
>>>  arch/arm64/kernel/head.S:677: Error: found 'L', expected: ')'
>>>  arch/arm64/kernel/head.S:677: Error: found 'L', expected: ')'
>>>  arch/arm64/kernel/head.S:677: Error: found 'L', expected: ')'
>>>  arch/arm64/kernel/head.S:677: Error: junk at end of line, first
>>>  unrecognized character is `L'
>>>  arch/arm64/kernel/head.S:677: Error: unexpected characters following
>>>  instruction at operand 2 -- `movz x1,:abs_g1_s:0xff00ffffffUL'
>>>  arch/arm64/kernel/head.S:677: Error: unexpected characters following
>>>  instruction at operand 2 -- `movk x1,:abs_g0_nc:0xff00ffffffUL'
>>>
>>> This patch fixes the same by using the UL() macro correctly for
>>> assigning the MPIDR_HWID_BITMASK macro value.
>>>
>>> Signed-off-by: Bhupesh Sharma <bhsharma@redhat.com>
>>> ---
>>> arch/arm64/include/asm/cputype.h | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/arch/arm64/include/asm/cputype.h b/arch/arm64/include/asm/cputype.h
>>> index eda8c5f629fc..350c76a1d15b 100644
>>> --- a/arch/arm64/include/asm/cputype.h
>>> +++ b/arch/arm64/include/asm/cputype.h
>>> @@ -20,7 +20,7 @@
>>>
>>> #define MPIDR_UP_BITMASK	(0x1 << 30)
>>> #define MPIDR_MT_BITMASK	(0x1 << 24)
>>> -#define MPIDR_HWID_BITMASK	0xff00ffffffUL
>>> +#define MPIDR_HWID_BITMASK	UL(0xff00ffffff)
>>
>> Works for me.
>>
>> FYI, I am using (old) gcc-linaro-4.8-2015.06-x86_64_aarch64.
>
> Just to confirm: are you saying that this patch fixes the build for you,
> or that mainline builds for you and the patch is not needed?
>

Ah, what I said was ambigious.

I am saying that linux-next (20180219) is broken for me for the same 
reason and this patch fixes it.

I didn't spot the kernelci message Arnd mentioned, so I just wanted to 
mention the toolchain I used.

Cheers,
John

> Cheers,
>
> Will
>
> .
>

^ permalink raw reply	[flat|nested] 20+ messages in thread

* [PATCH] arm64: Fix compilation error while accessing MPIDR_HWID_BITMASK from .S files
  2018-02-19 11:12       ` John Garry
@ 2018-02-19 11:19         ` Will Deacon
  -1 siblings, 0 replies; 20+ messages in thread
From: Will Deacon @ 2018-02-19 11:19 UTC (permalink / raw)
  To: linux-arm-kernel

On Mon, Feb 19, 2018 at 11:12:32AM +0000, John Garry wrote:
> On 19/02/2018 11:02, Will Deacon wrote:
> >Hi John,
> >
> >On Mon, Feb 19, 2018 at 10:19:35AM +0000, John Garry wrote:
> >>On 19/02/2018 06:39, Bhupesh Sharma wrote:
> >>>Since commit e1a50de37860b3a93a9d643b09638db5aff47650 (arm64: cputype:
> >>>Silence Sparse warnings), compilation of arm64 architecture is broken
> >>>with the following error messages:
> >>>
> >>> AR      arch/arm64/kernel/built-in.o
> >>> arch/arm64/kernel/head.S: Assembler messages:
> >>> arch/arm64/kernel/head.S:677: Error: found 'L', expected: ')'
> >>> arch/arm64/kernel/head.S:677: Error: found 'L', expected: ')'
> >>> arch/arm64/kernel/head.S:677: Error: found 'L', expected: ')'
> >>> arch/arm64/kernel/head.S:677: Error: junk at end of line, first
> >>> unrecognized character is `L'
> >>> arch/arm64/kernel/head.S:677: Error: unexpected characters following
> >>> instruction at operand 2 -- `movz x1,:abs_g1_s:0xff00ffffffUL'
> >>> arch/arm64/kernel/head.S:677: Error: unexpected characters following
> >>> instruction at operand 2 -- `movk x1,:abs_g0_nc:0xff00ffffffUL'
> >>>
> >>>This patch fixes the same by using the UL() macro correctly for
> >>>assigning the MPIDR_HWID_BITMASK macro value.
> >>>
> >>>Signed-off-by: Bhupesh Sharma <bhsharma@redhat.com>
> >>>---
> >>>arch/arm64/include/asm/cputype.h | 2 +-
> >>>1 file changed, 1 insertion(+), 1 deletion(-)
> >>>
> >>>diff --git a/arch/arm64/include/asm/cputype.h b/arch/arm64/include/asm/cputype.h
> >>>index eda8c5f629fc..350c76a1d15b 100644
> >>>--- a/arch/arm64/include/asm/cputype.h
> >>>+++ b/arch/arm64/include/asm/cputype.h
> >>>@@ -20,7 +20,7 @@
> >>>
> >>>#define MPIDR_UP_BITMASK	(0x1 << 30)
> >>>#define MPIDR_MT_BITMASK	(0x1 << 24)
> >>>-#define MPIDR_HWID_BITMASK	0xff00ffffffUL
> >>>+#define MPIDR_HWID_BITMASK	UL(0xff00ffffff)
> >>
> >>Works for me.
> >>
> >>FYI, I am using (old) gcc-linaro-4.8-2015.06-x86_64_aarch64.
> >
> >Just to confirm: are you saying that this patch fixes the build for you,
> >or that mainline builds for you and the patch is not needed?
> >
> 
> Ah, what I said was ambigious.
> 
> I am saying that linux-next (20180219) is broken for me for the same reason
> and this patch fixes it.
> 
> I didn't spot the kernelci message Arnd mentioned, so I just wanted to
> mention the toolchain I used.

Thanks for the clarification; Catalin -- can you pick this up for -rc3 please?

Will

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [PATCH] arm64: Fix compilation error while accessing MPIDR_HWID_BITMASK from .S files
@ 2018-02-19 11:19         ` Will Deacon
  0 siblings, 0 replies; 20+ messages in thread
From: Will Deacon @ 2018-02-19 11:19 UTC (permalink / raw)
  To: John Garry, catalin.marinas
  Cc: Bhupesh Sharma, linux-arm-kernel, linux-kernel, bhupesh.linux

On Mon, Feb 19, 2018 at 11:12:32AM +0000, John Garry wrote:
> On 19/02/2018 11:02, Will Deacon wrote:
> >Hi John,
> >
> >On Mon, Feb 19, 2018 at 10:19:35AM +0000, John Garry wrote:
> >>On 19/02/2018 06:39, Bhupesh Sharma wrote:
> >>>Since commit e1a50de37860b3a93a9d643b09638db5aff47650 (arm64: cputype:
> >>>Silence Sparse warnings), compilation of arm64 architecture is broken
> >>>with the following error messages:
> >>>
> >>> AR      arch/arm64/kernel/built-in.o
> >>> arch/arm64/kernel/head.S: Assembler messages:
> >>> arch/arm64/kernel/head.S:677: Error: found 'L', expected: ')'
> >>> arch/arm64/kernel/head.S:677: Error: found 'L', expected: ')'
> >>> arch/arm64/kernel/head.S:677: Error: found 'L', expected: ')'
> >>> arch/arm64/kernel/head.S:677: Error: junk at end of line, first
> >>> unrecognized character is `L'
> >>> arch/arm64/kernel/head.S:677: Error: unexpected characters following
> >>> instruction at operand 2 -- `movz x1,:abs_g1_s:0xff00ffffffUL'
> >>> arch/arm64/kernel/head.S:677: Error: unexpected characters following
> >>> instruction at operand 2 -- `movk x1,:abs_g0_nc:0xff00ffffffUL'
> >>>
> >>>This patch fixes the same by using the UL() macro correctly for
> >>>assigning the MPIDR_HWID_BITMASK macro value.
> >>>
> >>>Signed-off-by: Bhupesh Sharma <bhsharma@redhat.com>
> >>>---
> >>>arch/arm64/include/asm/cputype.h | 2 +-
> >>>1 file changed, 1 insertion(+), 1 deletion(-)
> >>>
> >>>diff --git a/arch/arm64/include/asm/cputype.h b/arch/arm64/include/asm/cputype.h
> >>>index eda8c5f629fc..350c76a1d15b 100644
> >>>--- a/arch/arm64/include/asm/cputype.h
> >>>+++ b/arch/arm64/include/asm/cputype.h
> >>>@@ -20,7 +20,7 @@
> >>>
> >>>#define MPIDR_UP_BITMASK	(0x1 << 30)
> >>>#define MPIDR_MT_BITMASK	(0x1 << 24)
> >>>-#define MPIDR_HWID_BITMASK	0xff00ffffffUL
> >>>+#define MPIDR_HWID_BITMASK	UL(0xff00ffffff)
> >>
> >>Works for me.
> >>
> >>FYI, I am using (old) gcc-linaro-4.8-2015.06-x86_64_aarch64.
> >
> >Just to confirm: are you saying that this patch fixes the build for you,
> >or that mainline builds for you and the patch is not needed?
> >
> 
> Ah, what I said was ambigious.
> 
> I am saying that linux-next (20180219) is broken for me for the same reason
> and this patch fixes it.
> 
> I didn't spot the kernelci message Arnd mentioned, so I just wanted to
> mention the toolchain I used.

Thanks for the clarification; Catalin -- can you pick this up for -rc3 please?

Will

^ permalink raw reply	[flat|nested] 20+ messages in thread

* [PATCH] arm64: Fix compilation error while accessing MPIDR_HWID_BITMASK from .S files
  2018-02-19 11:19         ` Will Deacon
@ 2018-02-19 12:13           ` Catalin Marinas
  -1 siblings, 0 replies; 20+ messages in thread
From: Catalin Marinas @ 2018-02-19 12:13 UTC (permalink / raw)
  To: linux-arm-kernel

On Mon, Feb 19, 2018 at 11:19:07AM +0000, Will Deacon wrote:
> > >>On 19/02/2018 06:39, Bhupesh Sharma wrote:
> > >>>Since commit e1a50de37860b3a93a9d643b09638db5aff47650 (arm64: cputype:
> > >>>Silence Sparse warnings), compilation of arm64 architecture is broken
> > >>>with the following error messages:
> > >>>
> > >>> AR      arch/arm64/kernel/built-in.o
> > >>> arch/arm64/kernel/head.S: Assembler messages:
> > >>> arch/arm64/kernel/head.S:677: Error: found 'L', expected: ')'
> > >>> arch/arm64/kernel/head.S:677: Error: found 'L', expected: ')'
> > >>> arch/arm64/kernel/head.S:677: Error: found 'L', expected: ')'
> > >>> arch/arm64/kernel/head.S:677: Error: junk at end of line, first
> > >>> unrecognized character is `L'
> > >>> arch/arm64/kernel/head.S:677: Error: unexpected characters following
> > >>> instruction at operand 2 -- `movz x1,:abs_g1_s:0xff00ffffffUL'
> > >>> arch/arm64/kernel/head.S:677: Error: unexpected characters following
> > >>> instruction at operand 2 -- `movk x1,:abs_g0_nc:0xff00ffffffUL'
> > >>>
> > >>>This patch fixes the same by using the UL() macro correctly for
> > >>>assigning the MPIDR_HWID_BITMASK macro value.
> > >>>
> > >>>Signed-off-by: Bhupesh Sharma <bhsharma@redhat.com>
[...]
> Thanks for the clarification; Catalin -- can you pick this up for -rc3 please?

Done. Strange that it builds fine with newer toolchains.

-- 
Catalin

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [PATCH] arm64: Fix compilation error while accessing MPIDR_HWID_BITMASK from .S files
@ 2018-02-19 12:13           ` Catalin Marinas
  0 siblings, 0 replies; 20+ messages in thread
From: Catalin Marinas @ 2018-02-19 12:13 UTC (permalink / raw)
  To: Will Deacon
  Cc: John Garry, Bhupesh Sharma, bhupesh.linux, linux-kernel,
	linux-arm-kernel

On Mon, Feb 19, 2018 at 11:19:07AM +0000, Will Deacon wrote:
> > >>On 19/02/2018 06:39, Bhupesh Sharma wrote:
> > >>>Since commit e1a50de37860b3a93a9d643b09638db5aff47650 (arm64: cputype:
> > >>>Silence Sparse warnings), compilation of arm64 architecture is broken
> > >>>with the following error messages:
> > >>>
> > >>> AR      arch/arm64/kernel/built-in.o
> > >>> arch/arm64/kernel/head.S: Assembler messages:
> > >>> arch/arm64/kernel/head.S:677: Error: found 'L', expected: ')'
> > >>> arch/arm64/kernel/head.S:677: Error: found 'L', expected: ')'
> > >>> arch/arm64/kernel/head.S:677: Error: found 'L', expected: ')'
> > >>> arch/arm64/kernel/head.S:677: Error: junk at end of line, first
> > >>> unrecognized character is `L'
> > >>> arch/arm64/kernel/head.S:677: Error: unexpected characters following
> > >>> instruction at operand 2 -- `movz x1,:abs_g1_s:0xff00ffffffUL'
> > >>> arch/arm64/kernel/head.S:677: Error: unexpected characters following
> > >>> instruction at operand 2 -- `movk x1,:abs_g0_nc:0xff00ffffffUL'
> > >>>
> > >>>This patch fixes the same by using the UL() macro correctly for
> > >>>assigning the MPIDR_HWID_BITMASK macro value.
> > >>>
> > >>>Signed-off-by: Bhupesh Sharma <bhsharma@redhat.com>
[...]
> Thanks for the clarification; Catalin -- can you pick this up for -rc3 please?

Done. Strange that it builds fine with newer toolchains.

-- 
Catalin

^ permalink raw reply	[flat|nested] 20+ messages in thread

* [PATCH] arm64: Fix compilation error while accessing MPIDR_HWID_BITMASK from .S files
  2018-02-19 11:02     ` Will Deacon
@ 2018-02-19 11:26       ` Jan Glauber
  -1 siblings, 0 replies; 20+ messages in thread
From: Jan Glauber @ 2018-02-19 11:26 UTC (permalink / raw)
  To: linux-arm-kernel

Hi Will,

I just hit the same issue with 4.16-rc2. The patch makes it compilable
again.

--Jan

On Mon, Feb 19, 2018 at 11:02:39AM +0000, Will Deacon wrote:
> Hi John,
> 
> On Mon, Feb 19, 2018 at 10:19:35AM +0000, John Garry wrote:
> > On 19/02/2018 06:39, Bhupesh Sharma wrote:
> > >Since commit e1a50de37860b3a93a9d643b09638db5aff47650 (arm64: cputype:
> > >Silence Sparse warnings), compilation of arm64 architecture is broken
> > >with the following error messages:
> > >
> > >  AR      arch/arm64/kernel/built-in.o
> > >  arch/arm64/kernel/head.S: Assembler messages:
> > >  arch/arm64/kernel/head.S:677: Error: found 'L', expected: ')'
> > >  arch/arm64/kernel/head.S:677: Error: found 'L', expected: ')'
> > >  arch/arm64/kernel/head.S:677: Error: found 'L', expected: ')'
> > >  arch/arm64/kernel/head.S:677: Error: junk at end of line, first
> > >  unrecognized character is `L'
> > >  arch/arm64/kernel/head.S:677: Error: unexpected characters following
> > >  instruction at operand 2 -- `movz x1,:abs_g1_s:0xff00ffffffUL'
> > >  arch/arm64/kernel/head.S:677: Error: unexpected characters following
> > >  instruction at operand 2 -- `movk x1,:abs_g0_nc:0xff00ffffffUL'
> > >
> > >This patch fixes the same by using the UL() macro correctly for
> > >assigning the MPIDR_HWID_BITMASK macro value.
> > >
> > >Signed-off-by: Bhupesh Sharma <bhsharma@redhat.com>
> > >---
> > > arch/arm64/include/asm/cputype.h | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > >diff --git a/arch/arm64/include/asm/cputype.h b/arch/arm64/include/asm/cputype.h
> > >index eda8c5f629fc..350c76a1d15b 100644
> > >--- a/arch/arm64/include/asm/cputype.h
> > >+++ b/arch/arm64/include/asm/cputype.h
> > >@@ -20,7 +20,7 @@
> > >
> > > #define MPIDR_UP_BITMASK	(0x1 << 30)
> > > #define MPIDR_MT_BITMASK	(0x1 << 24)
> > >-#define MPIDR_HWID_BITMASK	0xff00ffffffUL
> > >+#define MPIDR_HWID_BITMASK	UL(0xff00ffffff)
> > 
> > Works for me.
> > 
> > FYI, I am using (old) gcc-linaro-4.8-2015.06-x86_64_aarch64.
> 
> Just to confirm: are you saying that this patch fixes the build for you,
> or that mainline builds for you and the patch is not needed?
> 
> Cheers,
> 
> Will
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [PATCH] arm64: Fix compilation error while accessing MPIDR_HWID_BITMASK from .S files
@ 2018-02-19 11:26       ` Jan Glauber
  0 siblings, 0 replies; 20+ messages in thread
From: Jan Glauber @ 2018-02-19 11:26 UTC (permalink / raw)
  To: Will Deacon
  Cc: John Garry, Bhupesh Sharma, bhupesh.linux, linux-kernel,
	linux-arm-kernel

Hi Will,

I just hit the same issue with 4.16-rc2. The patch makes it compilable
again.

--Jan

On Mon, Feb 19, 2018 at 11:02:39AM +0000, Will Deacon wrote:
> Hi John,
> 
> On Mon, Feb 19, 2018 at 10:19:35AM +0000, John Garry wrote:
> > On 19/02/2018 06:39, Bhupesh Sharma wrote:
> > >Since commit e1a50de37860b3a93a9d643b09638db5aff47650 (arm64: cputype:
> > >Silence Sparse warnings), compilation of arm64 architecture is broken
> > >with the following error messages:
> > >
> > >  AR      arch/arm64/kernel/built-in.o
> > >  arch/arm64/kernel/head.S: Assembler messages:
> > >  arch/arm64/kernel/head.S:677: Error: found 'L', expected: ')'
> > >  arch/arm64/kernel/head.S:677: Error: found 'L', expected: ')'
> > >  arch/arm64/kernel/head.S:677: Error: found 'L', expected: ')'
> > >  arch/arm64/kernel/head.S:677: Error: junk at end of line, first
> > >  unrecognized character is `L'
> > >  arch/arm64/kernel/head.S:677: Error: unexpected characters following
> > >  instruction at operand 2 -- `movz x1,:abs_g1_s:0xff00ffffffUL'
> > >  arch/arm64/kernel/head.S:677: Error: unexpected characters following
> > >  instruction at operand 2 -- `movk x1,:abs_g0_nc:0xff00ffffffUL'
> > >
> > >This patch fixes the same by using the UL() macro correctly for
> > >assigning the MPIDR_HWID_BITMASK macro value.
> > >
> > >Signed-off-by: Bhupesh Sharma <bhsharma@redhat.com>
> > >---
> > > arch/arm64/include/asm/cputype.h | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > >diff --git a/arch/arm64/include/asm/cputype.h b/arch/arm64/include/asm/cputype.h
> > >index eda8c5f629fc..350c76a1d15b 100644
> > >--- a/arch/arm64/include/asm/cputype.h
> > >+++ b/arch/arm64/include/asm/cputype.h
> > >@@ -20,7 +20,7 @@
> > >
> > > #define MPIDR_UP_BITMASK	(0x1 << 30)
> > > #define MPIDR_MT_BITMASK	(0x1 << 24)
> > >-#define MPIDR_HWID_BITMASK	0xff00ffffffUL
> > >+#define MPIDR_HWID_BITMASK	UL(0xff00ffffff)
> > 
> > Works for me.
> > 
> > FYI, I am using (old) gcc-linaro-4.8-2015.06-x86_64_aarch64.
> 
> Just to confirm: are you saying that this patch fixes the build for you,
> or that mainline builds for you and the patch is not needed?
> 
> Cheers,
> 
> Will
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 20+ messages in thread

* [PATCH] arm64: Fix compilation error while accessing MPIDR_HWID_BITMASK from .S files
  2018-02-19  6:39 ` Bhupesh Sharma
@ 2018-02-19 10:58   ` Arnd Bergmann
  -1 siblings, 0 replies; 20+ messages in thread
From: Arnd Bergmann @ 2018-02-19 10:58 UTC (permalink / raw)
  To: linux-arm-kernel

On Mon, Feb 19, 2018 at 7:39 AM, Bhupesh Sharma <bhsharma@redhat.com> wrote:
> Since commit e1a50de37860b3a93a9d643b09638db5aff47650 (arm64: cputype:
> Silence Sparse warnings), compilation of arm64 architecture is broken
> with the following error messages:
>
>   AR      arch/arm64/kernel/built-in.o
>   arch/arm64/kernel/head.S: Assembler messages:
>   arch/arm64/kernel/head.S:677: Error: found 'L', expected: ')'
>   arch/arm64/kernel/head.S:677: Error: found 'L', expected: ')'
>   arch/arm64/kernel/head.S:677: Error: found 'L', expected: ')'
>   arch/arm64/kernel/head.S:677: Error: junk at end of line, first
>   unrecognized character is `L'
>   arch/arm64/kernel/head.S:677: Error: unexpected characters following
>   instruction at operand 2 -- `movz x1,:abs_g1_s:0xff00ffffffUL'
>   arch/arm64/kernel/head.S:677: Error: unexpected characters following
>   instruction at operand 2 -- `movk x1,:abs_g0_nc:0xff00ffffffUL'
>
> This patch fixes the same by using the UL() macro correctly for
> assigning the MPIDR_HWID_BITMASK macro value.
>
> Signed-off-by: Bhupesh Sharma <bhsharma@redhat.com>

Saw the same thing in the kernelci report for linux-next.

Acked-by: Arnd Bergmann <arnd@arndb.de>

Note that when referencing a commit, it's best to abbreviate the commit
ID to the first 12 characters like "e1a50de37860". You can also a line like

Fixes: e1a50de37860 ("arm64: cputype: Silence Sparse warnings")

which is the standard format to describe such regressions.

       Arnd

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [PATCH] arm64: Fix compilation error while accessing MPIDR_HWID_BITMASK from .S files
@ 2018-02-19 10:58   ` Arnd Bergmann
  0 siblings, 0 replies; 20+ messages in thread
From: Arnd Bergmann @ 2018-02-19 10:58 UTC (permalink / raw)
  To: Bhupesh Sharma; +Cc: Linux ARM, Linux Kernel Mailing List, bhupesh.linux

On Mon, Feb 19, 2018 at 7:39 AM, Bhupesh Sharma <bhsharma@redhat.com> wrote:
> Since commit e1a50de37860b3a93a9d643b09638db5aff47650 (arm64: cputype:
> Silence Sparse warnings), compilation of arm64 architecture is broken
> with the following error messages:
>
>   AR      arch/arm64/kernel/built-in.o
>   arch/arm64/kernel/head.S: Assembler messages:
>   arch/arm64/kernel/head.S:677: Error: found 'L', expected: ')'
>   arch/arm64/kernel/head.S:677: Error: found 'L', expected: ')'
>   arch/arm64/kernel/head.S:677: Error: found 'L', expected: ')'
>   arch/arm64/kernel/head.S:677: Error: junk at end of line, first
>   unrecognized character is `L'
>   arch/arm64/kernel/head.S:677: Error: unexpected characters following
>   instruction at operand 2 -- `movz x1,:abs_g1_s:0xff00ffffffUL'
>   arch/arm64/kernel/head.S:677: Error: unexpected characters following
>   instruction at operand 2 -- `movk x1,:abs_g0_nc:0xff00ffffffUL'
>
> This patch fixes the same by using the UL() macro correctly for
> assigning the MPIDR_HWID_BITMASK macro value.
>
> Signed-off-by: Bhupesh Sharma <bhsharma@redhat.com>

Saw the same thing in the kernelci report for linux-next.

Acked-by: Arnd Bergmann <arnd@arndb.de>

Note that when referencing a commit, it's best to abbreviate the commit
ID to the first 12 characters like "e1a50de37860". You can also a line like

Fixes: e1a50de37860 ("arm64: cputype: Silence Sparse warnings")

which is the standard format to describe such regressions.

       Arnd

^ permalink raw reply	[flat|nested] 20+ messages in thread

* [PATCH] arm64: Fix compilation error while accessing MPIDR_HWID_BITMASK from .S files
  2018-02-19 10:58   ` Arnd Bergmann
@ 2018-02-22  4:32     ` Viresh Kumar
  -1 siblings, 0 replies; 20+ messages in thread
From: Viresh Kumar @ 2018-02-22  4:32 UTC (permalink / raw)
  To: linux-arm-kernel

On Mon, Feb 19, 2018 at 4:28 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> Note that when referencing a commit, it's best to abbreviate the commit
> ID to the first 12 characters like "e1a50de37860". You can also a line like
>
> Fixes: e1a50de37860 ("arm64: cputype: Silence Sparse warnings")
>
> which is the standard format to describe such regressions.

Right and this can be automated a bit as well. The procedure is
described in:

Documentation/process/submitting-patches.rst

You can update your .gitconfig file and then use the --pretty=<...>
argument to `git log` or `git show` commands.

--
viresh

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [PATCH] arm64: Fix compilation error while accessing MPIDR_HWID_BITMASK from .S files
@ 2018-02-22  4:32     ` Viresh Kumar
  0 siblings, 0 replies; 20+ messages in thread
From: Viresh Kumar @ 2018-02-22  4:32 UTC (permalink / raw)
  To: Arnd Bergmann
  Cc: Bhupesh Sharma, Linux ARM, Linux Kernel Mailing List,
	bhupesh.linux

On Mon, Feb 19, 2018 at 4:28 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> Note that when referencing a commit, it's best to abbreviate the commit
> ID to the first 12 characters like "e1a50de37860". You can also a line like
>
> Fixes: e1a50de37860 ("arm64: cputype: Silence Sparse warnings")
>
> which is the standard format to describe such regressions.

Right and this can be automated a bit as well. The procedure is
described in:

Documentation/process/submitting-patches.rst

You can update your .gitconfig file and then use the --pretty=<...>
argument to `git log` or `git show` commands.

--
viresh

^ permalink raw reply	[flat|nested] 20+ messages in thread

* [PATCH] arm64: Fix compilation error while accessing MPIDR_HWID_BITMASK from .S files
  2018-02-19  6:39 ` Bhupesh Sharma
@ 2018-02-19 12:09   ` Robin Murphy
  -1 siblings, 0 replies; 20+ messages in thread
From: Robin Murphy @ 2018-02-19 12:09 UTC (permalink / raw)
  To: linux-arm-kernel

On 19/02/18 06:39, Bhupesh Sharma wrote:
> Since commit e1a50de37860b3a93a9d643b09638db5aff47650 (arm64: cputype:
> Silence Sparse warnings), compilation of arm64 architecture is broken
> with the following error messages:
> 
>    AR      arch/arm64/kernel/built-in.o
>    arch/arm64/kernel/head.S: Assembler messages:
>    arch/arm64/kernel/head.S:677: Error: found 'L', expected: ')'
>    arch/arm64/kernel/head.S:677: Error: found 'L', expected: ')'
>    arch/arm64/kernel/head.S:677: Error: found 'L', expected: ')'
>    arch/arm64/kernel/head.S:677: Error: junk at end of line, first
>    unrecognized character is `L'
>    arch/arm64/kernel/head.S:677: Error: unexpected characters following
>    instruction at operand 2 -- `movz x1,:abs_g1_s:0xff00ffffffUL'
>    arch/arm64/kernel/head.S:677: Error: unexpected characters following
>    instruction at operand 2 -- `movk x1,:abs_g0_nc:0xff00ffffffUL'
> 
> This patch fixes the same by using the UL() macro correctly for
> assigning the MPIDR_HWID_BITMASK macro value.

Sorry! I am however rather puzzled at how I didn't hit this with my 
toolchain (Linaro 17.11), and neither did the LKP robot. Oh well.

Acked-by: Robin Murphy <robin.murphy@arm.com>

> Signed-off-by: Bhupesh Sharma <bhsharma@redhat.com>
> ---
>   arch/arm64/include/asm/cputype.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/include/asm/cputype.h b/arch/arm64/include/asm/cputype.h
> index eda8c5f629fc..350c76a1d15b 100644
> --- a/arch/arm64/include/asm/cputype.h
> +++ b/arch/arm64/include/asm/cputype.h
> @@ -20,7 +20,7 @@
>   
>   #define MPIDR_UP_BITMASK	(0x1 << 30)
>   #define MPIDR_MT_BITMASK	(0x1 << 24)
> -#define MPIDR_HWID_BITMASK	0xff00ffffffUL
> +#define MPIDR_HWID_BITMASK	UL(0xff00ffffff)
>   
>   #define MPIDR_LEVEL_BITS_SHIFT	3
>   #define MPIDR_LEVEL_BITS	(1 << MPIDR_LEVEL_BITS_SHIFT)
> 

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [PATCH] arm64: Fix compilation error while accessing MPIDR_HWID_BITMASK from .S files
@ 2018-02-19 12:09   ` Robin Murphy
  0 siblings, 0 replies; 20+ messages in thread
From: Robin Murphy @ 2018-02-19 12:09 UTC (permalink / raw)
  To: Bhupesh Sharma, linux-arm-kernel, linux-kernel; +Cc: bhupesh.linux

On 19/02/18 06:39, Bhupesh Sharma wrote:
> Since commit e1a50de37860b3a93a9d643b09638db5aff47650 (arm64: cputype:
> Silence Sparse warnings), compilation of arm64 architecture is broken
> with the following error messages:
> 
>    AR      arch/arm64/kernel/built-in.o
>    arch/arm64/kernel/head.S: Assembler messages:
>    arch/arm64/kernel/head.S:677: Error: found 'L', expected: ')'
>    arch/arm64/kernel/head.S:677: Error: found 'L', expected: ')'
>    arch/arm64/kernel/head.S:677: Error: found 'L', expected: ')'
>    arch/arm64/kernel/head.S:677: Error: junk at end of line, first
>    unrecognized character is `L'
>    arch/arm64/kernel/head.S:677: Error: unexpected characters following
>    instruction at operand 2 -- `movz x1,:abs_g1_s:0xff00ffffffUL'
>    arch/arm64/kernel/head.S:677: Error: unexpected characters following
>    instruction at operand 2 -- `movk x1,:abs_g0_nc:0xff00ffffffUL'
> 
> This patch fixes the same by using the UL() macro correctly for
> assigning the MPIDR_HWID_BITMASK macro value.

Sorry! I am however rather puzzled at how I didn't hit this with my 
toolchain (Linaro 17.11), and neither did the LKP robot. Oh well.

Acked-by: Robin Murphy <robin.murphy@arm.com>

> Signed-off-by: Bhupesh Sharma <bhsharma@redhat.com>
> ---
>   arch/arm64/include/asm/cputype.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/include/asm/cputype.h b/arch/arm64/include/asm/cputype.h
> index eda8c5f629fc..350c76a1d15b 100644
> --- a/arch/arm64/include/asm/cputype.h
> +++ b/arch/arm64/include/asm/cputype.h
> @@ -20,7 +20,7 @@
>   
>   #define MPIDR_UP_BITMASK	(0x1 << 30)
>   #define MPIDR_MT_BITMASK	(0x1 << 24)
> -#define MPIDR_HWID_BITMASK	0xff00ffffffUL
> +#define MPIDR_HWID_BITMASK	UL(0xff00ffffff)
>   
>   #define MPIDR_LEVEL_BITS_SHIFT	3
>   #define MPIDR_LEVEL_BITS	(1 << MPIDR_LEVEL_BITS_SHIFT)
> 

^ permalink raw reply	[flat|nested] 20+ messages in thread

end of thread, other threads:[~2018-02-22  4:33 UTC | newest]

Thread overview: 20+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-02-19  6:39 [PATCH] arm64: Fix compilation error while accessing MPIDR_HWID_BITMASK from .S files Bhupesh Sharma
2018-02-19  6:39 ` Bhupesh Sharma
2018-02-19 10:19 ` John Garry
2018-02-19 10:19   ` John Garry
2018-02-19 11:02   ` Will Deacon
2018-02-19 11:02     ` Will Deacon
2018-02-19 11:12     ` John Garry
2018-02-19 11:12       ` John Garry
2018-02-19 11:19       ` Will Deacon
2018-02-19 11:19         ` Will Deacon
2018-02-19 12:13         ` Catalin Marinas
2018-02-19 12:13           ` Catalin Marinas
2018-02-19 11:26     ` Jan Glauber
2018-02-19 11:26       ` Jan Glauber
2018-02-19 10:58 ` Arnd Bergmann
2018-02-19 10:58   ` Arnd Bergmann
2018-02-22  4:32   ` Viresh Kumar
2018-02-22  4:32     ` Viresh Kumar
2018-02-19 12:09 ` Robin Murphy
2018-02-19 12:09   ` Robin Murphy

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.