From: LW@KARO-electronics.de (Lothar Waßmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC] ARM: dts: imx28-tx28: Pass the memory unit name
Date: Mon, 19 Feb 2018 13:06:24 +0100 [thread overview]
Message-ID: <20180219130624.30a5f572@karo-electronics.de> (raw)
In-Reply-To: <1518882103-17137-1-git-send-email-festevam@gmail.com>
Hi,
On Sat, 17 Feb 2018 13:41:43 -0200 Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@nxp.com>
>
> Pass the memory unit name in order to fix the following
> dtc warning with W=1:
>
> arch/arm/boot/dts/imx28-tx28.dtb: Warning (unit_address_vs_reg): Node /memory has a reg or ranges property, but no unit name
>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
> ---
> Hi,
>
> Currently the only dtc warnings observed with W=1 are the ones:
> Warning (unit_address_vs_reg): Node /memory has a reg or ranges property, but no unit name
>
> If this solution can be accepted I can clean all the other i.MX dts files.
>
> Please advise.
>
> arch/arm/boot/dts/imx28-tx28.dts | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/imx28-tx28.dts b/arch/arm/boot/dts/imx28-tx28.dts
> index 8a4f5bc..bbdf004 100644
> --- a/arch/arm/boot/dts/imx28-tx28.dts
> +++ b/arch/arm/boot/dts/imx28-tx28.dts
> @@ -65,8 +65,8 @@
> usbotg = &usb0;
> };
>
> - memory {
> - reg = <0 0>; /* will be filled in by U-Boot */
> + memory at 40000000 {
> + reg = <0x40000000 0>; /* will be filled in by U-Boot */
> };
>
> onewire {
>
I have no objections to this change. U-Boot still finds the memory node
and puts the correct size into the 'reg' property.
Acked-by: Lothar Wa?mann <LW@KARO-electronics.de>
Lothar Wa?mann
WARNING: multiple messages have this Message-ID (diff)
From: "Lothar Waßmann" <LW@KARO-electronics.de>
To: Fabio Estevam <festevam@gmail.com>
Cc: devicetree@vger.kernel.org, robh+dt@kernel.org,
kernel@pengutronix.de, Fabio Estevam <fabio.estevam@nxp.com>,
shawnguo@kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [RFC] ARM: dts: imx28-tx28: Pass the memory unit name
Date: Mon, 19 Feb 2018 13:06:24 +0100 [thread overview]
Message-ID: <20180219130624.30a5f572@karo-electronics.de> (raw)
In-Reply-To: <1518882103-17137-1-git-send-email-festevam@gmail.com>
Hi,
On Sat, 17 Feb 2018 13:41:43 -0200 Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@nxp.com>
>
> Pass the memory unit name in order to fix the following
> dtc warning with W=1:
>
> arch/arm/boot/dts/imx28-tx28.dtb: Warning (unit_address_vs_reg): Node /memory has a reg or ranges property, but no unit name
>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
> ---
> Hi,
>
> Currently the only dtc warnings observed with W=1 are the ones:
> Warning (unit_address_vs_reg): Node /memory has a reg or ranges property, but no unit name
>
> If this solution can be accepted I can clean all the other i.MX dts files.
>
> Please advise.
>
> arch/arm/boot/dts/imx28-tx28.dts | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/imx28-tx28.dts b/arch/arm/boot/dts/imx28-tx28.dts
> index 8a4f5bc..bbdf004 100644
> --- a/arch/arm/boot/dts/imx28-tx28.dts
> +++ b/arch/arm/boot/dts/imx28-tx28.dts
> @@ -65,8 +65,8 @@
> usbotg = &usb0;
> };
>
> - memory {
> - reg = <0 0>; /* will be filled in by U-Boot */
> + memory@40000000 {
> + reg = <0x40000000 0>; /* will be filled in by U-Boot */
> };
>
> onewire {
>
I have no objections to this change. U-Boot still finds the memory node
and puts the correct size into the 'reg' property.
Acked-by: Lothar Waßmann <LW@KARO-electronics.de>
Lothar Waßmann
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2018-02-19 12:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-17 15:41 [RFC] ARM: dts: imx28-tx28: Pass the memory unit name Fabio Estevam
2018-02-17 15:41 ` Fabio Estevam
2018-02-19 12:06 ` Lothar Waßmann [this message]
2018-02-19 12:06 ` Lothar Waßmann
2018-02-24 8:29 ` Shawn Guo
2018-02-24 8:29 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180219130624.30a5f572@karo-electronics.de \
--to=lw@karo-electronics.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.