From: Greg KH <gregkh@linuxfoundation.org>
To: "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Michael Ellerman <mpe@ellerman.id.au>,
stable@vger.kernel.org
Subject: Re: [PATCH v4.14 stable] powerpc: Fix DABR match on hash based
Date: Mon, 19 Feb 2018 17:26:51 +0100 [thread overview]
Message-ID: <20180219162651.GA26692@kroah.com> (raw)
In-Reply-To: <1518776444.nn0lqj1fi6.naveen@linux.ibm.com>
On Fri, Feb 16, 2018 at 03:51:40PM +0530, Naveen N. Rao wrote:
> Naveen N. Rao wrote:
> > From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> >
> > Commit 398a719d34a1 ("powerpc/mm: Update bits used to skip hash_page")
> > mistakenly dropped the DSISR_DABRMATCH bit from the mask of bit tested
> > to skip trying to hash a page.
> >
> > As a result, the DABR matches would no longer be detected.
> >
> > This adds it back. We open code it in the 2 places where it matters
> > rather than fold it into DSISR_BAD_FAULT_32S/64S because this isn't
> > technically a bad fault and while we would never hit it with the
> > current code, I prefer if page_fault_is_bad() didn't trigger on these.
> >
> > Fixes: 398a719d34a1 ("powerpc/mm: Update bits used to skip hash_page")
> > Cc: stable@vger.kernel.org # v4.14
> > Tested-by: Pedro Miraglia Franco de Carvalho <pedromfc@br.ibm.com>
> > Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
>
> Not quite sure if this is required, but:
> Signed-off-by: Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com>
Thanks, now queued up.
greg k-h
prev parent reply other threads:[~2018-02-19 16:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-16 9:54 [PATCH v4.14 stable] powerpc: Fix DABR match on hash based Naveen N. Rao
2018-02-16 10:21 ` Naveen N. Rao
2018-02-19 16:26 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180219162651.GA26692@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=benh@kernel.crashing.org \
--cc=mpe@ellerman.id.au \
--cc=naveen.n.rao@linux.vnet.ibm.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.