All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Takashi Iwai <tiwai@suse.de>
Cc: Andres Bertens <abertensu@yahoo.com>,
	ben@decadent.org.uk, stable@vger.kernel.org
Subject: Re: [PATCH v4.4.x] ALSA: seq: Fix regression by incorrect ioctl_mutex usages
Date: Mon, 19 Feb 2018 17:44:38 +0100	[thread overview]
Message-ID: <20180219164438.GA25145@kroah.com> (raw)
In-Reply-To: <20180219161601.24110-1-tiwai@suse.de>

On Mon, Feb 19, 2018 at 05:16:01PM +0100, Takashi Iwai wrote:
> This is the revised backport of the upstream commit
> b3defb791b26ea0683a93a4f49c77ec45ec96f10
> 
> We had another backport (e.g. 623e5c8ae32b in 4.4.115), but it applies
> the new mutex also to the code paths that are invoked via faked
> kernel-to-kernel ioctls.  As reported recently, this leads to a
> deadlock at suspend (or other scenarios triggering the kernel
> sequencer client).
> 
> This patch addresses the issue by taking the mutex only in the code
> paths invoked by user-space, just like the original fix patch does.
> 
> Reported-and-tested-by: Andres Bertens <abertensu@yahoo.com>
> Signed-off-by: Takashi Iwai <tiwai@suse.de>
> ---
> 
> Tagged as 4.4.x, but should be applied to other older kernels, too.
> 
>  sound/core/seq/seq_clientmgr.c | 15 +++++++--------
>  1 file changed, 7 insertions(+), 8 deletions(-)

Thanks for this, now queued up.

greg k-h

  parent reply	other threads:[~2018-02-19 16:48 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-19 16:16 [PATCH v4.4.x] ALSA: seq: Fix regression by incorrect ioctl_mutex usages Takashi Iwai
2018-02-19 16:44 ` Patch "ALSA: seq: Fix regression by incorrect ioctl_mutex usages" has been added to the 4.4-stable tree gregkh
2018-02-19 16:44 ` Greg Kroah-Hartman [this message]
2018-02-19 16:47 ` Patch "ALSA: seq: Fix regression by incorrect ioctl_mutex usages" has been added to the 3.18-stable tree gregkh
2018-02-20 17:59 ` [PATCH v4.4.x] ALSA: seq: Fix regression by incorrect ioctl_mutex usages Ben Hutchings

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180219164438.GA25145@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=abertensu@yahoo.com \
    --cc=ben@decadent.org.uk \
    --cc=stable@vger.kernel.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.