All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kubakici@wp.pl>
To: Jiri Pirko <jiri@resnulli.us>,
	"Samudrala, Sridhar" <sridhar.samudrala@intel.com>,
	Alexander Duyck <alexander.duyck@gmail.com>
Cc: "Duyck, Alexander H" <alexander.h.duyck@intel.com>,
	virtio-dev@lists.oasis-open.org,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Netdev <netdev@vger.kernel.org>,
	virtualization@lists.linux-foundation.org,
	Siwei Liu <loseweigh@gmail.com>,
	David Miller <davem@davemloft.net>
Subject: Re: [RFC PATCH v3 0/3] Enable virtio_net to act as a backup for a passthru device
Date: Tue, 20 Feb 2018 14:33:56 -0800	[thread overview]
Message-ID: <20180220143356.3467084d@cakuba.netronome.com> (raw)
In-Reply-To: <20180220201410.GF2031@nanopsycho>

On Tue, 20 Feb 2018 21:14:10 +0100, Jiri Pirko wrote:
> Yeah, I can see it now :( I guess that the ship has sailed and we are
> stuck with this ugly thing forever...
> 
> Could you at least make some common code that is shared in between
> netvsc and virtio_net so this is handled in exacly the same way in both?

IMHO netvsc is a vendor specific driver which made a mistake on what
behaviour it provides (or tried to align itself with Windows SR-IOV).
Let's not make a far, far more commonly deployed and important driver
(virtio) bug-compatible with netvsc.

To Jiri's initial comments, I feel the same way, in fact I've talked to
the NetworkManager guys to get auto-bonding based on MACs handled in
user space.  I think it may very well get done in next versions of NM,
but isn't done yet.  Stephen also raised the point that not everybody is
using NM.

  parent reply	other threads:[~2018-02-20 22:33 UTC|newest]

Thread overview: 121+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-16 18:11 [virtio-dev] [RFC PATCH v3 0/3] Enable virtio_net to act as a backup for a passthru device Sridhar Samudrala
2018-02-16 18:11 ` Sridhar Samudrala
2018-02-16 18:11 ` [virtio-dev] [RFC PATCH v3 1/3] virtio_net: Introduce VIRTIO_NET_F_BACKUP feature bit Sridhar Samudrala
2018-02-16 18:11   ` Sridhar Samudrala
2018-02-16 18:11 ` Sridhar Samudrala
2018-02-16 18:11 ` [RFC PATCH v3 2/3] virtio_net: Extend virtio to use VF datapath when available Sridhar Samudrala
2018-02-16 18:11 ` [virtio-dev] " Sridhar Samudrala
2018-02-16 18:11   ` Sridhar Samudrala
2018-02-17  3:04   ` Jakub Kicinski
2018-02-17  3:04   ` Jakub Kicinski
2018-02-17 17:41     ` Alexander Duyck
2018-02-16 18:11 ` [RFC PATCH v3 3/3] virtio_net: Enable alternate datapath without creating an additional netdev Sridhar Samudrala
2018-02-16 18:11 ` [virtio-dev] " Sridhar Samudrala
2018-02-16 18:11   ` Sridhar Samudrala
2018-02-17  2:38 ` [RFC PATCH v3 0/3] Enable virtio_net to act as a backup for a passthru device Jakub Kicinski
2018-02-17  2:38 ` Jakub Kicinski
2018-02-17 17:12   ` Alexander Duyck
2018-02-17 17:12   ` [virtio-dev] " Alexander Duyck
2018-02-17 17:12     ` Alexander Duyck
2018-02-19  6:11     ` Jakub Kicinski
2018-02-20 16:26       ` [virtio-dev] " Samudrala, Sridhar
2018-02-20 16:26         ` Samudrala, Sridhar
2018-02-20 16:26       ` Samudrala, Sridhar
2018-02-21 23:50     ` Siwei Liu
2018-02-21 23:50     ` [virtio-dev] " Siwei Liu
2018-02-21 23:50       ` Siwei Liu
2018-02-22  0:17       ` [virtio-dev] " Alexander Duyck
2018-02-22  0:17         ` Alexander Duyck
2018-02-22  1:59         ` [virtio-dev] " Siwei Liu
2018-02-22  1:59           ` Siwei Liu
2018-02-22  2:35           ` Samudrala, Sridhar
2018-02-22  2:35           ` [virtio-dev] " Samudrala, Sridhar
2018-02-22  2:35             ` Samudrala, Sridhar
2018-02-22  3:28             ` [virtio-dev] " Samudrala, Sridhar
2018-02-22  3:28               ` Samudrala, Sridhar
2018-02-23 22:22             ` [virtio-dev] " Siwei Liu
2018-02-23 22:22               ` Siwei Liu
2018-02-23 22:38               ` Jiri Pirko
2018-02-24  0:17                 ` [virtio-dev] " Siwei Liu
2018-02-24  0:17                   ` Siwei Liu
2018-02-22  1:59         ` Siwei Liu
2018-02-24  0:03         ` Stephen Hemminger
2018-02-25 22:17           ` Alexander Duyck
2018-02-25 22:17           ` [virtio-dev] " Alexander Duyck
2018-02-25 22:17             ` Alexander Duyck
2018-02-22  0:17       ` Alexander Duyck
2018-02-20 10:42 ` Jiri Pirko
2018-02-20 16:04   ` Alexander Duyck
2018-02-20 16:04   ` [virtio-dev] " Alexander Duyck
2018-02-20 16:04     ` Alexander Duyck
2018-02-20 16:29     ` Jiri Pirko
2018-02-20 17:14       ` Samudrala, Sridhar
2018-02-20 17:14       ` [virtio-dev] " Samudrala, Sridhar
2018-02-20 17:14         ` Samudrala, Sridhar
2018-02-20 20:14         ` Jiri Pirko
2018-02-20 21:02           ` [virtio-dev] " Alexander Duyck
2018-02-20 21:02             ` Alexander Duyck
2018-02-20 21:02           ` Alexander Duyck
2018-02-20 22:33           ` Jakub Kicinski [this message]
2018-02-21  9:51             ` Jiri Pirko
2018-02-21 15:56               ` [virtio-dev] " Alexander Duyck
2018-02-21 15:56                 ` Alexander Duyck
2018-02-21 16:11                 ` Jiri Pirko
2018-02-21 16:49                   ` Alexander Duyck
2018-02-21 16:49                   ` [virtio-dev] " Alexander Duyck
2018-02-21 16:49                     ` Alexander Duyck
2018-02-21 16:58                     ` Jiri Pirko
2018-02-21 17:56                       ` [virtio-dev] " Alexander Duyck
2018-02-21 17:56                         ` Alexander Duyck
2018-02-21 19:38                         ` Jiri Pirko
2018-02-21 20:57                           ` Alexander Duyck
2018-02-21 20:57                           ` [virtio-dev] " Alexander Duyck
2018-02-21 20:57                             ` Alexander Duyck
2018-02-22  2:02                             ` Jakub Kicinski
2018-02-22  2:15                               ` [virtio-dev] " Samudrala, Sridhar
2018-02-22  2:15                                 ` Samudrala, Sridhar
2018-02-22  2:15                               ` Samudrala, Sridhar
2018-02-22  8:11                             ` Jiri Pirko
2018-02-22 11:54                               ` Or Gerlitz
2018-02-22 13:07                                 ` Jiri Pirko
2018-02-22 15:30                                   ` [virtio-dev] " Alexander Duyck
2018-02-22 15:30                                     ` Alexander Duyck
2018-02-22 21:30                               ` [virtio-dev] " Alexander Duyck
2018-02-22 21:30                                 ` Alexander Duyck
2018-02-23 23:59                                 ` Stephen Hemminger
2018-02-25 22:21                                   ` [virtio-dev] " Alexander Duyck
2018-02-25 22:21                                     ` Alexander Duyck
2018-02-25 22:21                                   ` Alexander Duyck
2018-02-26  7:19                                   ` Jiri Pirko
2018-02-27  1:02                                     ` Stephen Hemminger
2018-02-27  1:18                                       ` [virtio-dev] " Michael S. Tsirkin
2018-02-27  1:18                                         ` Michael S. Tsirkin
2018-02-27  8:27                                         ` Jiri Pirko
2018-02-22 21:30                               ` Alexander Duyck
2018-02-21 17:56                       ` Alexander Duyck
2018-02-21 15:56               ` Alexander Duyck
2018-02-20 17:23       ` [virtio-dev] " Alexander Duyck
2018-02-20 17:23         ` Alexander Duyck
2018-02-20 19:53         ` Jiri Pirko
2018-02-27  8:49     ` Jiri Pirko
2018-02-27 21:16       ` Alexander Duyck
2018-02-27 21:16       ` [virtio-dev] " Alexander Duyck
2018-02-27 21:16         ` Alexander Duyck
2018-02-27 21:23         ` [virtio-dev] " Michael S. Tsirkin
2018-02-27 21:23           ` Michael S. Tsirkin
2018-02-27 21:41         ` Jakub Kicinski
2018-02-28  7:08           ` Jiri Pirko
2018-02-28 14:32             ` [virtio-dev] " Michael S. Tsirkin
2018-02-28 14:32               ` Michael S. Tsirkin
2018-02-28 15:11               ` Jiri Pirko
2018-02-28 15:45                 ` [virtio-dev] " Michael S. Tsirkin
2018-02-28 15:45                   ` Michael S. Tsirkin
2018-02-28 19:25                   ` Jiri Pirko
2018-02-28 20:48                     ` [virtio-dev] " Michael S. Tsirkin
2018-02-28 20:48                       ` Michael S. Tsirkin
2018-02-28 20:48                     ` Michael S. Tsirkin
2018-02-28 15:45                 ` Michael S. Tsirkin
2018-02-27 21:30       ` Michael S. Tsirkin
2018-02-27 21:30       ` [virtio-dev] " Michael S. Tsirkin
2018-02-27 21:30         ` Michael S. Tsirkin
  -- strict thread matches above, loose matches on Subject: below --
2018-02-16 18:11 Sridhar Samudrala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180220143356.3467084d@cakuba.netronome.com \
    --to=kubakici@wp.pl \
    --cc=alexander.duyck@gmail.com \
    --cc=alexander.h.duyck@intel.com \
    --cc=davem@davemloft.net \
    --cc=jiri@resnulli.us \
    --cc=loseweigh@gmail.com \
    --cc=mst@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=sridhar.samudrala@intel.com \
    --cc=virtio-dev@lists.oasis-open.org \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.