* [PATCH] domctl: revert double increment of domctl version
@ 2018-02-21 17:34 Olaf Hering
2018-02-21 17:38 ` Wei Liu
0 siblings, 1 reply; 5+ messages in thread
From: Olaf Hering @ 2018-02-21 17:34 UTC (permalink / raw)
To: Andrew Cooper, George Dunlap, Ian Jackson, Jan Beulich,
Konrad Rzeszutek Wilk, Stefano Stabellini, Tim Deegan, Wei Liu,
xen-devel
Cc: Olaf Hering
Xen 4.10 has XEN_DOMCTL_INTERFACE_VERSION 0xe, staging should be fine
with 0xf until the next release is prepared.
Signed-off-by: Olaf Hering <olaf@aepfle.de>
---
xen/include/public/domctl.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xen/include/public/domctl.h b/xen/include/public/domctl.h
index ec7a860afc..501c44230b 100644
--- a/xen/include/public/domctl.h
+++ b/xen/include/public/domctl.h
@@ -38,7 +38,7 @@
#include "hvm/save.h"
#include "memory.h"
-#define XEN_DOMCTL_INTERFACE_VERSION 0x00000010
+#define XEN_DOMCTL_INTERFACE_VERSION 0x0000000f
/*
* NB. xen_domctl.domain is an IN/OUT parameter for this operation.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] domctl: revert double increment of domctl version
2018-02-21 17:34 [PATCH] domctl: revert double increment of domctl version Olaf Hering
@ 2018-02-21 17:38 ` Wei Liu
2018-02-21 17:46 ` Olaf Hering
2018-02-21 17:53 ` Andrew Cooper
0 siblings, 2 replies; 5+ messages in thread
From: Wei Liu @ 2018-02-21 17:38 UTC (permalink / raw)
To: Olaf Hering
Cc: Stefano Stabellini, Wei Liu, George Dunlap, Andrew Cooper,
Ian Jackson, Tim Deegan, Jan Beulich, xen-devel
On Wed, Feb 21, 2018 at 06:34:22PM +0100, Olaf Hering wrote:
> Xen 4.10 has XEN_DOMCTL_INTERFACE_VERSION 0xe, staging should be fine
> with 0xf until the next release is prepared.
>
> Signed-off-by: Olaf Hering <olaf@aepfle.de>
> ---
> xen/include/public/domctl.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/xen/include/public/domctl.h b/xen/include/public/domctl.h
> index ec7a860afc..501c44230b 100644
> --- a/xen/include/public/domctl.h
> +++ b/xen/include/public/domctl.h
> @@ -38,7 +38,7 @@
> #include "hvm/save.h"
> #include "memory.h"
>
> -#define XEN_DOMCTL_INTERFACE_VERSION 0x00000010
> +#define XEN_DOMCTL_INTERFACE_VERSION 0x0000000f
>
The reason we bumped the number twice is because we want a dedicated
number to denote the recent security fix.
Wei.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] domctl: revert double increment of domctl version
2018-02-21 17:38 ` Wei Liu
@ 2018-02-21 17:46 ` Olaf Hering
2018-02-21 17:53 ` Andrew Cooper
1 sibling, 0 replies; 5+ messages in thread
From: Olaf Hering @ 2018-02-21 17:46 UTC (permalink / raw)
To: Wei Liu
Cc: Stefano Stabellini, George Dunlap, Andrew Cooper, Ian Jackson,
Tim Deegan, Jan Beulich, xen-devel
[-- Attachment #1.1: Type: text/plain, Size: 258 bytes --]
Am Wed, 21 Feb 2018 17:38:03 +0000
schrieb Wei Liu <wei.liu2@citrix.com>:
> The reason we bumped the number twice is because we want a dedicated
> number to denote the recent security fix.
Thanks, that was no clear from the commit messages.
Olaf
[-- Attachment #1.2: Digitale Signatur von OpenPGP --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 157 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] domctl: revert double increment of domctl version
2018-02-21 17:38 ` Wei Liu
2018-02-21 17:46 ` Olaf Hering
@ 2018-02-21 17:53 ` Andrew Cooper
2018-02-21 18:14 ` Olaf Hering
1 sibling, 1 reply; 5+ messages in thread
From: Andrew Cooper @ 2018-02-21 17:53 UTC (permalink / raw)
To: Wei Liu, Olaf Hering
Cc: Stefano Stabellini, George Dunlap, Ian Jackson, Tim Deegan,
xen-devel, Jan Beulich
On 21/02/18 17:38, Wei Liu wrote:
> On Wed, Feb 21, 2018 at 06:34:22PM +0100, Olaf Hering wrote:
>> Xen 4.10 has XEN_DOMCTL_INTERFACE_VERSION 0xe, staging should be fine
>> with 0xf until the next release is prepared.
>>
>> Signed-off-by: Olaf Hering <olaf@aepfle.de>
>> ---
>> xen/include/public/domctl.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/xen/include/public/domctl.h b/xen/include/public/domctl.h
>> index ec7a860afc..501c44230b 100644
>> --- a/xen/include/public/domctl.h
>> +++ b/xen/include/public/domctl.h
>> @@ -38,7 +38,7 @@
>> #include "hvm/save.h"
>> #include "memory.h"
>>
>> -#define XEN_DOMCTL_INTERFACE_VERSION 0x00000010
>> +#define XEN_DOMCTL_INTERFACE_VERSION 0x0000000f
>>
> The reason we bumped the number twice is because we want a dedicated
> number to denote the recent security fix.
The double bump is there because Jan insisted upon it, so there is a
number to burn if we decide to backport part of PV-in-PVH to Xen 4.10.
It is currently unused.
I continue to think that this is a mistake (which is backed up by
everyone else being confused about what is going on), and demonstrates
the ineffectiveness of the *_INTERFACE_VERSIONS in general.
~Andrew
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] domctl: revert double increment of domctl version
2018-02-21 17:53 ` Andrew Cooper
@ 2018-02-21 18:14 ` Olaf Hering
0 siblings, 0 replies; 5+ messages in thread
From: Olaf Hering @ 2018-02-21 18:14 UTC (permalink / raw)
To: Andrew Cooper
Cc: Stefano Stabellini, Wei Liu, George Dunlap, Tim Deegan,
Ian Jackson, xen-devel, Jan Beulich
[-- Attachment #1.1: Type: text/plain, Size: 416 bytes --]
Am Wed, 21 Feb 2018 17:53:54 +0000
schrieb Andrew Cooper <andrew.cooper3@citrix.com>:
> I continue to think that this is a mistake (which is backed up by
> everyone else being confused about what is going on), and demonstrates
> the ineffectiveness of the *_INTERFACE_VERSIONS in general.
Well, my change was cosmetic anyway.
I'm updating valgrind and noticed this small inconsistency in staging.
Olaf
[-- Attachment #1.2: Digitale Signatur von OpenPGP --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 157 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-02-21 18:14 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-02-21 17:34 [PATCH] domctl: revert double increment of domctl version Olaf Hering
2018-02-21 17:38 ` Wei Liu
2018-02-21 17:46 ` Olaf Hering
2018-02-21 17:53 ` Andrew Cooper
2018-02-21 18:14 ` Olaf Hering
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.