From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v3 2/5] keymap: use glib hash for kbd_layout_t
Date: Thu, 22 Feb 2018 09:11:08 +0000 [thread overview]
Message-ID: <20180222091108.GB9323@redhat.com> (raw)
In-Reply-To: <20180222070513.8740-3-kraxel@redhat.com>
On Thu, Feb 22, 2018 at 08:05:10AM +0100, Gerd Hoffmann wrote:
> Drop home-grown lookup code, which is a strange mix of a lookup table
> and a list. Use standard glib hash instead.
>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
> ui/keymaps.c | 73 ++++++++++++++++++++++++---------------------------------
> ui/trace-events | 2 +-
> 2 files changed, 32 insertions(+), 43 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2018-02-22 9:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-22 7:05 [Qemu-devel] [PATCH v3 0/5] keymap: support kbd layouts with multiple mappings for the same key Gerd Hoffmann
2018-02-22 7:05 ` [Qemu-devel] [PATCH v3 1/5] keymap: make struct kbd_layout_t private to ui/keymaps.c Gerd Hoffmann
2018-02-22 7:05 ` [Qemu-devel] [PATCH v3 2/5] keymap: use glib hash for kbd_layout_t Gerd Hoffmann
2018-02-22 9:11 ` Daniel P. Berrangé [this message]
2018-02-22 7:05 ` [Qemu-devel] [PATCH v3 3/5] keymap: numpad keysyms and keycodes are fixed Gerd Hoffmann
2018-02-22 7:05 ` [Qemu-devel] [PATCH v3 4/5] keymap: record multiple keysym -> keycode mappings Gerd Hoffmann
2018-02-22 7:05 ` [Qemu-devel] [PATCH v3 5/5] keymap: consider modifier state when picking a mapping Gerd Hoffmann
2018-12-18 18:45 ` Daniel P. Berrangé
2018-12-19 7:55 ` Gerd Hoffmann
2018-12-19 9:42 ` Gerd Hoffmann
2018-12-19 11:17 ` Daniel P. Berrangé
2018-12-19 15:59 ` Adam Williamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180222091108.GB9323@redhat.com \
--to=berrange@redhat.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.