All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: philippe.cornu@st.com
Cc: dri-devel@lists.freedesktop.org
Subject: [bug report] drm/stm: ltdc: add clut mode support
Date: Thu, 22 Feb 2018 22:27:19 +0300	[thread overview]
Message-ID: <20180222192719.GA31787@mwanda> (raw)

Hello Philippe CORNU,

This is a semi-automatic email about new static checker warnings.

The patch b706a25eaed0: "drm/stm: ltdc: add clut mode support" from 
Oct 26, 2017, leads to the following Smatch complaint:

    drivers/gpu/drm/stm/ltdc.c:395 ltdc_crtc_update_clut()
    warn: variable dereferenced before check 'crtc' (see line 390)

drivers/gpu/drm/stm/ltdc.c
   389	{
   390		struct ltdc_device *ldev = crtc_to_ltdc(crtc);
                                                        ^^^^
Dereferenced inside the function call

   391		struct drm_color_lut *lut;
   392		u32 val;
   393		int i;
   394	
   395		if (!crtc || !crtc->state)
                     ^^^^
Too late.

   396			return;
   397	

regards,
dan carpenter
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

             reply	other threads:[~2018-02-22 19:27 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-22 19:27 Dan Carpenter [this message]
2018-04-10 15:20 ` [bug report] drm/stm: ltdc: add clut mode support Philippe CORNU

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180222192719.GA31787@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=philippe.cornu@st.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.