* [bug report] drm/stm: ltdc: add clut mode support
@ 2018-02-22 19:27 Dan Carpenter
2018-04-10 15:20 ` Philippe CORNU
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2018-02-22 19:27 UTC (permalink / raw)
To: philippe.cornu; +Cc: dri-devel
Hello Philippe CORNU,
This is a semi-automatic email about new static checker warnings.
The patch b706a25eaed0: "drm/stm: ltdc: add clut mode support" from
Oct 26, 2017, leads to the following Smatch complaint:
drivers/gpu/drm/stm/ltdc.c:395 ltdc_crtc_update_clut()
warn: variable dereferenced before check 'crtc' (see line 390)
drivers/gpu/drm/stm/ltdc.c
389 {
390 struct ltdc_device *ldev = crtc_to_ltdc(crtc);
^^^^
Dereferenced inside the function call
391 struct drm_color_lut *lut;
392 u32 val;
393 int i;
394
395 if (!crtc || !crtc->state)
^^^^
Too late.
396 return;
397
regards,
dan carpenter
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [bug report] drm/stm: ltdc: add clut mode support
2018-02-22 19:27 [bug report] drm/stm: ltdc: add clut mode support Dan Carpenter
@ 2018-04-10 15:20 ` Philippe CORNU
0 siblings, 0 replies; 2+ messages in thread
From: Philippe CORNU @ 2018-04-10 15:20 UTC (permalink / raw)
To: Dan Carpenter; +Cc: dri-devel@lists.freedesktop.org
Hi Dan,
and many thanks for the bug report.
I sent a patch to fix this issue
https://patchwork.freedesktop.org/patch/216180/
Thank you,
Philippe :-)
On 02/22/2018 08:27 PM, Dan Carpenter wrote:
> Hello Philippe CORNU,
>
> This is a semi-automatic email about new static checker warnings.
>
> The patch b706a25eaed0: "drm/stm: ltdc: add clut mode support" from
> Oct 26, 2017, leads to the following Smatch complaint:
>
> drivers/gpu/drm/stm/ltdc.c:395 ltdc_crtc_update_clut()
> warn: variable dereferenced before check 'crtc' (see line 390)
>
> drivers/gpu/drm/stm/ltdc.c
> 389 {
> 390 struct ltdc_device *ldev = crtc_to_ltdc(crtc);
> ^^^^
> Dereferenced inside the function call
>
> 391 struct drm_color_lut *lut;
> 392 u32 val;
> 393 int i;
> 394
> 395 if (!crtc || !crtc->state)
> ^^^^
> Too late.
>
> 396 return;
> 397
>
> regards,
> dan carpenter
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-04-10 15:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-02-22 19:27 [bug report] drm/stm: ltdc: add clut mode support Dan Carpenter
2018-04-10 15:20 ` Philippe CORNU
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.