From: shawnguo@kernel.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/4] arm64: add basic Kconfig symbols for i.MX8
Date: Fri, 23 Feb 2018 22:56:27 +0800 [thread overview]
Message-ID: <20180223145625.GT3217@dragon> (raw)
In-Reply-To: <20180201183126.32384-1-l.stach@pengutronix.de>
On Thu, Feb 01, 2018 at 07:31:23PM +0100, Lucas Stach wrote:
> Add basic Kconfig symbols to make the MXC architecture available
> in the ARM64 world.
>
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>
> ---
> v2: fix "enabled" typo.
> ---
> arch/arm64/Kconfig.platforms | 6 ++++++
> drivers/soc/imx/Kconfig | 12 ++++++++++++
> 2 files changed, 18 insertions(+)
>
> diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
> index 2401373565ff..ae3be0d2cdb5 100644
> --- a/arch/arm64/Kconfig.platforms
> +++ b/arch/arm64/Kconfig.platforms
> @@ -131,6 +131,12 @@ config ARCH_MVEBU
> - Armada 7K SoC Family
> - Armada 8K SoC Family
>
> +config ARCH_MXC
> + bool "ARMv8 based NXP i.MX SoC family"
> + help
> + This enables support for the ARMv8 based SoCs in the
> + NXP i.MX family.
> +
> config ARCH_QCOM
> bool "Qualcomm Platforms"
> select GPIOLIB
> diff --git a/drivers/soc/imx/Kconfig b/drivers/soc/imx/Kconfig
> index a5b86a28f343..8c9f04440896 100644
> --- a/drivers/soc/imx/Kconfig
> +++ b/drivers/soc/imx/Kconfig
> @@ -8,3 +8,15 @@ config IMX7_PM_DOMAINS
> default y if SOC_IMX7D
>
> endmenu
> +
> +if ARCH_MXC
> +
> +if ARM64
> +
> +config SOC_IMX8MQ
> + bool "i.MX8MQ support"
> + help
> + This enables support for the i.MX8MQ SoC.
> +endif
> +
> +endif
I do not feel it's so idiomatic to select a platform SoC in drivers/soc
folder. The options in this folder are used to select SoC level drivers
not the SoC itself. Can we just use ARCH_MXC for all IMX ARMv8 SoCs?
Or if we really want individual SoC option, can we do something similar
to Renesas platform, having sub-select under "ARMv8 based NXP i.MX SoC
family"?
Shawn
WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org>
To: Lucas Stach <l.stach@pengutronix.de>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, Baruch Siach <baruch@tkos.co.il>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
patchwork-lst@pengutronix.de, Rob Herring <robh+dt@kernel.org>,
NXP Linux Team <linux-imx@nxp.com>,
kernel@pengutronix.de, Fabio Estevam <fabio.estevam@nxp.com>,
"A . s . Dong" <aisheng.dong@nxp.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 1/4] arm64: add basic Kconfig symbols for i.MX8
Date: Fri, 23 Feb 2018 22:56:27 +0800 [thread overview]
Message-ID: <20180223145625.GT3217@dragon> (raw)
In-Reply-To: <20180201183126.32384-1-l.stach@pengutronix.de>
On Thu, Feb 01, 2018 at 07:31:23PM +0100, Lucas Stach wrote:
> Add basic Kconfig symbols to make the MXC architecture available
> in the ARM64 world.
>
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>
> ---
> v2: fix "enabled" typo.
> ---
> arch/arm64/Kconfig.platforms | 6 ++++++
> drivers/soc/imx/Kconfig | 12 ++++++++++++
> 2 files changed, 18 insertions(+)
>
> diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
> index 2401373565ff..ae3be0d2cdb5 100644
> --- a/arch/arm64/Kconfig.platforms
> +++ b/arch/arm64/Kconfig.platforms
> @@ -131,6 +131,12 @@ config ARCH_MVEBU
> - Armada 7K SoC Family
> - Armada 8K SoC Family
>
> +config ARCH_MXC
> + bool "ARMv8 based NXP i.MX SoC family"
> + help
> + This enables support for the ARMv8 based SoCs in the
> + NXP i.MX family.
> +
> config ARCH_QCOM
> bool "Qualcomm Platforms"
> select GPIOLIB
> diff --git a/drivers/soc/imx/Kconfig b/drivers/soc/imx/Kconfig
> index a5b86a28f343..8c9f04440896 100644
> --- a/drivers/soc/imx/Kconfig
> +++ b/drivers/soc/imx/Kconfig
> @@ -8,3 +8,15 @@ config IMX7_PM_DOMAINS
> default y if SOC_IMX7D
>
> endmenu
> +
> +if ARCH_MXC
> +
> +if ARM64
> +
> +config SOC_IMX8MQ
> + bool "i.MX8MQ support"
> + help
> + This enables support for the i.MX8MQ SoC.
> +endif
> +
> +endif
I do not feel it's so idiomatic to select a platform SoC in drivers/soc
folder. The options in this folder are used to select SoC level drivers
not the SoC itself. Can we just use ARCH_MXC for all IMX ARMv8 SoCs?
Or if we really want individual SoC option, can we do something similar
to Renesas platform, having sub-select under "ARMv8 based NXP i.MX SoC
family"?
Shawn
next prev parent reply other threads:[~2018-02-23 14:56 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-01 18:31 [PATCH v2 1/4] arm64: add basic Kconfig symbols for i.MX8 Lucas Stach
2018-02-01 18:31 ` Lucas Stach
2018-02-01 18:31 ` [PATCH v2 2/4] arm64: add basic DTS for i.MX8MQ Lucas Stach
2018-02-01 18:31 ` Lucas Stach
2018-02-02 8:13 ` Jacky Bai
2018-02-02 8:13 ` Jacky Bai
2018-02-05 8:45 ` Shawn Guo
2018-02-05 8:45 ` Shawn Guo
2018-02-05 9:07 ` Jacky Bai
2018-02-05 9:07 ` Jacky Bai
2018-02-05 6:09 ` Rob Herring
2018-02-05 6:09 ` Rob Herring
2018-02-05 15:00 ` Marc Zyngier
2018-02-05 15:00 ` Marc Zyngier
2018-02-25 10:47 ` A.s. Dong
2018-02-25 10:47 ` A.s. Dong
2018-02-26 3:17 ` Shawn Guo
2018-02-26 3:17 ` Shawn Guo
2018-02-26 6:52 ` A.s. Dong
2018-02-26 6:52 ` A.s. Dong
2018-02-26 7:09 ` Shawn Guo
2018-02-26 7:09 ` Shawn Guo
2018-02-26 8:07 ` A.s. Dong
2018-02-26 8:07 ` A.s. Dong
2018-03-09 3:23 ` Shawn Guo
2018-03-09 3:23 ` Shawn Guo
2018-02-01 18:31 ` [PATCH v2 3/4] arm64: add support for i.MX8M EVK board Lucas Stach
2018-02-01 18:31 ` Lucas Stach
2018-02-05 6:09 ` Rob Herring
2018-02-05 6:09 ` Rob Herring
2018-02-05 7:24 ` Baruch Siach
2018-02-05 7:24 ` Baruch Siach
2018-02-05 11:10 ` Lucas Stach
2018-02-05 11:10 ` Lucas Stach
2018-02-23 3:46 ` Shawn Guo
2018-02-23 3:46 ` Shawn Guo
2018-02-23 4:32 ` Baruch Siach
2018-02-23 4:32 ` Baruch Siach
2018-02-23 7:05 ` Shawn Guo
2018-02-23 7:05 ` Shawn Guo
2018-02-23 15:03 ` Shawn Guo
2018-02-23 15:03 ` Shawn Guo
2018-02-23 15:30 ` Juergen Borleis
2018-02-23 15:30 ` Juergen Borleis
2018-02-23 15:46 ` Lucas Stach
2018-02-23 15:46 ` Lucas Stach
2018-02-24 2:58 ` Bough Chen
2018-02-24 2:58 ` Bough Chen
2018-02-24 6:00 ` Shawn Guo
2018-02-24 6:00 ` Shawn Guo
2018-02-25 9:54 ` A.s. Dong
2018-02-25 9:54 ` A.s. Dong
2018-02-23 15:45 ` Lucas Stach
2018-02-23 15:45 ` Lucas Stach
2018-02-25 10:00 ` A.s. Dong
2018-02-25 10:00 ` A.s. Dong
2018-02-01 18:31 ` [PATCH v2 4/4] MAINTAINERS: add i.MX8 DT path to i.MX architecture Lucas Stach
2018-02-01 18:31 ` Lucas Stach
2018-02-23 14:56 ` Shawn Guo [this message]
2018-02-23 14:56 ` [PATCH v2 1/4] arm64: add basic Kconfig symbols for i.MX8 Shawn Guo
2018-02-25 10:17 ` A.s. Dong
2018-02-25 10:17 ` A.s. Dong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180223145625.GT3217@dragon \
--to=shawnguo@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.