From: Jonathan Cameron <jic23@kernel.org>
To: Fabrice Gasnier <fabrice.gasnier@st.com>
Cc: <linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <mcoquelin.stm32@gmail.com>,
<alexandre.torgue@st.com>, <linux-iio@vger.kernel.org>,
<lars@metafoo.de>, <knaack.h@gmx.de>, <pmeerw@pmeerw.net>,
<benjamin.gaignard@linaro.org>, <arnaud.pouliquen@st.com>
Subject: Re: [PATCH 2/7] iio: adc: stm32-dfsdm: fix call to stop channel
Date: Sat, 24 Feb 2018 12:57:59 +0000 [thread overview]
Message-ID: <20180224125759.18678f8b@archlinux> (raw)
In-Reply-To: <1519390261-25453-3-git-send-email-fabrice.gasnier@st.com>
On Fri, 23 Feb 2018 13:50:56 +0100
Fabrice Gasnier <fabrice.gasnier@st.com> wrote:
> stm32_dfsdm_stop_channel must be called with channel id, not filter id.
>
> Fixes: e2e6771c6462 ("IIO: ADC: add STM32 DFSDM sigma delta ADC support")
>
> Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com>
Applied to the fixes-togreg branch of iio.git
Thanks,
Jonathan
> ---
> drivers/iio/adc/stm32-dfsdm-adc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/adc/stm32-dfsdm-adc.c b/drivers/iio/adc/stm32-dfsdm-adc.c
> index daa026d..0eff811 100644
> --- a/drivers/iio/adc/stm32-dfsdm-adc.c
> +++ b/drivers/iio/adc/stm32-dfsdm-adc.c
> @@ -464,7 +464,7 @@ static int stm32_dfsdm_start_conv(struct stm32_dfsdm_adc *adc, bool dma)
>
> regmap_update_bits(regmap, DFSDM_CR1(adc->fl_id),
> DFSDM_CR1_RCONT_MASK, 0);
> - stm32_dfsdm_stop_channel(adc->dfsdm, adc->fl_id);
> + stm32_dfsdm_stop_channel(adc->dfsdm, adc->ch_id);
>
> return ret;
> }
WARNING: multiple messages have this Message-ID (diff)
From: jic23@kernel.org (Jonathan Cameron)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/7] iio: adc: stm32-dfsdm: fix call to stop channel
Date: Sat, 24 Feb 2018 12:57:59 +0000 [thread overview]
Message-ID: <20180224125759.18678f8b@archlinux> (raw)
In-Reply-To: <1519390261-25453-3-git-send-email-fabrice.gasnier@st.com>
On Fri, 23 Feb 2018 13:50:56 +0100
Fabrice Gasnier <fabrice.gasnier@st.com> wrote:
> stm32_dfsdm_stop_channel must be called with channel id, not filter id.
>
> Fixes: e2e6771c6462 ("IIO: ADC: add STM32 DFSDM sigma delta ADC support")
>
> Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com>
Applied to the fixes-togreg branch of iio.git
Thanks,
Jonathan
> ---
> drivers/iio/adc/stm32-dfsdm-adc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/adc/stm32-dfsdm-adc.c b/drivers/iio/adc/stm32-dfsdm-adc.c
> index daa026d..0eff811 100644
> --- a/drivers/iio/adc/stm32-dfsdm-adc.c
> +++ b/drivers/iio/adc/stm32-dfsdm-adc.c
> @@ -464,7 +464,7 @@ static int stm32_dfsdm_start_conv(struct stm32_dfsdm_adc *adc, bool dma)
>
> regmap_update_bits(regmap, DFSDM_CR1(adc->fl_id),
> DFSDM_CR1_RCONT_MASK, 0);
> - stm32_dfsdm_stop_channel(adc->dfsdm, adc->fl_id);
> + stm32_dfsdm_stop_channel(adc->dfsdm, adc->ch_id);
>
> return ret;
> }
next prev parent reply other threads:[~2018-02-24 12:58 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-23 12:50 [PATCH 0/7] iio: adc: stm32-dfsdm: misc fixes and improvements Fabrice Gasnier
2018-02-23 12:50 ` Fabrice Gasnier
2018-02-23 12:50 ` [PATCH 1/7] iio: adc: stm32-dfsdm: fix compatible data use Fabrice Gasnier
2018-02-23 12:50 ` Fabrice Gasnier
2018-02-24 12:56 ` Jonathan Cameron
2018-02-24 12:56 ` Jonathan Cameron
2018-02-23 12:50 ` [PATCH 2/7] iio: adc: stm32-dfsdm: fix call to stop channel Fabrice Gasnier
2018-02-23 12:50 ` Fabrice Gasnier
2018-02-24 12:57 ` Jonathan Cameron [this message]
2018-02-24 12:57 ` Jonathan Cameron
2018-02-23 12:50 ` [PATCH 3/7] iio: adc: stm32-dfsdm: fix clock source selection Fabrice Gasnier
2018-02-23 12:50 ` Fabrice Gasnier
2018-02-24 12:59 ` Jonathan Cameron
2018-02-24 12:59 ` Jonathan Cameron
2018-02-23 12:50 ` [PATCH 4/7] iio: adc: stm32-dfsdm: fix multiple channel initialization Fabrice Gasnier
2018-02-23 12:50 ` Fabrice Gasnier
2018-02-24 13:01 ` Jonathan Cameron
2018-02-24 13:01 ` Jonathan Cameron
2018-02-23 12:50 ` [PATCH 5/7] iio: adc: stm32-dfsdm: misc style improvements and fixes Fabrice Gasnier
2018-02-23 12:50 ` Fabrice Gasnier
2018-02-24 13:03 ` Jonathan Cameron
2018-02-24 13:03 ` Jonathan Cameron
2018-02-27 8:21 ` Fabrice Gasnier
2018-02-27 8:21 ` Fabrice Gasnier
2018-03-03 15:09 ` Jonathan Cameron
2018-03-03 15:09 ` Jonathan Cameron
2018-04-23 7:48 ` Fabrice Gasnier
2018-04-23 7:48 ` Fabrice Gasnier
2018-04-28 14:52 ` Jonathan Cameron
2018-04-28 14:52 ` Jonathan Cameron
2018-02-23 12:51 ` [PATCH 6/7] iio: adc: stm32-dfsdm: add check on max filter id Fabrice Gasnier
2018-02-23 12:51 ` Fabrice Gasnier
2018-04-28 15:07 ` Jonathan Cameron
2018-04-28 15:07 ` Jonathan Cameron
2018-02-23 12:51 ` [PATCH 7/7] iio: adc: stm32-dfsdm: add check on spi-max-frequency Fabrice Gasnier
2018-02-23 12:51 ` Fabrice Gasnier
2018-04-28 15:07 ` Jonathan Cameron
2018-04-28 15:07 ` Jonathan Cameron
2018-02-23 13:49 ` [PATCH 0/7] iio: adc: stm32-dfsdm: misc fixes and improvements Arnaud Pouliquen
2018-02-23 13:49 ` Arnaud Pouliquen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180224125759.18678f8b@archlinux \
--to=jic23@kernel.org \
--cc=alexandre.torgue@st.com \
--cc=arnaud.pouliquen@st.com \
--cc=benjamin.gaignard@linaro.org \
--cc=fabrice.gasnier@st.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcoquelin.stm32@gmail.com \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.