Issue: Git Gui: show ssh key don't show key type id_ed25519.pub

Issue: Git Gui: show ssh key don't show key type id_ed25519.pub

[Fechter, Juergen]

Hello,

Maybe someone can fix this issue.
Thanks

Git Gui: show ssh key don't show key type id_ed25519.pub
Setup
. Which version of Git for Windows are you using? Is it 32-bit or 64-bit?
$ git --version --build-options

** 2.16.1windows.2 **

. Which version of Windows are you running? Vista, 7, 8, 10? Is it 32-bit or 64-bit?
$ cmd.exe /c ver

** Microsoft Windows [Version 10.0.16299.214] **
. What options did you set as part of the installation? Or did you choose the
defaults?
# One of the following:
> type "C:\Program Files\Git\etc\install-options.txt"
> type "C:\Program Files (x86)\Git\etc\install-options.txt"
> type "%USERPROFILE%\AppData\Local\Programs\Git\etc\install-options.txt"
$ cat /etc/install-options.txt

** insert your machine's response here **
. Any other interesting things about your environment that might be related
to the issue you're seeing?
** insert your response here **
Details
. Which terminal/shell are you running Git from? e.g Bash/CMD/PowerShell/other
** insert your response here **
. What commands did you run to trigger this issue? If you can provide a
http://stackoverflow.com/help/mcve
this will help us understand the issue.
** insert your commands here **
. What did you expect to occur after running these commands?
** insert here **
. What actually happened instead?
** insert here **
. If the problem was occurring with a specific repository, can you provide the
URL to that repository to help us with testing?
** insert URL here **
Description
Under ~/.ssh are only one ssh key pair of type ed25519
( id_ed25519 and id_ed25519.pub)
Git GUI don't show it
C:\Users\goldfinger2\.ssh>dir /b
agent.env
authorized_keys
id_ed25519
id_ed25519.pub
Win32-OpenSSH Beta currently supports only one key type (ed25519).
https://github.com/PowerShell/Win32-OpenSSH/issues/973
https://blogs.msdn.microsoft.com/powershell/2017/12/15/using-the-openssh-beta-in-windows-10-fall-creators-update-and-windows-server-1709/
Steps to Reproduce
1. Open Git Gui
2. Select Help
3. Show SSH Key : No Keys found
Expected behavior: Showing the ed25519 Key
Reproduces how often: 100%
Additional information
The problem is located in the find_ssh_key function in sshkey.tcl.
Which is not searching after id_ed25519.pub
find_ssh_key {} {

        foreach name {~/.ssh/id_dsa.pub ~/.ssh/id_rsa.pub ~/.ssh/identity.pub} {

>> This looks like a problem in upstream Git GUI. Would you mind reporting this to the Git mailing list at git@vger.kernel.org? 
>> Or even better, write the patch yourself? ;-) This looks like a problem in upstream Git GUI. 
>> Would you mind reporting this to the Git mailing list at git@vger.kernel.org? Or even better, write the patch yourself? ;-) 

[PATCH] git-gui: search for all current SSH key types

[Beat Bolli]

OpenSSH has supported Ed25519 keys since version 6.4 (2014-01-30), and
ECDSA keys since version 5.7 (2011-01-24). git-gui fails to find these
key types in its Help/Show SSH Key dialog.

Teach git-gui to show Ed25519 and ECDSA keys as well.

This was originally reported in
https://github.com/git-for-windows/git/issues/1487 and subseqently in
https://public-inbox.org/git/F65780F29E48994380E2BCE87C6F071101146AB1@DEERLM99EX2MSX.ww931.my-it-solutions.net/

Signed-off-by: Beat Bolli <dev+git@drbeat.li>
---
Cc: Alexander Gavrilov <angavrilov@gmail.com>
Cc: Pat Thoyts <patthoyts@users.sourceforge.net>

 git-gui/lib/sshkey.tcl | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/git-gui/lib/sshkey.tcl b/git-gui/lib/sshkey.tcl
index aa6457bbb..589ff8f78 100644
--- a/git-gui/lib/sshkey.tcl
+++ b/git-gui/lib/sshkey.tcl
@@ -2,7 +2,10 @@
 # Copyright (C) 2006, 2007 Shawn Pearce
 
 proc find_ssh_key {} {
-	foreach name {~/.ssh/id_dsa.pub ~/.ssh/id_rsa.pub ~/.ssh/identity.pub} {
+	foreach name {
+		~/.ssh/id_dsa.pub ~/.ssh/id_ecdsa.pub ~/.ssh/id_ed25519.pub
+		~/.ssh/id_rsa.pub ~/.ssh/identity.pub
+	} {
 		if {[file exists $name]} {
 			set fh    [open $name r]
 			set cont  [read $fh]
-- 
2.15.0.rc1.299.gda03b47c3