[PATCH v2] staging: use structure pointer to get the size of the structure

[PATCH v2] staging: use structure pointer to get the size of the structure

[Santha Meena Ramamoorthy]

Use pointer to the structure to get the size of the structure. Issue
found using checkpatch.

Signed-off-by: Santha Meena Ramamoorthy <santhameena13@gmail.com>
---
Change in v2:
 - Use single line when the number of characters is less than 80
 drivers/staging/rtl8192e/rtllib_wx.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8192e/rtllib_wx.c b/drivers/staging/rtl8192e/rtllib_wx.c
index 03fbff0..74d4d2d 100644
--- a/drivers/staging/rtl8192e/rtllib_wx.c
+++ b/drivers/staging/rtl8192e/rtllib_wx.c
@@ -371,8 +371,7 @@ int rtllib_wx_set_encode(struct rtllib_device *ieee,
 		struct lib80211_crypt_data *new_crypt;
 
 		/* take WEP into use */
-		new_crypt = kzalloc(sizeof(struct lib80211_crypt_data),
-				    GFP_KERNEL);
+		new_crypt = kzalloc(sizeof(*new_crypt), GFP_KERNEL);
 		if (new_crypt == NULL)
 			return -ENOMEM;
 		new_crypt->ops = lib80211_get_crypto_ops("R-WEP");
-- 
2.7.4

Re: [Outreachy kernel] [PATCH v2] staging: use structure pointer to get the size of the structure

[Hetavi (Haley) Shah]

[-- Attachment #1: Type: text/plain, Size: 1932 bytes --]

Hello,

I have recently found out about this project and would like to make some
contributions.

May I know what is the first contribution that I can start with?

Thank you,
Haley Shah.

On Sat, Feb 24, 2018 at 2:51 PM, Santha Meena Ramamoorthy <
santhameena13@gmail.com> wrote:

> Use pointer to the structure to get the size of the structure. Issue
> found using checkpatch.
>
> Signed-off-by: Santha Meena Ramamoorthy <santhameena13@gmail.com>
> ---
> Change in v2:
>  - Use single line when the number of characters is less than 80
>  drivers/staging/rtl8192e/rtllib_wx.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8192e/rtllib_wx.c
> b/drivers/staging/rtl8192e/rtllib_wx.c
> index 03fbff0..74d4d2d 100644
> --- a/drivers/staging/rtl8192e/rtllib_wx.c
> +++ b/drivers/staging/rtl8192e/rtllib_wx.c
> @@ -371,8 +371,7 @@ int rtllib_wx_set_encode(struct rtllib_device *ieee,
>                 struct lib80211_crypt_data *new_crypt;
>
>                 /* take WEP into use */
> -               new_crypt = kzalloc(sizeof(struct lib80211_crypt_data),
> -                                   GFP_KERNEL);
> +               new_crypt = kzalloc(sizeof(*new_crypt), GFP_KERNEL);
>                 if (new_crypt == NULL)
>                         return -ENOMEM;
>                 new_crypt->ops = lib80211_get_crypto_ops("R-WEP");
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups
> "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/
> msgid/outreachy-kernel/1519505516-10389-1-git-send-
> email-santhameena13%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>

[-- Attachment #2: Type: text/html, Size: 3043 bytes --]

Re: [Outreachy kernel] [PATCH v2] staging: use structure pointer to get the size of the structure

[Julia Lawall]

[-- Attachment #1: Type: text/plain, Size: 547 bytes --]



On Sat, 24 Feb 2018, Hetavi (Haley) Shah wrote:

> Hello,
> I have recently found out about this project and would like to make some
> contributions. 
>
> May I know what is the first contribution that I can start with?

Please start by reading and working through the tutorial that is linked to
in the outreachy page: https://kernelnewbies.org/Outreachyfirstpatch

Also, please don't respond to random mails with questions about other
topics.  It is particularly confusing to see a mail that has a PATCH
subject line and is not a patch.

julia

Re: [Outreachy kernel] [PATCH v2] staging: use structure pointer to get the size of the structure

[Julia Lawall]

Sorry for not noticing this before, but the subject line needs to be more
specific than staging.  Use git log --oneline on the file to see what
others have done before.

On Sat, 24 Feb 2018, Santha Meena Ramamoorthy wrote:

> Use pointer to the structure to get the size of the structure.

It would also be good to say why this is a good idea.  The code remains
correct even if the type changes.

Also, it looks liek you have not followed the get_maintainer call
suggested in the tutorial.  Greg is the only maintainer listed on this
code.

julia

> Issue
> found using checkpatch.
>
> Signed-off-by: Santha Meena Ramamoorthy <santhameena13@gmail.com>
> ---
> Change in v2:
>  - Use single line when the number of characters is less than 80
>  drivers/staging/rtl8192e/rtllib_wx.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8192e/rtllib_wx.c b/drivers/staging/rtl8192e/rtllib_wx.c
> index 03fbff0..74d4d2d 100644
> --- a/drivers/staging/rtl8192e/rtllib_wx.c
> +++ b/drivers/staging/rtl8192e/rtllib_wx.c
> @@ -371,8 +371,7 @@ int rtllib_wx_set_encode(struct rtllib_device *ieee,
>  		struct lib80211_crypt_data *new_crypt;
>
>  		/* take WEP into use */
> -		new_crypt = kzalloc(sizeof(struct lib80211_crypt_data),
> -				    GFP_KERNEL);
> +		new_crypt = kzalloc(sizeof(*new_crypt), GFP_KERNEL);
>  		if (new_crypt == NULL)
>  			return -ENOMEM;
>  		new_crypt->ops = lib80211_get_crypto_ops("R-WEP");
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1519505516-10389-1-git-send-email-santhameena13%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>

Re: [Outreachy kernel] [PATCH v2] staging: use structure pointer to get the size of the structure

[Santha Meena Ramamoorthy]

On Sat, Feb 24, 2018 at 10:03:54PM +0100, Julia Lawall wrote:
> Sorry for not noticing this before, but the subject line needs to be more
> specific than staging.  Use git log --oneline on the file to see what
> others have done before.
> 
> On Sat, 24 Feb 2018, Santha Meena Ramamoorthy wrote:
> 
> > Use pointer to the structure to get the size of the structure.
> 
> It would also be good to say why this is a good idea.  The code remains
> correct even if the type changes.
> 
> Also, it looks liek you have not followed the get_maintainer call
> suggested in the tutorial.  Greg is the only maintainer listed on this
> code.
> 
> julia

Sorry, I'll fix them now. 

Thanks,
Santha 
> 
> > Issue
> > found using checkpatch.
> >
> > Signed-off-by: Santha Meena Ramamoorthy <santhameena13@gmail.com>
> > ---
> > Change in v2:
> >  - Use single line when the number of characters is less than 80
> >  drivers/staging/rtl8192e/rtllib_wx.c | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/drivers/staging/rtl8192e/rtllib_wx.c b/drivers/staging/rtl8192e/rtllib_wx.c
> > index 03fbff0..74d4d2d 100644
> > --- a/drivers/staging/rtl8192e/rtllib_wx.c
> > +++ b/drivers/staging/rtl8192e/rtllib_wx.c
> > @@ -371,8 +371,7 @@ int rtllib_wx_set_encode(struct rtllib_device *ieee,
> >  		struct lib80211_crypt_data *new_crypt;
> >
> >  		/* take WEP into use */
> > -		new_crypt = kzalloc(sizeof(struct lib80211_crypt_data),
> > -				    GFP_KERNEL);
> > +		new_crypt = kzalloc(sizeof(*new_crypt), GFP_KERNEL);
> >  		if (new_crypt == NULL)
> >  			return -ENOMEM;
> >  		new_crypt->ops = lib80211_get_crypto_ops("R-WEP");
> > --
> > 2.7.4
> >
> > --
> > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > To post to this group, send email to outreachy-kernel@googlegroups.com.
> > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1519505516-10389-1-git-send-email-santhameena13%40gmail.com.
> > For more options, visit https://groups.google.com/d/optout.
> >