From: dvhart at infradead.org (Darren Hart)
Subject: [PATCH 5/5] selftests: futex Makefile add top level TAP header echo to RUN_TESTS
Date: Sat, 24 Feb 2018 13:42:44 -0800 [thread overview]
Message-ID: <20180224214244.GA31352@fury> (raw)
In-Reply-To: <bec2e6c01cbf3b2f6dc49e022a2a7543fc7f3182.1519423341.git.shuahkh@osg.samsung.com>
On Fri, Feb 23, 2018 at 03:11:40PM -0700, Shuah Khan wrote:
> Add top level TAP header echo, testname and separator line to make
> the output consistent with the common run_tests target.
No objection to the changes, but I'll echo Ingo's request for a more
detailed justification for why these changes are warranted. We've seen
this a few times with recent changes to kselftests, I think too much
might be being assumed regarding the individual test author's tracking
of the core of the kselftests ongoing work.
>
> Signed-off-by: Shuah Khan <shuahkh at osg.samsung.com>
> ---
> tools/testing/selftests/futex/Makefile | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/tools/testing/selftests/futex/Makefile b/tools/testing/selftests/futex/Makefile
> index cea4adcd42b8..3e9a9d7b4de1 100644
> --- a/tools/testing/selftests/futex/Makefile
> +++ b/tools/testing/selftests/futex/Makefile
> @@ -18,6 +18,9 @@ all:
> done
>
> override define RUN_TESTS
> + @echo "TAP version 13";
> + @echo "selftests: futex";
> + @echo "========================================";
> @cd $(OUTPUT); ./run.sh
> endef
>
> --
> 2.14.1
>
>
--
Darren Hart
VMware Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: dvhart@infradead.org (Darren Hart)
Subject: [PATCH 5/5] selftests: futex Makefile add top level TAP header echo to RUN_TESTS
Date: Sat, 24 Feb 2018 13:42:44 -0800 [thread overview]
Message-ID: <20180224214244.GA31352@fury> (raw)
Message-ID: <20180224214244.Z9TmPVxAKwbtZpJyljYCoLVYcVq1LkwYPDaS25cNdaQ@z> (raw)
In-Reply-To: <bec2e6c01cbf3b2f6dc49e022a2a7543fc7f3182.1519423341.git.shuahkh@osg.samsung.com>
On Fri, Feb 23, 2018@03:11:40PM -0700, Shuah Khan wrote:
> Add top level TAP header echo, testname and separator line to make
> the output consistent with the common run_tests target.
No objection to the changes, but I'll echo Ingo's request for a more
detailed justification for why these changes are warranted. We've seen
this a few times with recent changes to kselftests, I think too much
might be being assumed regarding the individual test author's tracking
of the core of the kselftests ongoing work.
>
> Signed-off-by: Shuah Khan <shuahkh at osg.samsung.com>
> ---
> tools/testing/selftests/futex/Makefile | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/tools/testing/selftests/futex/Makefile b/tools/testing/selftests/futex/Makefile
> index cea4adcd42b8..3e9a9d7b4de1 100644
> --- a/tools/testing/selftests/futex/Makefile
> +++ b/tools/testing/selftests/futex/Makefile
> @@ -18,6 +18,9 @@ all:
> done
>
> override define RUN_TESTS
> + @echo "TAP version 13";
> + @echo "selftests: futex";
> + @echo "========================================";
> @cd $(OUTPUT); ./run.sh
> endef
>
> --
> 2.14.1
>
>
--
Darren Hart
VMware Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Darren Hart <dvhart@infradead.org>
To: Shuah Khan <shuahkh@osg.samsung.com>
Cc: shuah@kernel.org, tbird20d@gmail.com, tglx@linutronix.de,
mingo@redhat.com, peterz@infradead.org,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH 5/5] selftests: futex Makefile add top level TAP header echo to RUN_TESTS
Date: Sat, 24 Feb 2018 13:42:44 -0800 [thread overview]
Message-ID: <20180224214244.GA31352@fury> (raw)
In-Reply-To: <bec2e6c01cbf3b2f6dc49e022a2a7543fc7f3182.1519423341.git.shuahkh@osg.samsung.com>
On Fri, Feb 23, 2018 at 03:11:40PM -0700, Shuah Khan wrote:
> Add top level TAP header echo, testname and separator line to make
> the output consistent with the common run_tests target.
No objection to the changes, but I'll echo Ingo's request for a more
detailed justification for why these changes are warranted. We've seen
this a few times with recent changes to kselftests, I think too much
might be being assumed regarding the individual test author's tracking
of the core of the kselftests ongoing work.
>
> Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
> ---
> tools/testing/selftests/futex/Makefile | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/tools/testing/selftests/futex/Makefile b/tools/testing/selftests/futex/Makefile
> index cea4adcd42b8..3e9a9d7b4de1 100644
> --- a/tools/testing/selftests/futex/Makefile
> +++ b/tools/testing/selftests/futex/Makefile
> @@ -18,6 +18,9 @@ all:
> done
>
> override define RUN_TESTS
> + @echo "TAP version 13";
> + @echo "selftests: futex";
> + @echo "========================================";
> @cd $(OUTPUT); ./run.sh
> endef
>
> --
> 2.14.1
>
>
--
Darren Hart
VMware Open Source Technology Center
next prev parent reply other threads:[~2018-02-24 21:42 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-23 22:11 [PATCH 0/5] Handling for TAP header level shuahkh
2018-02-23 22:11 ` Shuah Khan
2018-02-23 22:11 ` Shuah Khan
2018-02-23 22:11 ` [PATCH 1/5] selftests: kselftest framework: add handling " shuahkh
2018-02-23 22:11 ` Shuah Khan
2018-02-23 22:11 ` Shuah Khan
2018-02-23 22:11 ` [PATCH 2/5] selftests: lib.mk set KSFT_TAP_LEVEL to prevent nested TAP headers shuahkh
2018-02-23 22:11 ` Shuah Khan
2018-02-23 22:11 ` Shuah Khan
2018-02-23 22:11 ` [PATCH 3/5] selftests: Makefile " shuahkh
2018-02-23 22:11 ` Shuah Khan
2018-02-23 22:11 ` Shuah Khan
2018-02-23 22:11 ` [PATCH 4/5] selftests: size call ksft_print_header() to print TAP header shuahkh
2018-02-23 22:11 ` Shuah Khan
2018-02-23 22:11 ` Shuah Khan
2018-02-23 22:11 ` [PATCH 5/5] selftests: futex Makefile add top level TAP header echo to RUN_TESTS shuahkh
2018-02-23 22:11 ` Shuah Khan
2018-02-23 22:11 ` Shuah Khan
2018-02-24 21:42 ` dvhart [this message]
2018-02-24 21:42 ` Darren Hart
2018-02-24 21:42 ` Darren Hart
2018-02-27 17:25 ` shuahkh
2018-02-27 17:25 ` Shuah Khan
2018-02-27 17:25 ` Shuah Khan
2018-03-06 0:17 ` dvhart
2018-03-06 0:17 ` Darren Hart
2018-03-06 0:17 ` Darren Hart
2018-02-24 8:39 ` [PATCH 0/5] Handling for TAP header level mingo
2018-02-24 8:39 ` Ingo Molnar
2018-02-24 8:39 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180224214244.GA31352@fury \
--to=unknown@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.