All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lukas Wunner <lukas@wunner.de>
To: Meghana Madhyastha <meghana.madhyastha@gmail.com>
Cc: dri-devel@lists.freedesktop.org, linux-spi@vger.kernel.org,
	linux-rpi-kernel@lists.infradead.org,
	Daniel Vetter <daniel.vetter@intel.com>,
	kernel@martin.sperl.org
Subject: Re: [PATCH v2 0/2] Chunk splitting of spi transfers
Date: Sun, 25 Feb 2018 14:19:10 +0100	[thread overview]
Message-ID: <20180225131910.GA22086@wunner.de> (raw)
In-Reply-To: <cover.1519492575.git.meghana.madhyastha@gmail.com>

[cc += linux-rpi-kernel@lists.infradead.org]

On Sat, Feb 24, 2018 at 06:15:59PM +0000, Meghana Madhyastha wrote:
> I've added bcm2835_spi_transfer_one_message in spi-bcm2835. This calls
> spi_split_transfers_maxsize to split large chunks for spi dma transfers. 
> I then removed chunk splitting in the tinydrm spi helper (as now the core
> is handling the chunk splitting). However, although the SPI HW should be
> able to accomodate up to 65535 bytes for dma transfers, the splitting of
> chunks to 65535 bytes results in a dma transfer time out error. However,
> when the chunks are split to < 64 bytes it seems to work fine.

Hm, that is really odd, how did you test this exactly, what did you
use as SPI slave?  It contradicts our own experience, we're using
Micrel KSZ8851 Ethernet chips as SPI slave on spi0 of a BCM2837
and can send/receive messages via DMA to the tune of several hundred
bytes without any issues.  In fact, for messages < 96 bytes, DMA is
not used at all, so you've probably been using interrupt mode,
see the BCM2835_SPI_DMA_MIN_LENGTH macro in spi-bcm2835.c.

Thanks,

Lukas
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2018-02-25 13:19 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-24 18:15 [PATCH v2 0/2] Chunk splitting of spi transfers Meghana Madhyastha
2018-02-24 18:16 ` [PATCH v2 1/2] drm/tinydrm: Remove chunk splitting in tinydrm_spi_transfer Meghana Madhyastha
2018-02-25 17:03   ` Lukas Wunner
2018-02-27 17:39     ` Noralf Trønnes
2018-02-24 18:17 ` [PATCH v2 2/2] spi/spi-bcm2835: Add bcm2835_spi_transfer_one_message in spi-bcm2835.c Meghana Madhyastha
2018-02-25 16:49   ` Lukas Wunner
2018-02-25 13:19 ` Lukas Wunner [this message]
2018-02-27 17:40   ` [PATCH v2 0/2] Chunk splitting of spi transfers Noralf Trønnes
2018-03-02 11:11   ` Meghana Madhyastha
2018-03-04 17:38     ` Noralf Trønnes
  -- strict thread matches above, loose matches on Subject: below --
2018-03-10 15:50 Meghana Madhyastha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180225131910.GA22086@wunner.de \
    --to=lukas@wunner.de \
    --cc=daniel.vetter@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=kernel@martin.sperl.org \
    --cc=linux-rpi-kernel@lists.infradead.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=meghana.madhyastha@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.