Re: [PATCH v2 2/2] spi/spi-bcm2835: Add bcm2835_spi_transfer_one_message in spi-bcm2835.c

From: Lukas Wunner <lukas@wunner.de>
To: Meghana Madhyastha <meghana.madhyastha@gmail.com>
Cc: dri-devel@lists.freedesktop.org, linux-spi@vger.kernel.org,
	linux-rpi-kernel@lists.infradead.org,
	Daniel Vetter <daniel.vetter@intel.com>,
	kernel@martin.sperl.org
Subject: Re: [PATCH v2 2/2] spi/spi-bcm2835: Add bcm2835_spi_transfer_one_message in spi-bcm2835.c
Date: Sun, 25 Feb 2018 17:49:03 +0100	[thread overview]
Message-ID: <20180225164903.GA7348@wunner.de> (raw)
In-Reply-To: <91a77832e7d4c5ca5f5ec6f81251922ee8019e77.1519492575.git.meghana.madhyastha@gmail.com>

On Sat, Feb 24, 2018 at 06:17:12PM +0000, Meghana Madhyastha wrote:
> --- a/drivers/spi/spi.c
> +++ b/drivers/spi/spi.c
> @@ -1003,7 +1003,7 @@ static int spi_map_msg(struct spi_controller *ctlr, struct spi_message *msg)
>   * drivers which implement a transfer_one() operation.  It provides
>   * standard handling of delays and chip select management.
>   */
> -static int spi_transfer_one_message(struct spi_controller *ctlr,
> +int spi_transfer_one_message(struct spi_controller *ctlr,

An alternative to exporting this function would be to have it check
if any of the transfers in the message exceed ctlr->max_dma_len,
and automatically split those.  That's for Mark to decide.

>  		if (xfer->tx_buf || xfer->rx_buf) {
>  			reinit_completion(&ctlr->xfer_completion);
> -

Spurious deleted newline.

>  	/* calculate how many we have to replace */
>  	count = DIV_ROUND_UP(xfer->len, maxsize);
> -

Another one.

Thanks,

Lukas
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel