All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] staging: rtl8192u: Fix alignements in 'if' statements
@ 2018-02-25 19:59 Dafna Hirschfeld
  2018-02-25 20:10 ` [Outreachy kernel] " Julia Lawall
  0 siblings, 1 reply; 2+ messages in thread
From: Dafna Hirschfeld @ 2018-02-25 19:59 UTC (permalink / raw)
  To: gregkh; +Cc: outreachy-kernel

Fix aligement in two 'if' statements and break lines
to avoid over 80 characters lines.
Issues found with coccicheck.

Signed-off-by: Dafna Hirschfeld <dafna3@gmail.com>
---
 drivers/staging/rtl8192u/ieee80211/rtl819x_BAProc.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_BAProc.c b/drivers/staging/rtl8192u/ieee80211/rtl819x_BAProc.c
index 21b55fd..86c7357 100644
--- a/drivers/staging/rtl8192u/ieee80211/rtl819x_BAProc.c
+++ b/drivers/staging/rtl8192u/ieee80211/rtl819x_BAProc.c
@@ -195,7 +195,9 @@ static struct sk_buff *ieee80211_DELBA(
 	u16 len = 6 + ieee->tx_headroom;
 
 	if (net_ratelimit())
-	IEEE80211_DEBUG(IEEE80211_DL_TRACE | IEEE80211_DL_BA, "========>%s(), ReasonCode(%d) sentd to:%pM\n", __func__, ReasonCode, dst);
+		IEEE80211_DEBUG(IEEE80211_DL_TRACE | IEEE80211_DL_BA,
+				"========>%s(), ReasonCode(%d) sentd to:%pM\n",
+				__func__, ReasonCode, dst);
 
 	memset(&DelbaParamSet, 0, 2);
 
@@ -233,7 +235,8 @@ static struct sk_buff *ieee80211_DELBA(
 
 	IEEE80211_DEBUG_DATA(IEEE80211_DL_DATA|IEEE80211_DL_BA, skb->data, skb->len);
 	if (net_ratelimit())
-	IEEE80211_DEBUG(IEEE80211_DL_TRACE | IEEE80211_DL_BA, "<=====%s()\n", __func__);
+		IEEE80211_DEBUG(IEEE80211_DL_TRACE | IEEE80211_DL_BA,
+				"<=====%s()\n", __func__);
 	return skb;
 }
 
-- 
2.7.4



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [Outreachy kernel] [PATCH] staging: rtl8192u: Fix alignements in 'if' statements
  2018-02-25 19:59 [PATCH] staging: rtl8192u: Fix alignements in 'if' statements Dafna Hirschfeld
@ 2018-02-25 20:10 ` Julia Lawall
  0 siblings, 0 replies; 2+ messages in thread
From: Julia Lawall @ 2018-02-25 20:10 UTC (permalink / raw)
  To: Dafna Hirschfeld; +Cc: gregkh, outreachy-kernel



On Sun, 25 Feb 2018, Dafna Hirschfeld wrote:

> Fix aligement in two 'if' statements and break lines
> to avoid over 80 characters lines.
> Issues found with coccicheck.

The change looks good.  Could you fix the random spelling of "alignment"
(two cases)?

julia

>
> Signed-off-by: Dafna Hirschfeld <dafna3@gmail.com>
> ---
>  drivers/staging/rtl8192u/ieee80211/rtl819x_BAProc.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_BAProc.c b/drivers/staging/rtl8192u/ieee80211/rtl819x_BAProc.c
> index 21b55fd..86c7357 100644
> --- a/drivers/staging/rtl8192u/ieee80211/rtl819x_BAProc.c
> +++ b/drivers/staging/rtl8192u/ieee80211/rtl819x_BAProc.c
> @@ -195,7 +195,9 @@ static struct sk_buff *ieee80211_DELBA(
>  	u16 len = 6 + ieee->tx_headroom;
>
>  	if (net_ratelimit())
> -	IEEE80211_DEBUG(IEEE80211_DL_TRACE | IEEE80211_DL_BA, "========>%s(), ReasonCode(%d) sentd to:%pM\n", __func__, ReasonCode, dst);
> +		IEEE80211_DEBUG(IEEE80211_DL_TRACE | IEEE80211_DL_BA,
> +				"========>%s(), ReasonCode(%d) sentd to:%pM\n",
> +				__func__, ReasonCode, dst);
>
>  	memset(&DelbaParamSet, 0, 2);
>
> @@ -233,7 +235,8 @@ static struct sk_buff *ieee80211_DELBA(
>
>  	IEEE80211_DEBUG_DATA(IEEE80211_DL_DATA|IEEE80211_DL_BA, skb->data, skb->len);
>  	if (net_ratelimit())
> -	IEEE80211_DEBUG(IEEE80211_DL_TRACE | IEEE80211_DL_BA, "<=====%s()\n", __func__);
> +		IEEE80211_DEBUG(IEEE80211_DL_TRACE | IEEE80211_DL_BA,
> +				"<=====%s()\n", __func__);
>  	return skb;
>  }
>
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20180225195922.GA15403%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-02-25 20:10 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-02-25 19:59 [PATCH] staging: rtl8192u: Fix alignements in 'if' statements Dafna Hirschfeld
2018-02-25 20:10 ` [Outreachy kernel] " Julia Lawall

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.