From: shawnguo@kernel.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: dts: ls1046a: drop incomplete memory node
Date: Mon, 26 Feb 2018 12:35:33 +0800 [thread overview]
Message-ID: <20180226043532.GT3217@dragon> (raw)
In-Reply-To: <AM4PR0401MB1699AD47DE96B4299F680E498FC10@AM4PR0401MB1699.eurprd04.prod.outlook.com>
On Mon, Feb 26, 2018 at 01:33:34AM +0000, Leo Li wrote:
>
>
> > -----Original Message-----
> > From: Shawn Guo [mailto:shawnguo at kernel.org]
> > Sent: Saturday, February 24, 2018 3:05 PM
> > To: linux-arm-kernel at lists.infradead.org
> > Cc: devicetree at vger.kernel.org; Shawn Guo <shawnguo@kernel.org>;
> > Mingkai Hu <mingkai.hu@nxp.com>; Shaohui Xie <Shaohui.Xie@nxp.com>;
> > Leo Li <leoyang.li@nxp.com>
> > Subject: [PATCH] arm64: dts: ls1046a: drop incomplete memory node
> >
> > The memory node in fsl-ls1046a.dtsi has no 'reg' property, and causes the
> > dtc warning below.
> >
> > Warning (unit_address_vs_reg): Node /memory at 80000000 has a unit name,
> > but no reg property
> >
> > This is clearly an incomplete memory node. Let's drop it. Either a complete
> > memory should be added, or bootloader needs to fill the node as a whole.
>
> Or we can put in a dummy reg property to be updated by bootloader like the mac-address property?
Yeah, I'm fine with either way, as long as we get rid of the warning.
I will post v2 shortly.
Shawn
WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org>
To: Leo Li <leoyang.li@nxp.com>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Mingkai Hu <mingkai.hu@nxp.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Shaohui Xie <Shaohui.Xie@nxp.com>
Subject: Re: [PATCH] arm64: dts: ls1046a: drop incomplete memory node
Date: Mon, 26 Feb 2018 12:35:33 +0800 [thread overview]
Message-ID: <20180226043532.GT3217@dragon> (raw)
In-Reply-To: <AM4PR0401MB1699AD47DE96B4299F680E498FC10@AM4PR0401MB1699.eurprd04.prod.outlook.com>
On Mon, Feb 26, 2018 at 01:33:34AM +0000, Leo Li wrote:
>
>
> > -----Original Message-----
> > From: Shawn Guo [mailto:shawnguo@kernel.org]
> > Sent: Saturday, February 24, 2018 3:05 PM
> > To: linux-arm-kernel@lists.infradead.org
> > Cc: devicetree@vger.kernel.org; Shawn Guo <shawnguo@kernel.org>;
> > Mingkai Hu <mingkai.hu@nxp.com>; Shaohui Xie <Shaohui.Xie@nxp.com>;
> > Leo Li <leoyang.li@nxp.com>
> > Subject: [PATCH] arm64: dts: ls1046a: drop incomplete memory node
> >
> > The memory node in fsl-ls1046a.dtsi has no 'reg' property, and causes the
> > dtc warning below.
> >
> > Warning (unit_address_vs_reg): Node /memory@80000000 has a unit name,
> > but no reg property
> >
> > This is clearly an incomplete memory node. Let's drop it. Either a complete
> > memory should be added, or bootloader needs to fill the node as a whole.
>
> Or we can put in a dummy reg property to be updated by bootloader like the mac-address property?
Yeah, I'm fine with either way, as long as we get rid of the warning.
I will post v2 shortly.
Shawn
next prev parent reply other threads:[~2018-02-26 4:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-24 7:04 [PATCH] arm64: dts: ls1046a: drop incomplete memory node Shawn Guo
2018-02-24 7:04 ` Shawn Guo
2018-02-26 1:33 ` Leo Li
2018-02-26 1:33 ` Leo Li
2018-02-26 4:35 ` Shawn Guo [this message]
2018-02-26 4:35 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180226043532.GT3217@dragon \
--to=shawnguo@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.