From: parri.andrea@gmail.com (Andrea Parri)
To: linux-riscv@lists.infradead.org
Subject: [PATCH RFC] riscv/barrier: Define __smp_{mb,rmb,wmb}
Date: Mon, 26 Feb 2018 11:35:52 +0100 [thread overview]
Message-ID: <20180226103552.GA9138@andrea> (raw)
In-Reply-To: <mhng-438aa1d8-2507-49a6-93d4-8622b6018ffd@palmer-si-x1c4>
On Thu, Feb 22, 2018 at 03:14:52PM -0800, Palmer Dabbelt wrote:
> On Tue, 20 Feb 2018 02:17:28 PST (-0800), parri.andrea at gmail.com wrote:
> >Introduce __smp_{mb,rmb,wmb}, and rely on the generic definitions
> >for smp_{mb,rmb,wmb}. A first consequence is that smp_{mb,rmb,wmb}
> >map to a compiler barrier on !SMP (while their definition remains
> >unchanged on SMP). As a further consequence, smp_load_acquire and
> >smp_store_release have "fence rw,rw" instead of "fence iorw,iorw".
> >
> >Signed-off-by: Andrea Parri <parri.andrea@gmail.com>
> >---
> > arch/riscv/include/asm/barrier.h | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> >diff --git a/arch/riscv/include/asm/barrier.h b/arch/riscv/include/asm/barrier.h
> >index c0319cbf1eec5..5510366d169ae 100644
> >--- a/arch/riscv/include/asm/barrier.h
> >+++ b/arch/riscv/include/asm/barrier.h
> >@@ -34,9 +34,9 @@
> > #define wmb() RISCV_FENCE(ow,ow)
> >
> > /* These barriers do not need to enforce ordering on devices, just memory. */
> >-#define smp_mb() RISCV_FENCE(rw,rw)
> >-#define smp_rmb() RISCV_FENCE(r,r)
> >-#define smp_wmb() RISCV_FENCE(w,w)
> >+#define __smp_mb() RISCV_FENCE(rw,rw)
> >+#define __smp_rmb() RISCV_FENCE(r,r)
> >+#define __smp_wmb() RISCV_FENCE(w,w)
> >
> > /*
> > * This is a very specific barrier: it's currently only used in two places in
>
> Thanks! I'm going to take this for the next RC.
Thank you, Palmer. I'm planning to post more changes to the file,
but I'd like to build on top of this change: could you point me to
the appropriate branch/repo for this?
Andrea
WARNING: multiple messages have this Message-ID (diff)
From: Andrea Parri <parri.andrea@gmail.com>
To: Palmer Dabbelt <palmer@sifive.com>
Cc: albert@sifive.com, linux-riscv@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC] riscv/barrier: Define __smp_{mb,rmb,wmb}
Date: Mon, 26 Feb 2018 11:35:52 +0100 [thread overview]
Message-ID: <20180226103552.GA9138@andrea> (raw)
In-Reply-To: <mhng-438aa1d8-2507-49a6-93d4-8622b6018ffd@palmer-si-x1c4>
On Thu, Feb 22, 2018 at 03:14:52PM -0800, Palmer Dabbelt wrote:
> On Tue, 20 Feb 2018 02:17:28 PST (-0800), parri.andrea@gmail.com wrote:
> >Introduce __smp_{mb,rmb,wmb}, and rely on the generic definitions
> >for smp_{mb,rmb,wmb}. A first consequence is that smp_{mb,rmb,wmb}
> >map to a compiler barrier on !SMP (while their definition remains
> >unchanged on SMP). As a further consequence, smp_load_acquire and
> >smp_store_release have "fence rw,rw" instead of "fence iorw,iorw".
> >
> >Signed-off-by: Andrea Parri <parri.andrea@gmail.com>
> >---
> > arch/riscv/include/asm/barrier.h | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> >diff --git a/arch/riscv/include/asm/barrier.h b/arch/riscv/include/asm/barrier.h
> >index c0319cbf1eec5..5510366d169ae 100644
> >--- a/arch/riscv/include/asm/barrier.h
> >+++ b/arch/riscv/include/asm/barrier.h
> >@@ -34,9 +34,9 @@
> > #define wmb() RISCV_FENCE(ow,ow)
> >
> > /* These barriers do not need to enforce ordering on devices, just memory. */
> >-#define smp_mb() RISCV_FENCE(rw,rw)
> >-#define smp_rmb() RISCV_FENCE(r,r)
> >-#define smp_wmb() RISCV_FENCE(w,w)
> >+#define __smp_mb() RISCV_FENCE(rw,rw)
> >+#define __smp_rmb() RISCV_FENCE(r,r)
> >+#define __smp_wmb() RISCV_FENCE(w,w)
> >
> > /*
> > * This is a very specific barrier: it's currently only used in two places in
>
> Thanks! I'm going to take this for the next RC.
Thank you, Palmer. I'm planning to post more changes to the file,
but I'd like to build on top of this change: could you point me to
the appropriate branch/repo for this?
Andrea
next prev parent reply other threads:[~2018-02-26 10:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-20 10:17 [PATCH RFC] riscv/barrier: Define __smp_{mb,rmb,wmb} Andrea Parri
2018-02-20 10:17 ` Andrea Parri
2018-02-22 23:14 ` Palmer Dabbelt
2018-02-22 23:14 ` Palmer Dabbelt
2018-02-26 10:35 ` Andrea Parri [this message]
2018-02-26 10:35 ` Andrea Parri
2018-02-27 1:28 ` Palmer Dabbelt
2018-02-27 1:28 ` Palmer Dabbelt
2018-02-27 2:27 ` Andrea Parri
2018-02-27 2:27 ` Andrea Parri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180226103552.GA9138@andrea \
--to=parri.andrea@gmail.com \
--cc=linux-riscv@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.