All of lore.kernel.org
 help / color / mirror / Atom feed
From: Philipp Rudo <prudo@linux.vnet.ibm.com>
To: kexec@lists.infradead.org, linux-s390@vger.kernel.org
Cc: AKASHI Takahiro <takahiro.akashi@linaro.org>,
	Michael Ellerman <mpe@ellerman.id.au>,
	x86@kernel.org, Heiko Carstens <heiko.carstens@de.ibm.com>,
	linux-kernel@vger.kernel.org,
	Martin Schwidefsky <schwidefsky@de.ibm.com>,
	Eric Biederman <ebiederm@xmission.com>,
	Thiago Jung Bauermann <bauerman@linux.vnet.ibm.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Dave Young <dyoung@redhat.com>, Vivek Goyal <vgoyal@redhat.com>
Subject: [PATCH 01/11] kexec_file: Silence compile warnings
Date: Mon, 26 Feb 2018 16:16:10 +0100	[thread overview]
Message-ID: <20180226151620.20970-2-prudo@linux.vnet.ibm.com> (raw)
In-Reply-To: <20180226151620.20970-1-prudo@linux.vnet.ibm.com>

When building the kernel with CONFIG_KEXEC_FILE enabled gcc prints a
compile warning multiple times.

In file included from <path>/linux/init/initramfs.c:526:0:
<path>/include/linux/kexec.h:120:9: warning: ‘struct kimage’ declared inside parameter list [enabled by default]
         unsigned long cmdline_len);
         ^
This is because the typedefs for kexec_file_load uses struct kimage before
it is declared. Fix this by simply forward declaring struct kimage.

Signed-off-by: Philipp Rudo <prudo@linux.vnet.ibm.com>
---
 include/linux/kexec.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/include/linux/kexec.h b/include/linux/kexec.h
index f16f6ceb3875..7bae5e87bf0d 100644
--- a/include/linux/kexec.h
+++ b/include/linux/kexec.h
@@ -114,6 +114,8 @@ struct purgatory_info {
 	unsigned long purgatory_load_addr;
 };
 
+struct kimage;
+
 typedef int (kexec_probe_t)(const char *kernel_buf, unsigned long kernel_size);
 typedef void *(kexec_load_t)(struct kimage *image, char *kernel_buf,
 			     unsigned long kernel_len, char *initrd,
-- 
2.13.5


_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

WARNING: multiple messages have this Message-ID (diff)
From: Philipp Rudo <prudo@linux.vnet.ibm.com>
To: kexec@lists.infradead.org, linux-s390@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
	Eric Biederman <ebiederm@xmission.com>,
	Vivek Goyal <vgoyal@redhat.com>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Thiago Jung Bauermann <bauerman@linux.vnet.ibm.com>,
	Martin Schwidefsky <schwidefsky@de.ibm.com>,
	Heiko Carstens <heiko.carstens@de.ibm.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	x86@kernel.org, Dave Young <dyoung@redhat.com>,
	AKASHI Takahiro <takahiro.akashi@linaro.org>
Subject: [PATCH 01/11] kexec_file: Silence compile warnings
Date: Mon, 26 Feb 2018 16:16:10 +0100	[thread overview]
Message-ID: <20180226151620.20970-2-prudo@linux.vnet.ibm.com> (raw)
In-Reply-To: <20180226151620.20970-1-prudo@linux.vnet.ibm.com>

When building the kernel with CONFIG_KEXEC_FILE enabled gcc prints a
compile warning multiple times.

In file included from <path>/linux/init/initramfs.c:526:0:
<path>/include/linux/kexec.h:120:9: warning: ‘struct kimage’ declared inside parameter list [enabled by default]
         unsigned long cmdline_len);
         ^
This is because the typedefs for kexec_file_load uses struct kimage before
it is declared. Fix this by simply forward declaring struct kimage.

Signed-off-by: Philipp Rudo <prudo@linux.vnet.ibm.com>
---
 include/linux/kexec.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/include/linux/kexec.h b/include/linux/kexec.h
index f16f6ceb3875..7bae5e87bf0d 100644
--- a/include/linux/kexec.h
+++ b/include/linux/kexec.h
@@ -114,6 +114,8 @@ struct purgatory_info {
 	unsigned long purgatory_load_addr;
 };
 
+struct kimage;
+
 typedef int (kexec_probe_t)(const char *kernel_buf, unsigned long kernel_size);
 typedef void *(kexec_load_t)(struct kimage *image, char *kernel_buf,
 			     unsigned long kernel_len, char *initrd,
-- 
2.13.5

  reply	other threads:[~2018-02-26 15:16 UTC|newest]

Thread overview: 72+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-26 15:16 [PATCH 00/11] kexec_file: Clean up purgatory load Philipp Rudo
2018-02-26 15:16 ` Philipp Rudo
2018-02-26 15:16 ` Philipp Rudo [this message]
2018-02-26 15:16   ` [PATCH 01/11] kexec_file: Silence compile warnings Philipp Rudo
2018-02-26 15:16 ` [PATCH 02/11] kexec_file: Remove checks in kexec_purgatory_load Philipp Rudo
2018-02-26 15:16   ` Philipp Rudo
2018-02-26 15:16 ` [PATCH 03/11] kexec_file: Make purgatory_info->ehdr const Philipp Rudo
2018-02-26 15:16   ` Philipp Rudo
2018-02-26 15:16 ` [PATCH 04/11] kexec_file: Search symbols in read-only kexec_purgatory Philipp Rudo
2018-02-26 15:16   ` Philipp Rudo
2018-02-26 15:16 ` [PATCH 05/11] kexec_file: Use read-only sections in arch_kexec_apply_relocations* Philipp Rudo
2018-02-26 15:16   ` Philipp Rudo
2018-02-28 15:37   ` kbuild test robot
2018-02-28 15:37     ` kbuild test robot
2018-02-28 16:32   ` kbuild test robot
2018-02-28 16:32     ` kbuild test robot
2018-02-26 15:16 ` [PATCH 06/11] kexec_file: Split up __kexec_load_puragory Philipp Rudo
2018-02-26 15:16   ` Philipp Rudo
2018-02-26 15:16 ` [PATCH 07/11] kexec_file: Simplify kexec_purgatory_setup_sechdrs 1 Philipp Rudo
2018-02-26 15:16   ` Philipp Rudo
2018-02-28 22:49   ` kbuild test robot
2018-02-28 22:49     ` kbuild test robot
2018-02-26 15:16 ` [PATCH 08/11] kexec_file: Simplify kexec_purgatory_setup_sechdrs 2 Philipp Rudo
2018-02-26 15:16   ` Philipp Rudo
2018-03-09  3:18   ` Dave Young
2018-03-09  3:18     ` Dave Young
2018-03-09  9:54     ` Philipp Rudo
2018-03-09  9:54       ` Philipp Rudo
2018-02-26 15:16 ` [PATCH 09/11] kexec_file: Remove mis-use of sh_offset field Philipp Rudo
2018-02-26 15:16   ` Philipp Rudo
2018-03-09  3:14   ` Dave Young
2018-03-09  3:14     ` Dave Young
2018-03-09 10:02     ` Philipp Rudo
2018-03-09 10:02       ` Philipp Rudo
2018-03-12  7:42       ` Dave Young
2018-03-12  7:42         ` Dave Young
2018-03-12  9:42         ` Philipp Rudo
2018-03-12  9:42           ` Philipp Rudo
2018-02-26 15:16 ` [PATCH 10/11] kexec_file: Allow archs to set purgatory load address Philipp Rudo
2018-02-26 15:16   ` Philipp Rudo
2018-02-28 15:50   ` kbuild test robot
2018-02-28 15:50     ` kbuild test robot
2018-02-28 16:02   ` kbuild test robot
2018-02-28 16:02     ` kbuild test robot
2018-02-26 15:16 ` [PATCH 11/11] kexec_file: Move purgatories sha256 to common code Philipp Rudo
2018-02-26 15:16   ` Philipp Rudo
2018-03-09  4:43   ` Dave Young
2018-03-09  4:43     ` Dave Young
2018-03-09 10:11     ` Philipp Rudo
2018-03-09 10:11       ` Philipp Rudo
2018-03-09  5:19 ` [PATCH 00/11] kexec_file: Clean up purgatory load Dave Young
2018-03-09  5:19   ` Dave Young
2018-03-09  5:33   ` Dave Young
2018-03-09  5:33     ` Dave Young
2018-03-09 10:13     ` Philipp Rudo
2018-03-09 10:13       ` Philipp Rudo
2018-03-09 14:25   ` Philipp Rudo
2018-03-09 14:25     ` Philipp Rudo
2018-03-12  7:40     ` Dave Young
2018-03-12  7:40       ` Dave Young
2018-03-14  9:51       ` Philipp Rudo
2018-03-14  9:51         ` Philipp Rudo
2018-03-15  7:34       ` Dave Young
2018-03-15  7:34         ` Dave Young
2018-03-15 10:13         ` Philipp Rudo
2018-03-15 10:13           ` Philipp Rudo
2018-03-16  6:41           ` Dave Young
2018-03-16  6:41             ` Dave Young
2018-03-20  9:39             ` Philipp Rudo
2018-03-20  9:39               ` Philipp Rudo
2018-03-20  9:49               ` Dave Young
2018-03-20  9:49                 ` Dave Young

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180226151620.20970-2-prudo@linux.vnet.ibm.com \
    --to=prudo@linux.vnet.ibm.com \
    --cc=akpm@linux-foundation.org \
    --cc=bauerman@linux.vnet.ibm.com \
    --cc=dyoung@redhat.com \
    --cc=ebiederm@xmission.com \
    --cc=heiko.carstens@de.ibm.com \
    --cc=kexec@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=mpe@ellerman.id.au \
    --cc=schwidefsky@de.ibm.com \
    --cc=takahiro.akashi@linaro.org \
    --cc=vgoyal@redhat.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.