* [PATCH] drm: Include the header with the prototype for drm_get_panel_orientation_quirk()
@ 2018-02-26 14:24 Ville Syrjala
2018-02-26 14:35 ` Hans de Goede
0 siblings, 1 reply; 3+ messages in thread
From: Ville Syrjala @ 2018-02-26 14:24 UTC (permalink / raw)
To: dri-devel; +Cc: Hans de Goede, Daniel Vetter
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
sparse complains:
drivers/gpu/drm/drm_panel_orientation_quirks.c:133:5: warning: symbol 'drm_get_panel_orientation_quirk' was not declared. Should it be static?
Cc: Hans de Goede <hdegoede@redhat.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/drm_panel_orientation_quirks.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c
index 1f2af707ce03..902cc1a71e45 100644
--- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
+++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
@@ -11,6 +11,7 @@
#include <linux/dmi.h>
#include <linux/module.h>
#include <drm/drm_connector.h>
+#include <drm/drm_utils.h>
#ifdef CONFIG_DMI
--
2.13.6
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm: Include the header with the prototype for drm_get_panel_orientation_quirk()
2018-02-26 14:24 [PATCH] drm: Include the header with the prototype for drm_get_panel_orientation_quirk() Ville Syrjala
@ 2018-02-26 14:35 ` Hans de Goede
2018-02-26 15:42 ` Ville Syrjälä
0 siblings, 1 reply; 3+ messages in thread
From: Hans de Goede @ 2018-02-26 14:35 UTC (permalink / raw)
To: Ville Syrjala, dri-devel; +Cc: Daniel Vetter
Hi,
On 26-02-18 15:24, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> sparse complains:
> drivers/gpu/drm/drm_panel_orientation_quirks.c:133:5: warning: symbol 'drm_get_panel_orientation_quirk' was not declared. Should it be static?
>
> Cc: Hans de Goede <hdegoede@redhat.com>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Good catch:
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
> ---
> drivers/gpu/drm/drm_panel_orientation_quirks.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> index 1f2af707ce03..902cc1a71e45 100644
> --- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
> +++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> @@ -11,6 +11,7 @@
> #include <linux/dmi.h>
> #include <linux/module.h>
> #include <drm/drm_connector.h>
> +#include <drm/drm_utils.h>
>
> #ifdef CONFIG_DMI
>
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm: Include the header with the prototype for drm_get_panel_orientation_quirk()
2018-02-26 14:35 ` Hans de Goede
@ 2018-02-26 15:42 ` Ville Syrjälä
0 siblings, 0 replies; 3+ messages in thread
From: Ville Syrjälä @ 2018-02-26 15:42 UTC (permalink / raw)
To: Hans de Goede; +Cc: Daniel Vetter, dri-devel
On Mon, Feb 26, 2018 at 03:35:34PM +0100, Hans de Goede wrote:
> Hi,
>
> On 26-02-18 15:24, Ville Syrjala wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > sparse complains:
> > drivers/gpu/drm/drm_panel_orientation_quirks.c:133:5: warning: symbol 'drm_get_panel_orientation_quirk' was not declared. Should it be static?
> >
> > Cc: Hans de Goede <hdegoede@redhat.com>
> > Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Good catch:
>
> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Thanks. Pushed to drm-misc-next.
>
> Regards,
>
> Hans
>
> > ---
> > drivers/gpu/drm/drm_panel_orientation_quirks.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> > index 1f2af707ce03..902cc1a71e45 100644
> > --- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
> > +++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> > @@ -11,6 +11,7 @@
> > #include <linux/dmi.h>
> > #include <linux/module.h>
> > #include <drm/drm_connector.h>
> > +#include <drm/drm_utils.h>
> >
> > #ifdef CONFIG_DMI
> >
> >
--
Ville Syrjälä
Intel OTC
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-02-26 15:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-02-26 14:24 [PATCH] drm: Include the header with the prototype for drm_get_panel_orientation_quirk() Ville Syrjala
2018-02-26 14:35 ` Hans de Goede
2018-02-26 15:42 ` Ville Syrjälä
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.