* [PATCH] staging: rtl8723bs: use kmemdup for allocation and copy
@ 2018-02-27 21:44 Dafna Hirschfeld
0 siblings, 0 replies; only message in thread
From: Dafna Hirschfeld @ 2018-02-27 21:44 UTC (permalink / raw)
To: gregkh; +Cc: outreachy-kernel
Use kmemdup instead of kzalloc and memcpy to simplify the code.
Issue found with coccicheck.
Signed-off-by: Dafna Hirschfeld <dafna3@gmail.com>
---
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
index d6cef9e..0ce9b47 100644
--- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
+++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
@@ -433,13 +433,12 @@ s32 rtl8723b_FirmwareDownload(struct adapter *padapter, bool bUsedWoWLANFw)
goto exit;
}
- pFirmware->szFwBuffer = kzalloc(fw->size, GFP_KERNEL);
+ pFirmware->szFwBuffer = kmemdup(fw->data, fw->size, GFP_KERNEL);
if (!pFirmware->szFwBuffer) {
rtStatus = _FAIL;
goto exit;
}
- memcpy(pFirmware->szFwBuffer, fw->data, fw->size);
pFirmware->ulFwLength = fw->size;
release_firmware(fw);
if (pFirmware->ulFwLength > FW_8723B_SIZE) {
--
2.7.4
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2018-02-27 21:44 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-02-27 21:44 [PATCH] staging: rtl8723bs: use kmemdup for allocation and copy Dafna Hirschfeld
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.