From: jglauber@cavium.com (Jan Glauber)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH -stable] arm64: mm: don't write garbage into TTBR1_EL1 register
Date: Wed, 28 Feb 2018 11:23:35 +0100 [thread overview]
Message-ID: <20180228102335.GA6619@wintermute> (raw)
In-Reply-To: <20180226113050.GE8736@arm.com>
On Mon, Feb 26, 2018 at 11:30:50AM +0000, Will Deacon wrote:
> Damnit, sorry again. I changed the argument order of phys_to_ttbr along
> the way, so must've confused myself during the backporting exercise. It's
> also one of those things that will lead to potential TLB corruption in rare
> circumstances where the junk in TTBR1 ends up giving a valid translation,
> so it didn't crop up in my testing. How did Nicolas see this? The bug
> report I saw didn't look related.
FWIW, we've been hitting this bug with a distribution backport on
ThunderX2 on every boot. Due to bad luck there was a non-zero value
in TTBR1 that crashed the kernel immediately and dropped us to firmware.
--Jan
WARNING: multiple messages have this Message-ID (diff)
From: Jan Glauber <jglauber@cavium.com>
To: Will Deacon <will.deacon@arm.com>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Mark Rutland <mark.rutland@arm.com>,
Marc Zyngier <marc.zyngier@arm.com>,
Greg KH <gregkh@linuxfoundation.org>,
stable@vger.kernel.org, Catalin Marinas <catalin.marinas@arm.com>,
Nicolas Dechesne <nicolas.dechesne@linaro.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH -stable] arm64: mm: don't write garbage into TTBR1_EL1 register
Date: Wed, 28 Feb 2018 11:23:35 +0100 [thread overview]
Message-ID: <20180228102335.GA6619@wintermute> (raw)
In-Reply-To: <20180226113050.GE8736@arm.com>
On Mon, Feb 26, 2018 at 11:30:50AM +0000, Will Deacon wrote:
> Damnit, sorry again. I changed the argument order of phys_to_ttbr along
> the way, so must've confused myself during the backporting exercise. It's
> also one of those things that will lead to potential TLB corruption in rare
> circumstances where the junk in TTBR1 ends up giving a valid translation,
> so it didn't crop up in my testing. How did Nicolas see this? The bug
> report I saw didn't look related.
FWIW, we've been hitting this bug with a distribution backport on
ThunderX2 on every boot. Due to bad luck there was a non-zero value
in TTBR1 that crashed the kernel immediately and dropped us to firmware.
--Jan
next prev parent reply other threads:[~2018-02-28 10:23 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-23 18:29 [PATCH -stable] arm64: mm: don't write garbage into TTBR1_EL1 register Ard Biesheuvel
2018-02-23 20:33 ` Nicolas Dechesne
2018-02-24 8:34 ` Greg KH
2018-02-24 8:34 ` Greg KH
2018-02-24 8:49 ` Nicolas Dechesne
2018-02-24 8:49 ` Nicolas Dechesne
2018-02-24 8:50 ` Ard Biesheuvel
2018-02-24 8:50 ` Ard Biesheuvel
2018-02-26 11:30 ` Will Deacon
2018-02-26 11:30 ` Will Deacon
2018-02-26 11:37 ` Ard Biesheuvel
2018-02-26 11:37 ` Ard Biesheuvel
2018-02-28 10:23 ` Jan Glauber [this message]
2018-02-28 10:23 ` Jan Glauber
2018-02-26 13:02 ` Patch "arm64: mm: don't write garbage into TTBR1_EL1 register" has been added to the 4.14-stable tree gregkh
2018-02-26 13:02 ` Patch "arm64: mm: don't write garbage into TTBR1_EL1 register" has been added to the 4.15-stable tree gregkh
2018-02-26 13:02 ` Patch "arm64: mm: don't write garbage into TTBR1_EL1 register" has been added to the 4.4-stable tree gregkh
2018-02-26 13:09 ` Ard Biesheuvel
2018-02-26 14:26 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180228102335.GA6619@wintermute \
--to=jglauber@cavium.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.