[PATCH v3] staging: rtl8192e: use struct pointer to get the size of the struct

[PATCH v3] staging: rtl8192e: use struct pointer to get the size of the struct

[Santha Meena Ramamoorthy]

Use pointer to the structure to get the size of the structure in order
to conform to the Linux kernel coding style. Issue found using
checkpatch.

Signed-off-by: Santha Meena Ramamoorthy <santhameena13@gmail.com>
---
Change in v2:
 - Use single line when the number of characters is less than 80
Change in v3:
 - Improve the subject line and the commit message
No code change since v2
 drivers/staging/rtl8192e/rtllib_wx.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8192e/rtllib_wx.c b/drivers/staging/rtl8192e/rtllib_wx.c
index 03fbff0..74d4d2d 100644
--- a/drivers/staging/rtl8192e/rtllib_wx.c
+++ b/drivers/staging/rtl8192e/rtllib_wx.c
@@ -371,8 +371,7 @@ int rtllib_wx_set_encode(struct rtllib_device *ieee,
 		struct lib80211_crypt_data *new_crypt;
 
 		/* take WEP into use */
-		new_crypt = kzalloc(sizeof(struct lib80211_crypt_data),
-				    GFP_KERNEL);
+		new_crypt = kzalloc(sizeof(*new_crypt), GFP_KERNEL);
 		if (new_crypt == NULL)
 			return -ENOMEM;
 		new_crypt->ops = lib80211_get_crypto_ops("R-WEP");
-- 
2.7.4

Re: [Outreachy kernel] [PATCH v3] staging: rtl8192e: use struct pointer to get the size of the struct

[Julia Lawall]

On Sat, 24 Feb 2018, Santha Meena Ramamoorthy wrote:

> Use pointer to the structure to get the size of the structure in order
> to conform to the Linux kernel coding style. Issue found using
> checkpatch.
>
> Signed-off-by: Santha Meena Ramamoorthy <santhameena13@gmail.com>

Acked-by: Julia Lawall <julia.lawall@lip6.fr>

> ---
> Change in v2:
>  - Use single line when the number of characters is less than 80
> Change in v3:
>  - Improve the subject line and the commit message
> No code change since v2

Actually, the most recent change description should come first.

julia

>  drivers/staging/rtl8192e/rtllib_wx.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8192e/rtllib_wx.c b/drivers/staging/rtl8192e/rtllib_wx.c
> index 03fbff0..74d4d2d 100644
> --- a/drivers/staging/rtl8192e/rtllib_wx.c
> +++ b/drivers/staging/rtl8192e/rtllib_wx.c
> @@ -371,8 +371,7 @@ int rtllib_wx_set_encode(struct rtllib_device *ieee,
>  		struct lib80211_crypt_data *new_crypt;
>
>  		/* take WEP into use */
> -		new_crypt = kzalloc(sizeof(struct lib80211_crypt_data),
> -				    GFP_KERNEL);
> +		new_crypt = kzalloc(sizeof(*new_crypt), GFP_KERNEL);
>  		if (new_crypt == NULL)
>  			return -ENOMEM;
>  		new_crypt->ops = lib80211_get_crypto_ops("R-WEP");
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1519508793-11537-1-git-send-email-santhameena13%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>

Re: [Outreachy kernel] [PATCH v3] staging: rtl8192e: use struct pointer to get the size of the struct

[Santha Meena Ramamoorthy]

On Sun, Feb 25, 2018 at 10:12:38AM +0100, Julia Lawall wrote:
> 
> 
> On Sat, 24 Feb 2018, Santha Meena Ramamoorthy wrote:
> 
> > Use pointer to the structure to get the size of the structure in order
> > to conform to the Linux kernel coding style. Issue found using
> > checkpatch.
> >
> > Signed-off-by: Santha Meena Ramamoorthy <santhameena13@gmail.com>
> 
> Acked-by: Julia Lawall <julia.lawall@lip6.fr>
> 
> > ---
> > Change in v2:
> >  - Use single line when the number of characters is less than 80
> > Change in v3:
> >  - Improve the subject line and the commit message
> > No code change since v2
> 
> Actually, the most recent change description should come first.
> 
> julia

Sorry, I'll remember that :)
> 
> >  drivers/staging/rtl8192e/rtllib_wx.c | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/drivers/staging/rtl8192e/rtllib_wx.c b/drivers/staging/rtl8192e/rtllib_wx.c
> > index 03fbff0..74d4d2d 100644
> > --- a/drivers/staging/rtl8192e/rtllib_wx.c
> > +++ b/drivers/staging/rtl8192e/rtllib_wx.c
> > @@ -371,8 +371,7 @@ int rtllib_wx_set_encode(struct rtllib_device *ieee,
> >  		struct lib80211_crypt_data *new_crypt;
> >
> >  		/* take WEP into use */
> > -		new_crypt = kzalloc(sizeof(struct lib80211_crypt_data),
> > -				    GFP_KERNEL);
> > +		new_crypt = kzalloc(sizeof(*new_crypt), GFP_KERNEL);
> >  		if (new_crypt == NULL)
> >  			return -ENOMEM;
> >  		new_crypt->ops = lib80211_get_crypto_ops("R-WEP");
> > --
> > 2.7.4
> >
> > --
> > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > To post to this group, send email to outreachy-kernel@googlegroups.com.
> > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1519508793-11537-1-git-send-email-santhameena13%40gmail.com.
> > For more options, visit https://groups.google.com/d/optout.
> >