Re: [PATCH v2] drm/panel: simple: Add TVC S9700RTWV43TR-01B 800x480 panel support

From: Thierry Reding <thierry.reding@gmail.com>
To: Jyri Sarha <jsarha@ti.com>
Cc: airlied@linux.ie, tomi.valkeinen@ti.com, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v2] drm/panel: simple: Add TVC S9700RTWV43TR-01B 800x480 panel support
Date: Wed, 28 Feb 2018 19:44:55 +0100	[thread overview]
Message-ID: <20180228184453.GA22932@mithrandir> (raw)
In-Reply-To: <1519814443-29147-1-git-send-email-jsarha@ti.com>

[-- Attachment #1.1: Type: text/plain, Size: 1148 bytes --]

On Wed, Feb 28, 2018 at 12:40:43PM +0200, Jyri Sarha wrote:
> Add support for TVC S9700RTWV43TR-01B 800x480 panel found on TI's
> AM335X-EVM.
> 
> Signed-off-by: Jyri Sarha <jsarha@ti.com>
> Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
> ---
> The only change is added "Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ti.com>".
> Who is going to pick this up?
> 
> The first version of the patch can be found here:
> https://lists.freedesktop.org/archives/dri-devel/2018-February/166902.html
> 
>  drivers/gpu/drm/panel/panel-simple.c | 26 ++++++++++++++++++++++++++
>  1 file changed, 26 insertions(+)
> 
> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> index 5591984..3b0ba9f 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -1962,6 +1962,29 @@ static const struct panel_desc tpk_f10a_0102 = {
>  	},
>  };
>  
> +static const struct drm_display_mode tvc_s9700rtwv43tr_01b_mode = {
> +	.clock = 3000,

This seems to be missing a 0. Does the panel even work with 3 MHz? I'd
be somewhat surprised if it did.

Thierry

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel