All of lore.kernel.org
 help / color / mirror / Atom feed
From: idosch at idosch.org (Ido Schimmel)
Subject: [PATCH net-next 3/5] selftests: forwarding: Handle 0 for packet difference in multipath tests
Date: Thu, 1 Mar 2018 21:37:36 +0200	[thread overview]
Message-ID: <20180301193736.GC4839@splinter> (raw)
In-Reply-To: <20180301190947.7299-4-dsahern@gmail.com>

On Thu, Mar 01, 2018 at 11:09:45AM -0800, David Ahern wrote:
> If the packet stats have a difference of 0, the test output shows:
> INFO: Expected ratio 2.00 Measured ratio
> Runtime error (func=(main), adr=9): Divide by zero
> (standard_in) 2: syntax error
> (standard_in) 1: syntax error
> ./router_multipath.sh: line 187: test: : integer expression expected
> TEST: Multipath                                                     [FAIL]
> 	Too large discrepancy between expected and measured ratios
> 
> Handle the 0 and display a cleaner message:
> INFO: Running IPv6 multipath tests
> TEST: Multipath                                                     [FAIL]
> 	Packet difference is 0
> 
> Signed-off-by: David Ahern <dsahern at gmail.com>

Reviewed-by: Ido Schimmel <idosch at mellanox.com>

Thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: idosch@idosch.org (Ido Schimmel)
Subject: [PATCH net-next 3/5] selftests: forwarding: Handle 0 for packet difference in multipath tests
Date: Thu, 1 Mar 2018 21:37:36 +0200	[thread overview]
Message-ID: <20180301193736.GC4839@splinter> (raw)
Message-ID: <20180301193736.3KXsOVuW-CYWug65LIYZXzf4N4bLMks_XhQGZu_ySso@z> (raw)
In-Reply-To: <20180301190947.7299-4-dsahern@gmail.com>

On Thu, Mar 01, 2018@11:09:45AM -0800, David Ahern wrote:
> If the packet stats have a difference of 0, the test output shows:
> INFO: Expected ratio 2.00 Measured ratio
> Runtime error (func=(main), adr=9): Divide by zero
> (standard_in) 2: syntax error
> (standard_in) 1: syntax error
> ./router_multipath.sh: line 187: test: : integer expression expected
> TEST: Multipath                                                     [FAIL]
> 	Too large discrepancy between expected and measured ratios
> 
> Handle the 0 and display a cleaner message:
> INFO: Running IPv6 multipath tests
> TEST: Multipath                                                     [FAIL]
> 	Packet difference is 0
> 
> Signed-off-by: David Ahern <dsahern at gmail.com>

Reviewed-by: Ido Schimmel <idosch at mellanox.com>

Thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Ido Schimmel <idosch@idosch.org>
To: David Ahern <dsahern@gmail.com>
Cc: netdev@vger.kernel.org, linux-kselftest@vger.kernel.org,
	idosch@mellanox.com, jiri@mellanox.com
Subject: Re: [PATCH net-next 3/5] selftests: forwarding: Handle 0 for packet difference in multipath tests
Date: Thu, 1 Mar 2018 21:37:36 +0200	[thread overview]
Message-ID: <20180301193736.GC4839@splinter> (raw)
In-Reply-To: <20180301190947.7299-4-dsahern@gmail.com>

On Thu, Mar 01, 2018 at 11:09:45AM -0800, David Ahern wrote:
> If the packet stats have a difference of 0, the test output shows:
> INFO: Expected ratio 2.00 Measured ratio
> Runtime error (func=(main), adr=9): Divide by zero
> (standard_in) 2: syntax error
> (standard_in) 1: syntax error
> ./router_multipath.sh: line 187: test: : integer expression expected
> TEST: Multipath                                                     [FAIL]
> 	Too large discrepancy between expected and measured ratios
> 
> Handle the 0 and display a cleaner message:
> INFO: Running IPv6 multipath tests
> TEST: Multipath                                                     [FAIL]
> 	Packet difference is 0
> 
> Signed-off-by: David Ahern <dsahern@gmail.com>

Reviewed-by: Ido Schimmel <idosch@mellanox.com>

Thanks!

  reply	other threads:[~2018-03-01 19:37 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-01 19:09 [PATCH net-next 0/5] selftests: forwarding: misc bug fixes and enhancements dsahern
2018-03-01 19:09 ` David Ahern
2018-03-01 19:09 ` David Ahern
2018-03-01 19:09 ` [PATCH net-next 1/5] selftests: forwarding: Only check tc version for tc tests dsahern
2018-03-01 19:09   ` David Ahern
2018-03-01 19:09   ` David Ahern
2018-03-01 20:12   ` idosch
2018-03-01 20:12     ` Ido Schimmel
2018-03-01 20:12     ` Ido Schimmel
2018-03-01 19:09 ` [PATCH net-next 2/5] selftests: forwarding: Only check for mz when it is needed dsahern
2018-03-01 19:09   ` David Ahern
2018-03-01 19:09   ` David Ahern
2018-03-01 19:36   ` idosch
2018-03-01 19:36     ` Ido Schimmel
2018-03-01 19:36     ` Ido Schimmel
2018-03-01 21:44     ` dsahern
2018-03-01 21:44       ` David Ahern
2018-03-01 21:44       ` David Ahern
2018-03-01 19:09 ` [PATCH net-next 3/5] selftests: forwarding: Handle 0 for packet difference in multipath tests dsahern
2018-03-01 19:09   ` David Ahern
2018-03-01 19:09   ` David Ahern
2018-03-01 19:37   ` idosch [this message]
2018-03-01 19:37     ` Ido Schimmel
2018-03-01 19:37     ` Ido Schimmel
2018-03-01 19:09 ` [PATCH net-next 4/5] selftests: forwarding: Use PING6 instead of ping for ipv6 multipath test dsahern
2018-03-01 19:09   ` David Ahern
2018-03-01 19:09   ` David Ahern
2018-03-01 19:39   ` idosch
2018-03-01 19:39     ` Ido Schimmel
2018-03-01 19:39     ` Ido Schimmel
2018-03-01 19:43     ` dsahern
2018-03-01 19:43       ` David Ahern
2018-03-01 19:43       ` David Ahern
2018-03-01 19:49       ` idosch
2018-03-01 19:49         ` Ido Schimmel
2018-03-01 19:49         ` Ido Schimmel
2018-03-01 19:09 ` [PATCH net-next 5/5] selftests: forwarding: Add description to the multipath tests dsahern
2018-03-01 19:09   ` David Ahern
2018-03-01 19:09   ` David Ahern
2018-03-01 19:43   ` idosch
2018-03-01 19:43     ` Ido Schimmel
2018-03-01 19:43     ` Ido Schimmel
2018-03-01 19:27 ` [PATCH net-next 0/5] selftests: forwarding: misc bug fixes and enhancements idosch
2018-03-01 19:27   ` Ido Schimmel
2018-03-01 19:27   ` Ido Schimmel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180301193736.GC4839@splinter \
    --to=unknown@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.