All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ladislav Michl <ladis@linux-mips.org>
To: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org,
	kbuild test robot <fengguang.wu@intel.com>,
	kbuild-all@01.org
Subject: Re: [asoc:topic/max9867 2/4] sound/soc/codecs/max9867.c:294:11: error: 'component' undeclared; did you mean 'complete'?
Date: Thu, 1 Mar 2018 21:01:56 +0100	[thread overview]
Message-ID: <20180301200155.GA2304@lenoch> (raw)
In-Reply-To: <201803020314.sOjeazAH%fengguang.wu@intel.com>

Mark,

On Fri, Mar 02, 2018 at 03:45:16AM +0800, kbuild test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git topic/max9867
> head:   79e139744508105bd749300f364563934bff23f2
> commit: 8b9c716aada77e72e2fe82320aba5a95b75ca400 [2/4] ASoC: max9867: Improve error logging
> config: i386-allmodconfig (attached as .config)
> compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
> reproduce:
>         git checkout 8b9c716aada77e72e2fe82320aba5a95b75ca400
>         # save the attached .config to linux build tree
>         make ARCH=i386 
> 
> All errors (new ones prefixed by >>):
> 
>    sound/soc/codecs/max9867.c: In function 'max9867_set_dai_sysclk':
> >> sound/soc/codecs/max9867.c:294:11: error: 'component' undeclared (first use in this function); did you mean 'complete'?
>       dev_err(component->dev,
>               ^~~~~~~~~
>               complete
>    sound/soc/codecs/max9867.c:294:11: note: each undeclared identifier is reported only once for each function it appears in

your topic/max9867 seems to be 4.16-rc1 based, while patch was tested
in today's -next. Fixing it for 4.16-rc1 would mean it fails to compile
once you merge topic branches.

What am I supposed to do here?

Thank you,
	ladis

> vim +294 sound/soc/codecs/max9867.c
> 
>    275	
>    276	static int max9867_set_dai_sysclk(struct snd_soc_dai *codec_dai,
>    277			int clk_id, unsigned int freq, int dir)
>    278	{
>    279		struct snd_soc_codec *codec = codec_dai->codec;
>    280		struct max9867_priv *max9867 = snd_soc_codec_get_drvdata(codec);
>    281		int value = 0;
>    282	
>    283		/* Set the prescaler based on the master clock frequency*/
>    284		if (freq >= 10000000 && freq <= 20000000) {
>    285			value |= MAX9867_PSCLK_10_20;
>    286			max9867->pclk =  freq;
>    287		} else if (freq >= 20000000 && freq <= 40000000) {
>    288			value |= MAX9867_PSCLK_20_40;
>    289			max9867->pclk =  freq/2;
>    290		} else if (freq >= 40000000 && freq <= 60000000) {
>    291			value |= MAX9867_PSCLK_40_60;
>    292			max9867->pclk =  freq/4;
>    293		} else {
>  > 294			dev_err(component->dev,
>    295				"Invalid clock frequency %uHz (required 10-60MHz)\n",
>    296				freq);
>    297			return -EINVAL;
>    298		}
>    299		value = value << MAX9867_PSCLK_SHIFT;
>    300		max9867->sysclk = freq;
>    301		/* exact integer mode is not supported */
>    302		value &= ~MAX9867_FREQ_MASK;
>    303		regmap_update_bits(max9867->regmap, MAX9867_SYSCLK,
>    304				MAX9867_PSCLK_MASK, value);
>    305		return 0;
>    306	}
>    307	
> 
> ---
> 0-DAY kernel test infrastructure                Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

  reply	other threads:[~2018-03-01 20:02 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-01 19:45 [asoc:topic/max9867 2/4] sound/soc/codecs/max9867.c:294:11: error: 'component' undeclared; did you mean 'complete'? kbuild test robot
2018-03-01 20:01 ` Ladislav Michl [this message]
2018-03-01 20:04   ` Mark Brown
2018-03-01 21:34     ` Ladislav Michl
2018-03-01 21:36       ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180301200155.GA2304@lenoch \
    --to=ladis@linux-mips.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=fengguang.wu@intel.com \
    --cc=kbuild-all@01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.